2018-06-06 01:55:52

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] pnfs: Use GFP_ATOMIC under spin lock

A spin lock is taken here so we should use GFP_ATOMIC.

Fixes: 2409a976a299 ("pnfs: Add LAYOUTGET to OPEN of a new file")
Signed-off-by: Wei Yongjun <[email protected]>
---
fs/nfs/pnfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index d93942f..1ff1998 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -2009,7 +2009,7 @@ struct pnfs_layout_segment *
struct pnfs_layout_hdr *lo;

spin_lock(&ino->i_lock);
- lo = pnfs_find_alloc_layout(ino, ctx, GFP_KERNEL);
+ lo = pnfs_find_alloc_layout(ino, ctx, GFP_ATOMIC);
if (!lo)
goto out_unlock;
if (!test_bit(NFS_LAYOUT_INVALID_STID, &lo->plh_flags))



2018-06-06 02:21:21

by Trond Myklebust

[permalink] [raw]
Subject: Re: [PATCH -next] pnfs: Use GFP_ATOMIC under spin lock

T24gV2VkLCAyMDE4LTA2LTA2IGF0IDAyOjAyICswMDAwLCBXZWkgWW9uZ2p1biB3cm90ZToNCj4g
QSBzcGluIGxvY2sgaXMgdGFrZW4gaGVyZSBzbyB3ZSBzaG91bGQgdXNlIEdGUF9BVE9NSUMuDQo+
IA0KPiBGaXhlczogMjQwOWE5NzZhMjk5ICgicG5mczogQWRkIExBWU9VVEdFVCB0byBPUEVOIG9m
IGEgbmV3IGZpbGUiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBXZWkgWW9uZ2p1biA8d2VpeW9uZ2p1bjFA
aHVhd2VpLmNvbT4NCj4gLS0tDQo+ICBmcy9uZnMvcG5mcy5jIHwgMiArLQ0KPiAgMSBmaWxlIGNo
YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEv
ZnMvbmZzL3BuZnMuYyBiL2ZzL25mcy9wbmZzLmMNCj4gaW5kZXggZDkzOTQyZi4uMWZmMTk5OCAx
MDA2NDQNCj4gLS0tIGEvZnMvbmZzL3BuZnMuYw0KPiArKysgYi9mcy9uZnMvcG5mcy5jDQo+IEBA
IC0yMDA5LDcgKzIwMDksNyBAQCBzdHJ1Y3QgcG5mc19sYXlvdXRfc2VnbWVudCAqDQo+ICAJc3Ry
dWN0IHBuZnNfbGF5b3V0X2hkciAqbG87DQo+ICANCj4gIAlzcGluX2xvY2soJmluby0+aV9sb2Nr
KTsNCj4gLQlsbyA9IHBuZnNfZmluZF9hbGxvY19sYXlvdXQoaW5vLCBjdHgsIEdGUF9LRVJORUwp
Ow0KPiArCWxvID0gcG5mc19maW5kX2FsbG9jX2xheW91dChpbm8sIGN0eCwgR0ZQX0FUT01JQyk7
DQo+ICAJaWYgKCFsbykNCj4gIAkJZ290byBvdXRfdW5sb2NrOw0KPiAgCWlmICghdGVzdF9iaXQo
TkZTX0xBWU9VVF9JTlZBTElEX1NUSUQsICZsby0+cGxoX2ZsYWdzKSkNCj4gDQpIaSBXZWksDQoN
ClRoZSBpbm8tPmlfbG9jayBzcGlubG9jayBpcyB0ZW1wb3JhcmlseSBkcm9wcGVkIGluc2lkZQ0K
cG5mc19maW5kX2FsbG9jX2xheW91dCgpIGlmIHdlIGhhdmUgdG8gcGVyZm9ybSBhbiBhbGxvY2F0
aW9uLCBzbyB0aGUNCmV4aXN0aW5nIGNvZGUgc2hvdWxkIGJlIGNvcnJlY3QuDQoNCkNoZWVycw0K
ICBUcm9uZA0KDQotLSANClRyb25kIE15a2xlYnVzdA0KQ1RPLCBIYW1tZXJzcGFjZSBJbmMNCjQz
MDAgRWwgQ2FtaW5vIFJlYWwsIFN1aXRlIDEwNQ0KTG9zIEFsdG9zLCBDQSA5NDAyMg0Kd3d3Lmhh
bW1lci5zcGFjZSBpZD0iLXgtZXZvLXNlbGVjdGlvbi1lbmQtbWFya2VyIj4=

2018-06-06 03:01:50

by Wei Yongjun

[permalink] [raw]
Subject: RE: [PATCH -next] pnfs: Use GFP_ATOMIC under spin lock

PiBTdWJqZWN0OiBSZTogW1BBVENIIC1uZXh0XSBwbmZzOiBVc2UgR0ZQX0FUT01JQyB1bmRlciBz
cGluIGxvY2sNCj4gDQo+IE9uIFdlZCwgMjAxOC0wNi0wNiBhdCAwMjowMiArMDAwMCwgV2VpIFlv
bmdqdW4gd3JvdGU6DQo+ID4gQSBzcGluIGxvY2sgaXMgdGFrZW4gaGVyZSBzbyB3ZSBzaG91bGQg
dXNlIEdGUF9BVE9NSUMuDQo+ID4NCj4gPiBGaXhlczogMjQwOWE5NzZhMjk5ICgicG5mczogQWRk
IExBWU9VVEdFVCB0byBPUEVOIG9mIGEgbmV3IGZpbGUiKQ0KPiA+IFNpZ25lZC1vZmYtYnk6IFdl
aSBZb25nanVuIDx3ZWl5b25nanVuMUBodWF3ZWkuY29tPg0KPiA+IC0tLQ0KPiA+ICBmcy9uZnMv
cG5mcy5jIHwgMiArLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVs
ZXRpb24oLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9mcy9uZnMvcG5mcy5jIGIvZnMvbmZzL3Bu
ZnMuYw0KPiA+IGluZGV4IGQ5Mzk0MmYuLjFmZjE5OTggMTAwNjQ0DQo+ID4gLS0tIGEvZnMvbmZz
L3BuZnMuYw0KPiA+ICsrKyBiL2ZzL25mcy9wbmZzLmMNCj4gPiBAQCAtMjAwOSw3ICsyMDA5LDcg
QEAgc3RydWN0IHBuZnNfbGF5b3V0X3NlZ21lbnQgKg0KPiA+ICAJc3RydWN0IHBuZnNfbGF5b3V0
X2hkciAqbG87DQo+ID4NCj4gPiAgCXNwaW5fbG9jaygmaW5vLT5pX2xvY2spOw0KPiA+IC0JbG8g
PSBwbmZzX2ZpbmRfYWxsb2NfbGF5b3V0KGlubywgY3R4LCBHRlBfS0VSTkVMKTsNCj4gPiArCWxv
ID0gcG5mc19maW5kX2FsbG9jX2xheW91dChpbm8sIGN0eCwgR0ZQX0FUT01JQyk7DQo+ID4gIAlp
ZiAoIWxvKQ0KPiA+ICAJCWdvdG8gb3V0X3VubG9jazsNCj4gPiAgCWlmICghdGVzdF9iaXQoTkZT
X0xBWU9VVF9JTlZBTElEX1NUSUQsICZsby0+cGxoX2ZsYWdzKSkNCj4gPg0KPiBIaSBXZWksDQo+
IA0KPiBUaGUgaW5vLT5pX2xvY2sgc3BpbmxvY2sgaXMgdGVtcG9yYXJpbHkgZHJvcHBlZCBpbnNp
ZGUNCj4gcG5mc19maW5kX2FsbG9jX2xheW91dCgpIGlmIHdlIGhhdmUgdG8gcGVyZm9ybSBhbiBh
bGxvY2F0aW9uLCBzbyB0aGUNCj4gZXhpc3RpbmcgY29kZSBzaG91bGQgYmUgY29ycmVjdC4NCg0K
SGkgVHJvbmQsDQoNClllcywgeW91IGFyZSByaWdodCwgdGhhbmtzIGZvciByZXZpZXcuDQoNClJl
Z2FyZHMNCg0K