2021-05-13 11:45:14

by David Howells

Subject: [PATCH] netfs: Make CONFIG_NETFS_SUPPORT auto-selected rather than manual

Make the netfs helper library selected automatically by the things that use
it rather than being manually configured, even though it's required.

Fixes: 3a5829fefd3b ("netfs: Make a netfs helper module")
Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: David Howells <[email protected]>
cc: [email protected]
cc: [email protected]
cc: [email protected]
cc: [email protected]
cc: [email protected]
cc: [email protected]
cc: [email protected]
cc: [email protected]
Link: https://lore.kernel.org/r/CAMuHMdXJZ7iNQE964CdBOU=vRKVMFzo=YF_eiwsGgqzuvZ+TuA@mail.gmail.com
---

fs/netfs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/netfs/Kconfig b/fs/netfs/Kconfig
index 578112713703..b4db21022cb4 100644
--- a/fs/netfs/Kconfig
+++ b/fs/netfs/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only

config NETFS_SUPPORT
- tristate "Support for network filesystem high-level I/O"
+ tristate
help
This option enables support for network filesystems, including
helpers for high-level buffered I/O, abstracting out read

2021-05-13 15:16:49

by Jeffrey Layton

Subject: Re: [PATCH] netfs: Make CONFIG_NETFS_SUPPORT auto-selected rather than manual

On Thu, 2021-05-13 at 11:49 +0100, David Howells wrote:
> Make the netfs helper library selected automatically by the things that use
> it rather than being manually configured, even though it's required.
>
> Fixes: 3a5829fefd3b ("netfs: Make a netfs helper module")
> Reported-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: David Howells <[email protected]>
> cc: [email protected]
> cc: [email protected]
> cc: [email protected]
> cc: [email protected]
> cc: [email protected]
> cc: [email protected]
> cc: [email protected]
> cc: [email protected]
> Link: https://lore.kernel.org/r/CAMuHMdXJZ7iNQE964CdBOU=vRKVMFzo=YF_eiwsGgqzuvZ+TuA@mail.gmail.com
> ---
>
> fs/netfs/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/netfs/Kconfig b/fs/netfs/Kconfig
> index 578112713703..b4db21022cb4 100644
> --- a/fs/netfs/Kconfig
> +++ b/fs/netfs/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> config NETFS_SUPPORT
> - tristate "Support for network filesystem high-level I/O"
> + tristate
> help
> This option enables support for network filesystems, including
> helpers for high-level buffered I/O, abstracting out read
>
>

Makes sense. No one is going to enable this w/o a fs that uses it, so
might as well make it automagic.

Reviewed-by: Jeff Layton <[email protected]>