2022-01-24 16:42:05

by NeilBrown

Subject: [PATCH 12/23] NFS: remove IS_SWAPFILE hack

This code is pointless as IS_SWAPFILE is always defined.
So remove it.

Suggested-by: Mark Hemment <[email protected]>
Signed-off-by: NeilBrown <[email protected]>
---
fs/nfs/file.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 9e2def045111..4d4750738aeb 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -44,11 +44,6 @@

static const struct vm_operations_struct nfs_file_vm_ops;

-/* Hack for future NFS swap support */
-#ifndef IS_SWAPFILE
-# define IS_SWAPFILE(inode) (0)
-#endif
-
int nfs_check_flags(int flags)
{
if ((flags & (O_APPEND | O_DIRECT)) == (O_APPEND | O_DIRECT))

2022-01-24 18:54:27

by Christoph Hellwig

Subject: Re: [PATCH 12/23] NFS: remove IS_SWAPFILE hack

On Mon, Jan 24, 2022 at 02:48:32PM +1100, NeilBrown wrote:
> This code is pointless as IS_SWAPFILE is always defined.
> So remove it.
>
> Suggested-by: Mark Hemment <[email protected]>
> Signed-off-by: NeilBrown <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>