There are lots of NFSDDBG_FACILITY defined in many files
but it isn't used anywhere. so remove it to tame the gcc warning:
fs/nfsd/nfsxdr.c:12:0: warning: macro "NFSDDBG_FACILITY" is not used
[-Wunused-macros]
fs/nfsd/filecache.c:23:0: warning: macro "NFSDDBG_FACILITY" is not used
[-Wunused-macros]
fs/nfsd/nfs3xdr.c:17:0: warning: macro "NFSDDBG_FACILITY" is not used
[-Wunused-macros]
fs/nfsd/flexfilelayoutxdr.c:11:0: warning: macro "NFSDDBG_FACILITY" is
not used [-Wunused-macros]
fs/nfsd/nfsxdr.c:12:0: warning: macro "NFSDDBG_FACILITY" is not used
[-Wunused-macros]
fs/nfsd/filecache.c:23:0: warning: macro "NFSDDBG_FACILITY" is not used
[-Wunused-macros]
fs/nfsd/nfs3xdr.c:17:0: warning: macro "NFSDDBG_FACILITY" is not used
[-Wunused-macros]
fs/nfsd/flexfilelayoutxdr.c:11:0: warning: macro "NFSDDBG_FACILITY" is
not used [-Wunused-macros]
Signed-off-by: Alex Shi <[email protected]>
Cc: "J. Bruce Fields" <[email protected]>
Cc: Chuck Lever <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
fs/nfsd/blocklayout.c | 3 ---
fs/nfsd/blocklayoutxdr.c | 3 ---
fs/nfsd/export.c | 2 --
fs/nfsd/filecache.c | 2 --
fs/nfsd/flexfilelayout.c | 2 --
fs/nfsd/flexfilelayoutxdr.c | 2 --
fs/nfsd/lockd.c | 2 --
fs/nfsd/nfs2acl.c | 2 --
fs/nfsd/nfs3proc.c | 2 --
fs/nfsd/nfs3xdr.c | 2 --
fs/nfsd/nfs4callback.c | 2 --
fs/nfsd/nfs4layouts.c | 2 --
fs/nfsd/nfs4proc.c | 2 --
fs/nfsd/nfs4recover.c | 2 --
fs/nfsd/nfs4state.c | 2 --
fs/nfsd/nfs4xdr.c | 2 --
fs/nfsd/nfsfh.c | 2 --
fs/nfsd/nfsproc.c | 2 --
fs/nfsd/nfssvc.c | 2 --
fs/nfsd/nfsxdr.c | 2 --
fs/nfsd/vfs.c | 2 --
21 files changed, 44 deletions(-)
diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c
index a07c39c94bbd..81790fabae45 100644
--- a/fs/nfsd/blocklayout.c
+++ b/fs/nfsd/blocklayout.c
@@ -17,9 +17,6 @@
#include "pnfs.h"
#include "filecache.h"
-#define NFSDDBG_FACILITY NFSDDBG_PNFS
-
-
static __be32
nfsd4_block_proc_layoutget(struct inode *inode, const struct svc_fh *fhp,
struct nfsd4_layoutget *args)
diff --git a/fs/nfsd/blocklayoutxdr.c b/fs/nfsd/blocklayoutxdr.c
index 442543304930..9a03ce88f9f2 100644
--- a/fs/nfsd/blocklayoutxdr.c
+++ b/fs/nfsd/blocklayoutxdr.c
@@ -10,9 +10,6 @@
#include "nfsd.h"
#include "blocklayoutxdr.h"
-#define NFSDDBG_FACILITY NFSDDBG_PNFS
-
-
__be32
nfsd4_block_encode_layoutget(struct xdr_stream *xdr,
struct nfsd4_layoutget *lgp)
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index 21e404e7cb68..cf8b50f16d05 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -25,8 +25,6 @@
#include "filecache.h"
#include "trace.h"
-#define NFSDDBG_FACILITY NFSDDBG_EXPORT
-
/*
* We have two caches.
* One maps client+vfsmnt+dentry to export options - the export map
diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
index 3c6c2f7d1688..8e5942648fef 100644
--- a/fs/nfsd/filecache.c
+++ b/fs/nfsd/filecache.c
@@ -20,8 +20,6 @@
#include "filecache.h"
#include "trace.h"
-#define NFSDDBG_FACILITY NFSDDBG_FH
-
/* FIXME: dynamically size this for the machine somehow? */
#define NFSD_FILE_HASH_BITS 12
#define NFSD_FILE_HASH_SIZE (1 << NFSD_FILE_HASH_BITS)
diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
index db7ef07ae50c..c764051eb22e 100644
--- a/fs/nfsd/flexfilelayout.c
+++ b/fs/nfsd/flexfilelayout.c
@@ -16,8 +16,6 @@
#include "flexfilelayoutxdr.h"
#include "pnfs.h"
-#define NFSDDBG_FACILITY NFSDDBG_PNFS
-
static __be32
nfsd4_ff_proc_layoutget(struct inode *inode, const struct svc_fh *fhp,
struct nfsd4_layoutget *args)
diff --git a/fs/nfsd/flexfilelayoutxdr.c b/fs/nfsd/flexfilelayoutxdr.c
index e81d2a5cf381..8a2e8bc05d4d 100644
--- a/fs/nfsd/flexfilelayoutxdr.c
+++ b/fs/nfsd/flexfilelayoutxdr.c
@@ -8,8 +8,6 @@
#include "nfsd.h"
#include "flexfilelayoutxdr.h"
-#define NFSDDBG_FACILITY NFSDDBG_PNFS
-
struct ff_idmap {
char buf[11];
int len;
diff --git a/fs/nfsd/lockd.c b/fs/nfsd/lockd.c
index 3f5b3d7b62b7..7684e13b3813 100644
--- a/fs/nfsd/lockd.c
+++ b/fs/nfsd/lockd.c
@@ -12,8 +12,6 @@
#include "nfsd.h"
#include "vfs.h"
-#define NFSDDBG_FACILITY NFSDDBG_LOCKD
-
#ifdef CONFIG_LOCKD_V4
#define nlm_stale_fh nlm4_stale_fh
#define nlm_failed nlm4_failed
diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
index 6a900f770dd2..09088c4b2d3d 100644
--- a/fs/nfsd/nfs2acl.c
+++ b/fs/nfsd/nfs2acl.c
@@ -13,8 +13,6 @@
#include "xdr3.h"
#include "vfs.h"
-#define NFSDDBG_FACILITY NFSDDBG_PROC
-
/*
* NULL call.
*/
diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
index a633044b0dc1..781e265921aa 100644
--- a/fs/nfsd/nfs3proc.c
+++ b/fs/nfsd/nfs3proc.c
@@ -13,8 +13,6 @@
#include "xdr3.h"
#include "vfs.h"
-#define NFSDDBG_FACILITY NFSDDBG_PROC
-
static int nfs3_ftypes[] = {
0, /* NF3NON */
S_IFREG, /* NF3REG */
diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
index 1d30c21af01a..07c8e16ac189 100644
--- a/fs/nfsd/nfs3xdr.c
+++ b/fs/nfsd/nfs3xdr.c
@@ -14,8 +14,6 @@
#include "netns.h"
#include "vfs.h"
-#define NFSDDBG_FACILITY NFSDDBG_XDR
-
/*
* Mapping of S_IF* types to NFS file types
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 052be5bf9ef5..642d6c1779da 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -42,8 +42,6 @@
#include "xdr4cb.h"
#include "xdr4.h"
-#define NFSDDBG_FACILITY NFSDDBG_PROC
-
static void nfsd4_mark_cb_fault(struct nfs4_client *, int reason);
#define NFSPROC4_CB_NULL 0
diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c
index a97873f2d22b..e77b05516707 100644
--- a/fs/nfsd/nfs4layouts.c
+++ b/fs/nfsd/nfs4layouts.c
@@ -13,8 +13,6 @@
#include "netns.h"
#include "trace.h"
-#define NFSDDBG_FACILITY NFSDDBG_PNFS
-
struct nfs4_layout {
struct list_head lo_perstate;
struct nfs4_layout_stateid *lo_state;
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index ad2fa1a8e7ad..fa6ed4ad7335 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -80,8 +80,6 @@
{ }
#endif
-#define NFSDDBG_FACILITY NFSDDBG_PROC
-
static u32 nfsd_attrmask[] = {
NFSD_WRITEABLE_ATTRS_WORD0,
NFSD_WRITEABLE_ATTRS_WORD1,
diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
index 186fa2c2c6ba..9c8738e32b74 100644
--- a/fs/nfsd/nfs4recover.c
+++ b/fs/nfsd/nfs4recover.c
@@ -49,8 +49,6 @@
#include "vfs.h"
#include "netns.h"
-#define NFSDDBG_FACILITY NFSDDBG_PROC
-
/* Declarations */
struct nfsd4_client_tracking_ops {
int (*init)(struct net *);
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index d7f27ed6b794..79286c96f480 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -53,8 +53,6 @@
#include "filecache.h"
#include "trace.h"
-#define NFSDDBG_FACILITY NFSDDBG_PROC
-
#define all_ones {{~0,~0},~0}
static const stateid_t one_stateid = {
.si_generation = ~0,
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index e3c6bea83bd6..f318c12371ab 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -59,8 +59,6 @@
#endif
-#define NFSDDBG_FACILITY NFSDDBG_XDR
-
const u32 nfsd_suppattrs[3][3] = {
{NFSD4_SUPPORTED_ATTRS_WORD0,
NFSD4_SUPPORTED_ATTRS_WORD1,
diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
index c81dbbad8792..196ab411df77 100644
--- a/fs/nfsd/nfsfh.c
+++ b/fs/nfsd/nfsfh.c
@@ -16,8 +16,6 @@
#include "auth.h"
#include "trace.h"
-#define NFSDDBG_FACILITY NFSDDBG_FH
-
/*
* our acceptability function.
diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c
index 0d71549f9d42..230da422bb43 100644
--- a/fs/nfsd/nfsproc.c
+++ b/fs/nfsd/nfsproc.c
@@ -11,8 +11,6 @@
#include "xdr.h"
#include "vfs.h"
-#define NFSDDBG_FACILITY NFSDDBG_PROC
-
static __be32
nfsd_proc_null(struct svc_rqst *rqstp)
{
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 27b1ad136150..b5c6f439086a 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -29,8 +29,6 @@
#include "netns.h"
#include "filecache.h"
-#define NFSDDBG_FACILITY NFSDDBG_SVC
-
bool inter_copy_offload_enable;
EXPORT_SYMBOL_GPL(inter_copy_offload_enable);
module_param(inter_copy_offload_enable, bool, 0644);
diff --git a/fs/nfsd/nfsxdr.c b/fs/nfsd/nfsxdr.c
index 9e00a902113e..0f797da50f78 100644
--- a/fs/nfsd/nfsxdr.c
+++ b/fs/nfsd/nfsxdr.c
@@ -9,8 +9,6 @@
#include "xdr.h"
#include "auth.h"
-#define NFSDDBG_FACILITY NFSDDBG_XDR
-
/*
* Mapping of S_IF* types to NFS file types
*/
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 1ecaceebee13..4c31b9f4a54b 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -47,8 +47,6 @@
#include "filecache.h"
#include "trace.h"
-#define NFSDDBG_FACILITY NFSDDBG_FILEOP
-
/*
* Called from nfsd_lookup and encode_dirent. Check if we have crossed
* a mount point.
--
1.8.3.1
Sorry, gcc is error on this case, it cann't find out much of
NFSDDBG_##flag
Forget this patch.
Alex
?? 2020/11/6 ????11:47, Alex Shi д??:
> There are lots of NFSDDBG_FACILITY defined in many files
> but it isn't used anywhere. so remove it to tame the gcc warning:
>
> fs/nfsd/nfsxdr.c:12:0: warning: macro "NFSDDBG_FACILITY" is not used
> [-Wunused-macros]
> fs/nfsd/filecache.c:23:0: warning: macro "NFSDDBG_FACILITY" is not used
> [-Wunused-macros]
> fs/nfsd/nfs3xdr.c:17:0: warning: macro "NFSDDBG_FACILITY" is not used
> [-Wunused-macros]
> fs/nfsd/flexfilelayoutxdr.c:11:0: warning: macro "NFSDDBG_FACILITY" is
> not used [-Wunused-macros]
> fs/nfsd/nfsxdr.c:12:0: warning: macro "NFSDDBG_FACILITY" is not used
> [-Wunused-macros]
> fs/nfsd/filecache.c:23:0: warning: macro "NFSDDBG_FACILITY" is not used
> [-Wunused-macros]
> fs/nfsd/nfs3xdr.c:17:0: warning: macro "NFSDDBG_FACILITY" is not used
> [-Wunused-macros]
> fs/nfsd/flexfilelayoutxdr.c:11:0: warning: macro "NFSDDBG_FACILITY" is
> not used [-Wunused-macros]
>
Hi Alex,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.10-rc3 next-20201110]
[cannot apply to nfsd/nfsd-next cel/for-next linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Alex-Shi/fs-nfsd-remove-unused-NFSDDBG_FACILITY-to-tame-gcc/20201106-115002
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 521b619acdc8f1f5acdac15b84f81fd9515b2aff
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/c817df999b061443f75af7b3ffe502bf289b0e03
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alex-Shi/fs-nfsd-remove-unused-NFSDDBG_FACILITY-to-tame-gcc/20201106-115002
git checkout c817df999b061443f75af7b3ffe502bf289b0e03
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
In file included from fs/nfsd/nfssvc.c:26:
fs/nfsd/nfssvc.c: In function 'nfsd_inetaddr_event':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfssvc.c:451:3: note: in expansion of macro 'dprintk'
451 | dprintk("nfsd_inetaddr_event: removed %pI4\n", &ifa->ifa_local);
| ^~~~~~~
fs/nfsd/nfsd.h:32:42: note: each undeclared identifier is reported only once for each function it appears in
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfssvc.c:451:3: note: in expansion of macro 'dprintk'
451 | dprintk("nfsd_inetaddr_event: removed %pI4\n", &ifa->ifa_local);
| ^~~~~~~
fs/nfsd/nfssvc.c: In function 'nfsd_inet6addr_event':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfssvc.c:482:3: note: in expansion of macro 'dprintk'
482 | dprintk("nfsd_inet6addr_event: removed %pI6\n", &ifa->addr);
| ^~~~~~~
fs/nfsd/nfssvc.c: In function 'set_max_drc':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfssvc.c:570:2: note: in expansion of macro 'dprintk'
570 | dprintk("%s nfsd_drc_max_mem %lu \n", __func__, nfsd_drc_max_mem);
| ^~~~~~~
fs/nfsd/nfssvc.c: In function 'nfsd_svc':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfssvc.c:746:2: note: in expansion of macro 'dprintk'
746 | dprintk("nfsd: creating service\n");
| ^~~~~~~
fs/nfsd/nfssvc.c: In function 'nfsd_dispatch':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfssvc.c:1010:2: note: in expansion of macro 'dprintk'
1010 | dprintk("nfsd_dispatch: vers %d proc %d\n",
| ^~~~~~~
--
In file included from fs/nfsd/xdr.h:8,
from fs/nfsd/nfsproc.c:11:
fs/nfsd/nfsproc.c: In function 'nfsd_proc_getattr':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:30:2: note: in expansion of macro 'dprintk'
30 | dprintk("nfsd: GETATTR %s\n", SVCFH_fmt(&argp->fh));
| ^~~~~~~
fs/nfsd/nfsd.h:32:42: note: each undeclared identifier is reported only once for each function it appears in
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:30:2: note: in expansion of macro 'dprintk'
30 | dprintk("nfsd: GETATTR %s\n", SVCFH_fmt(&argp->fh));
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_setattr':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:54:2: note: in expansion of macro 'dprintk'
54 | dprintk("nfsd: SETATTR %s, valid=%x, size=%ld\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_lookup':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:129:2: note: in expansion of macro 'dprintk'
129 | dprintk("nfsd: LOOKUP %s %.*s\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_readlink':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:153:2: note: in expansion of macro 'dprintk'
153 | dprintk("nfsd: READLINK %s\n", SVCFH_fmt(&argp->fh));
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_read':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:174:2: note: in expansion of macro 'dprintk'
174 | dprintk("nfsd: READ %s %d bytes at %d\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_write':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:224:2: note: in expansion of macro 'dprintk'
224 | dprintk("nfsd: WRITE %s %d bytes at %d\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_create':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:266:2: note: in expansion of macro 'dprintk'
266 | dprintk("nfsd: CREATE %s %.*s\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_remove':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:419:2: note: in expansion of macro 'dprintk'
419 | dprintk("nfsd: REMOVE %s %.*s\n", SVCFH_fmt(&argp->fh),
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_rename':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:435:2: note: in expansion of macro 'dprintk'
435 | dprintk("nfsd: RENAME %s %.*s -> \n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_link':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:453:2: note: in expansion of macro 'dprintk'
453 | dprintk("nfsd: LINK %s ->\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_symlink':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:487:2: note: in expansion of macro 'dprintk'
487 | dprintk("nfsd: SYMLINK %s %.*s -> %.*s\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_mkdir':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:512:2: note: in expansion of macro 'dprintk'
512 | dprintk("nfsd: MKDIR %s %.*s\n", SVCFH_fmt(&argp->fh), argp->len, argp->name);
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_rmdir':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:541:2: note: in expansion of macro 'dprintk'
541 | dprintk("nfsd: RMDIR %s %.*s\n", SVCFH_fmt(&argp->fh), argp->len, argp->name);
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_readdir':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:560:2: note: in expansion of macro 'dprintk'
560 | dprintk("nfsd: READDIR %s %d bytes at %d\n",
| ^~~~~~~
fs/nfsd/nfsproc.c: In function 'nfsd_proc_statfs':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsproc.c:598:2: note: in expansion of macro 'dprintk'
598 | dprintk("nfsd: STATFS %s\n", SVCFH_fmt(&argp->fh));
| ^~~~~~~
--
In file included from fs/nfsd/nfsfh.c:14:
fs/nfsd/nfsfh.c: In function 'nfsd_acceptable':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsfh.c:50:3: note: in expansion of macro 'dprintk'
50 | dprintk("nfsd_acceptable failed at %p %pd\n", tdentry, tdentry);
| ^~~~~~~
fs/nfsd/nfsd.h:32:42: note: each undeclared identifier is reported only once for each function it appears in
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsfh.c:50:3: note: in expansion of macro 'dprintk'
50 | dprintk("nfsd_acceptable failed at %p %pd\n", tdentry, tdentry);
| ^~~~~~~
fs/nfsd/nfsfh.c: In function 'nfsd_setuser_and_check_port':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsfh.c:107:3: note: in expansion of macro 'dprintk'
107 | dprintk("nfsd: request from insecure port %s!\n",
| ^~~~~~~
fs/nfsd/nfsfh.c: In function 'fh_verify':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsfh.c:332:2: note: in expansion of macro 'dprintk'
332 | dprintk("nfsd: fh_verify(%s)\n", SVCFH_fmt(fhp));
| ^~~~~~~
fs/nfsd/nfsfh.c: In function 'fh_compose':
>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
| ^~~~~~~~
include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
39 | ifdebug(fac) \
| ^~~~~~~
include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
| ^~~~~~~~
fs/nfsd/nfsfh.c:548:2: note: in expansion of macro 'dprintk'
548 | dprintk("nfsd: fh_compose(exp %02x:%02x/%ld %pd2, ino=%ld)\n",
| ^~~~~~~
..
vim +32 fs/nfsd/nfsd.h
d430e8d530e900c Christoph Hellwig 2014-05-06 29
6f226e2ab1b895c Christoph Hellwig 2014-05-06 30 #undef ifdebug
135dd002c23054a Mark Salter 2015-04-06 31 #ifdef CONFIG_SUNRPC_DEBUG
6f226e2ab1b895c Christoph Hellwig 2014-05-06 @32 # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
6f226e2ab1b895c Christoph Hellwig 2014-05-06 33 #else
6f226e2ab1b895c Christoph Hellwig 2014-05-06 34 # define ifdebug(flag) if (0)
6f226e2ab1b895c Christoph Hellwig 2014-05-06 35 #endif
6f226e2ab1b895c Christoph Hellwig 2014-05-06 36
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
I had a recall email for this patch https://www.spinics.net/lists/linux-nfs/msg80135.html
seem your robot just omit it. :)
Thanks
在 2020/11/11 上午4:55, kernel test robot 写道:
> Hi Alex,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v5.10-rc3 next-20201110]
> [cannot apply to nfsd/nfsd-next cel/for-next linux/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Alex-Shi/fs-nfsd-remove-unused-NFSDDBG_FACILITY-to-tame-gcc/20201106-115002
> base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 521b619acdc8f1f5acdac15b84f81fd9515b2aff
> config: x86_64-rhel (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> reproduce (this is a W=1 build):
> # https://github.com/0day-ci/linux/commit/c817df999b061443f75af7b3ffe502bf289b0e03
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Alex-Shi/fs-nfsd-remove-unused-NFSDDBG_FACILITY-to-tame-gcc/20201106-115002
> git checkout c817df999b061443f75af7b3ffe502bf289b0e03
> # save the attached .config to linux build tree
> make W=1 ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> In file included from fs/nfsd/nfssvc.c:26:
> fs/nfsd/nfssvc.c: In function 'nfsd_inetaddr_event':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfssvc.c:451:3: note: in expansion of macro 'dprintk'
> 451 | dprintk("nfsd_inetaddr_event: removed %pI4\n", &ifa->ifa_local);
> | ^~~~~~~
> fs/nfsd/nfsd.h:32:42: note: each undeclared identifier is reported only once for each function it appears in
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfssvc.c:451:3: note: in expansion of macro 'dprintk'
> 451 | dprintk("nfsd_inetaddr_event: removed %pI4\n", &ifa->ifa_local);
> | ^~~~~~~
> fs/nfsd/nfssvc.c: In function 'nfsd_inet6addr_event':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfssvc.c:482:3: note: in expansion of macro 'dprintk'
> 482 | dprintk("nfsd_inet6addr_event: removed %pI6\n", &ifa->addr);
> | ^~~~~~~
> fs/nfsd/nfssvc.c: In function 'set_max_drc':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfssvc.c:570:2: note: in expansion of macro 'dprintk'
> 570 | dprintk("%s nfsd_drc_max_mem %lu \n", __func__, nfsd_drc_max_mem);
> | ^~~~~~~
> fs/nfsd/nfssvc.c: In function 'nfsd_svc':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfssvc.c:746:2: note: in expansion of macro 'dprintk'
> 746 | dprintk("nfsd: creating service\n");
> | ^~~~~~~
> fs/nfsd/nfssvc.c: In function 'nfsd_dispatch':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfssvc.c:1010:2: note: in expansion of macro 'dprintk'
> 1010 | dprintk("nfsd_dispatch: vers %d proc %d\n",
> | ^~~~~~~
> --
> In file included from fs/nfsd/xdr.h:8,
> from fs/nfsd/nfsproc.c:11:
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_getattr':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:30:2: note: in expansion of macro 'dprintk'
> 30 | dprintk("nfsd: GETATTR %s\n", SVCFH_fmt(&argp->fh));
> | ^~~~~~~
> fs/nfsd/nfsd.h:32:42: note: each undeclared identifier is reported only once for each function it appears in
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:30:2: note: in expansion of macro 'dprintk'
> 30 | dprintk("nfsd: GETATTR %s\n", SVCFH_fmt(&argp->fh));
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_setattr':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:54:2: note: in expansion of macro 'dprintk'
> 54 | dprintk("nfsd: SETATTR %s, valid=%x, size=%ld\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_lookup':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:129:2: note: in expansion of macro 'dprintk'
> 129 | dprintk("nfsd: LOOKUP %s %.*s\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_readlink':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:153:2: note: in expansion of macro 'dprintk'
> 153 | dprintk("nfsd: READLINK %s\n", SVCFH_fmt(&argp->fh));
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_read':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:174:2: note: in expansion of macro 'dprintk'
> 174 | dprintk("nfsd: READ %s %d bytes at %d\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_write':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:224:2: note: in expansion of macro 'dprintk'
> 224 | dprintk("nfsd: WRITE %s %d bytes at %d\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_create':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:266:2: note: in expansion of macro 'dprintk'
> 266 | dprintk("nfsd: CREATE %s %.*s\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_remove':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:419:2: note: in expansion of macro 'dprintk'
> 419 | dprintk("nfsd: REMOVE %s %.*s\n", SVCFH_fmt(&argp->fh),
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_rename':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:435:2: note: in expansion of macro 'dprintk'
> 435 | dprintk("nfsd: RENAME %s %.*s -> \n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_link':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:453:2: note: in expansion of macro 'dprintk'
> 453 | dprintk("nfsd: LINK %s ->\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_symlink':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:487:2: note: in expansion of macro 'dprintk'
> 487 | dprintk("nfsd: SYMLINK %s %.*s -> %.*s\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_mkdir':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:512:2: note: in expansion of macro 'dprintk'
> 512 | dprintk("nfsd: MKDIR %s %.*s\n", SVCFH_fmt(&argp->fh), argp->len, argp->name);
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_rmdir':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:541:2: note: in expansion of macro 'dprintk'
> 541 | dprintk("nfsd: RMDIR %s %.*s\n", SVCFH_fmt(&argp->fh), argp->len, argp->name);
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_readdir':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:560:2: note: in expansion of macro 'dprintk'
> 560 | dprintk("nfsd: READDIR %s %d bytes at %d\n",
> | ^~~~~~~
> fs/nfsd/nfsproc.c: In function 'nfsd_proc_statfs':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsproc.c:598:2: note: in expansion of macro 'dprintk'
> 598 | dprintk("nfsd: STATFS %s\n", SVCFH_fmt(&argp->fh));
> | ^~~~~~~
> --
> In file included from fs/nfsd/nfsfh.c:14:
> fs/nfsd/nfsfh.c: In function 'nfsd_acceptable':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsfh.c:50:3: note: in expansion of macro 'dprintk'
> 50 | dprintk("nfsd_acceptable failed at %p %pd\n", tdentry, tdentry);
> | ^~~~~~~
> fs/nfsd/nfsd.h:32:42: note: each undeclared identifier is reported only once for each function it appears in
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsfh.c:50:3: note: in expansion of macro 'dprintk'
> 50 | dprintk("nfsd_acceptable failed at %p %pd\n", tdentry, tdentry);
> | ^~~~~~~
> fs/nfsd/nfsfh.c: In function 'nfsd_setuser_and_check_port':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsfh.c:107:3: note: in expansion of macro 'dprintk'
> 107 | dprintk("nfsd: request from insecure port %s!\n",
> | ^~~~~~~
> fs/nfsd/nfsfh.c: In function 'fh_verify':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsfh.c:332:2: note: in expansion of macro 'dprintk'
> 332 | dprintk("nfsd: fh_verify(%s)\n", SVCFH_fmt(fhp));
> | ^~~~~~~
> fs/nfsd/nfsfh.c: In function 'fh_compose':
>>> fs/nfsd/nfsd.h:32:42: error: 'NFSDDBG_FACILITY' undeclared (first use in this function); did you mean 'NFSDDBG_FILEOP'?
> 32 | # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> | ^~~~~~~~
> include/linux/sunrpc/debug.h:39:2: note: in expansion of macro 'ifdebug'
> 39 | ifdebug(fac) \
> | ^~~~~~~
> include/linux/sunrpc/debug.h:25:2: note: in expansion of macro 'dfprintk'
> 25 | dfprintk(FACILITY, fmt, ##__VA_ARGS__)
> | ^~~~~~~~
> fs/nfsd/nfsfh.c:548:2: note: in expansion of macro 'dprintk'
> 548 | dprintk("nfsd: fh_compose(exp %02x:%02x/%ld %pd2, ino=%ld)\n",
> | ^~~~~~~
> ..
>
> vim +32 fs/nfsd/nfsd.h
>
> d430e8d530e900c Christoph Hellwig 2014-05-06 29
> 6f226e2ab1b895c Christoph Hellwig 2014-05-06 30 #undef ifdebug
> 135dd002c23054a Mark Salter 2015-04-06 31 #ifdef CONFIG_SUNRPC_DEBUG
> 6f226e2ab1b895c Christoph Hellwig 2014-05-06 @32 # define ifdebug(flag) if (nfsd_debug & NFSDDBG_##flag)
> 6f226e2ab1b895c Christoph Hellwig 2014-05-06 33 #else
> 6f226e2ab1b895c Christoph Hellwig 2014-05-06 34 # define ifdebug(flag) if (0)
> 6f226e2ab1b895c Christoph Hellwig 2014-05-06 35 #endif
> 6f226e2ab1b895c Christoph Hellwig 2014-05-06 36
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/[email protected]
>