Hello,
I'm seeing a problem with quotas in a system where the server running
2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
version does not seem to play a role, checked with 2.6.38, 2.6.37 and
2.6.36. The following script and output show the problem:
#! /bin/sh
quota | grep home
du
cp /bin/ls x1
du
cat x1 > /dev/null
rm x1
du
quota | grep home
Output:
homes:/home/ 8194720 9072000 9174400 403670 500000 550000
0 .
96 .
0 .
homes:/home/ 8194816 9072000 9174400 403671 500000 550000
As can be seen the 96 kb are still accounted on the quota of the user.
Removing the 'cat' command from the script makes the quota be ok again
(original value). Also mounting via nfs3 does not exhibit it, same for running
the script on the nfs-server directly.
Client mount options are:
homes:/home/ /home nfs4 rw,nosuid,nodev,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=1.2.3.3,minorversion=0,local_lock=none,addr=1.2.3.4 0 0
Server mount options are:
/dev/mapper/vg-homefs /home xfs rw,nosuid,nodev,relatime,attr2,usrquota 0 0
Thanks,
Adam
--
Adam [email protected]
Lackorzynski http://os.inf.tu-dresden.de/~adam/
On Thu, Mar 17, 2011 at 02:32:47PM +0100, Adam Lackorzynski wrote:
> Hello,
>
> I'm seeing a problem with quotas in a system where the server running
> 2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
> version does not seem to play a role, checked with 2.6.38, 2.6.37 and
> 2.6.36. The following script and output show the problem:
>
> #! /bin/sh
>
> quota | grep home
> du
> cp /bin/ls x1
> du
> cat x1 > /dev/null
> rm x1
> du
> quota | grep home
>
> Output:
>
> homes:/home/ 8194720 9072000 9174400 403670 500000 550000
> 0 .
> 96 .
> 0 .
> homes:/home/ 8194816 9072000 9174400 403671 500000 550000
>
>
> As can be seen the 96 kb are still accounted on the quota of the user.
> Removing the 'cat' command from the script makes the quota be ok again
> (original value). Also mounting via nfs3 does not exhibit it, same for running
> the script on the nfs-server directly.
Does "df" show the same problem? And does unmounting/remounting on the
client clear the problem? (Or that, in combination with stopping the
server, unmounting the xfs export, remounting it, and restarting?)
Was there an earlier server version that didn't exhibit this problem?
--b.
>
> Client mount options are:
> homes:/home/ /home nfs4 rw,nosuid,nodev,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=1.2.3.3,minorversion=0,local_lock=none,addr=1.2.3.4 0 0
>
> Server mount options are:
> /dev/mapper/vg-homefs /home xfs rw,nosuid,nodev,relatime,attr2,usrquota 0 0
>
>
>
>
> Thanks,
> Adam
> --
> Adam [email protected]
> Lackorzynski http://os.inf.tu-dresden.de/~adam/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On czwartek, 17 marca 2011 o 14:32:47 Adam Lackorzynski wrote:
> Hello,
>
> I'm seeing a problem with quotas in a system where the server running
> 2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
> version does not seem to play a role, checked with 2.6.38, 2.6.37 and
> 2.6.36. The following script and output show the problem:
>
> #! /bin/sh
>
> quota | grep home
> du
> cp /bin/ls x1
> du
> cat x1 > /dev/null
> rm x1
> du
> quota | grep home
>
> Output:
>
> homes:/home/ 8194720 9072000 9174400 403670 500000 550000
> 0 .
> 96 .
> 0 .
> homes:/home/ 8194816 9072000 9174400 403671 500000 550000
>
>
> As can be seen the 96 kb are still accounted on the quota of the user.
> Removing the 'cat' command from the script makes the quota be ok again
> (original value). Also mounting via nfs3 does not exhibit it, same for
> running the script on the nfs-server directly.
>
> Client mount options are:
> homes:/home/ /home nfs4
> rw,nosuid,nodev,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,har
> d,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=1.2.3.3,minorvers
> ion=0,local_lock=none,addr=1.2.3.4 0 0
>
> Server mount options are:
> /dev/mapper/vg-homefs /home xfs rw,nosuid,nodev,relatime,attr2,usrquota 0 0
>
>
I created a Bugzilla entry at
https://bugzilla.kernel.org/show_bug.cgi?id=31532
for your bug report, please add your address to the CC list in there, thanks!
--
Maciej Rutecki
http://www.maciek.unixy.pl
On Thu Mar 17, 2011 at 18:27:32 -0400, J. Bruce Fields wrote:
> On Thu, Mar 17, 2011 at 10:33:03PM +0100, Adam Lackorzynski wrote:
> >
> > On Thu Mar 17, 2011 at 13:38:05 -0400, J. Bruce Fields wrote:
> > > On Thu, Mar 17, 2011 at 02:32:47PM +0100, Adam Lackorzynski wrote:
> > > > Hello,
> > > >
> > > > I'm seeing a problem with quotas in a system where the server running
> > > > 2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
> > > > version does not seem to play a role, checked with 2.6.38, 2.6.37 and
> > > > 2.6.36. The following script and output show the problem:
> > > >
> > > > #! /bin/sh
> > > >
> > > > quota | grep home
> > > > du
> > > > cp /bin/ls x1
> > > > du
> > > > cat x1 > /dev/null
> > > > rm x1
> > > > du
> > > > quota | grep home
> > > >
> > > > Output:
> > > >
> > > > homes:/home/ 8194720 9072000 9174400 403670 500000 550000
> > > > 0 .
> > > > 96 .
> > > > 0 .
> > > > homes:/home/ 8194816 9072000 9174400 403671 500000 550000
> > > >
> > > >
> > > > As can be seen the 96 kb are still accounted on the quota of the user.
> > > > Removing the 'cat' command from the script makes the quota be ok again
> > > > (original value). Also mounting via nfs3 does not exhibit it, same for running
> > > > the script on the nfs-server directly.
> > >
> > > Does "df" show the same problem?
> >
> > With '/bin/ls' it does not change at all, so I took a bigger binary
> > which yields to:
> >
> > homes:/home/ 8203780 9072000 9174400 403688 500000 550000
> > 0 .
> > Filesystem 1K-blocks Used Available Use% Mounted on
> > homes:/home 513671168 335251456 178419712 66% /tmp/xx
> > 4592 .
> > Filesystem 1K-blocks Used Available Use% Mounted on
> > homes:/home 513671168 335256576 178414592 66% /tmp/xx
> > 0 .
> > Filesystem 1K-blocks Used Available Use% Mounted on
> > homes:/home 513671168 335256576 178414592 66% /tmp/xx
> > homes:/home/ 8208372 9072000 9174400 403689 500000 550000
> >
> > So yes, it seems to be there as well.
>
> It might be easier to see with "df -i" (assuming we're leaking an
> inode).
Result is as expected, inode goes one up and not down again.
> > > And does unmounting/remounting on the
> > > client clear the problem?
> >
> > No.
> >
> > > (Or that, in combination with stopping the
> > > server, unmounting the xfs export, remounting it, and restarting?)
> >
> > I rebooted once, got a recovery and then the quotas were ok again (and
> > supposedly the used blocks as well). I assume a unmount/mount would show
> > the same behaviour but requires a bit of preparation to try out.
> >
> > > Was there an earlier server version that didn't exhibit this problem?
> >
> > Had 2.6.37 on the server before and that was fine regarding this.
>
> OK, thanks. Sounds like a server bug, but I'm not managing to reproduce
> it here yet....
Adam
--
Adam [email protected]
Lackorzynski http://os.inf.tu-dresden.de/~adam/
On Thu Mar 24, 2011 at 13:51:06 -0400, J. Bruce Fields wrote:
> On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote:
> > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote:
> > > I probably mistyped something and thus bisected again:
> >
> > maybe this is just a symptom. When was the nfs4 code converted
> > to just use a single open struct file, and what are the lifetime
> > rules for it? It would easily be that a long alive file might
> > make XFS keep persistent preallocations longer or similar issues.
>
> Definitely, the commit he's bisect to there seems much more likely to be
> a culprit. I'll take a closer look....
>
> > Adam, can you create a loop filesystem with ext3 or something else
> > on it and see if the problem is XFS-specific?
>
> Originally it sounded like he was able to reproduce this only on one
> specific filesystem so I wondered whether there was something particular
> to that filesystem.
I just found out it happens also with a newly created xfs and also with
ext3 and ext4. The reason that I did not see that initially is that the
script I'm using needs to be on the same fs which wasn't the case when I
initially tried it with a new fs. The sequence I'm using is:
# mount x.x.x:/home /tmp/st
# su - foo
$ cd /tmp/st/foo/x
$ ../test-script
foo@host:/tmp/st/foo/x$ ../test-script
Filesystem Inodes IUsed IFree IUse% Mounted on
x.x.x:/home 39321600 15 39321585 1% /tmp/st
Filesystem Inodes IUsed IFree IUse% Mounted on
x.x.x:/home 39321600 16 39321584 1% /tmp/st
Filesystem Inodes IUsed IFree IUse% Mounted on
x.x.x:/home 39321600 16 39321584 1% /tmp/st
test-script:
#! /bin/sh
df -i .
cp /bin/ls x1
df -i .
cat x1 > /dev/null
rm x1
df -i .
Adam
--
Adam [email protected]
Lackorzynski http://os.inf.tu-dresden.de/~adam/
On Thu, Mar 24, 2011 at 11:28:07PM +0100, Adam Lackorzynski wrote:
>
> On Thu Mar 24, 2011 at 13:51:06 -0400, J. Bruce Fields wrote:
> > On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote:
> > > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote:
> > > > I probably mistyped something and thus bisected again:
> > >
> > > maybe this is just a symptom. When was the nfs4 code converted
> > > to just use a single open struct file, and what are the lifetime
> > > rules for it? It would easily be that a long alive file might
> > > make XFS keep persistent preallocations longer or similar issues.
> >
> > Definitely, the commit he's bisect to there seems much more likely to be
> > a culprit. I'll take a closer look....
> >
> > > Adam, can you create a loop filesystem with ext3 or something else
> > > on it and see if the problem is XFS-specific?
> >
> > Originally it sounded like he was able to reproduce this only on one
> > specific filesystem so I wondered whether there was something particular
> > to that filesystem.
>
> I just found out it happens also with a newly created xfs and also with
> ext3 and ext4. The reason that I did not see that initially is that the
> script I'm using needs to be on the same fs which wasn't the case when I
> initially tried it with a new fs. The sequence I'm using is:
Ah-hah, got it. So the leak's probably of a delegation on the file
containing the script itself. OK, I should be able to fix that, thanks!
--b.
>
> # mount x.x.x:/home /tmp/st
> # su - foo
> $ cd /tmp/st/foo/x
> $ ../test-script
> foo@host:/tmp/st/foo/x$ ../test-script
> Filesystem Inodes IUsed IFree IUse% Mounted on
> x.x.x:/home 39321600 15 39321585 1% /tmp/st
> Filesystem Inodes IUsed IFree IUse% Mounted on
> x.x.x:/home 39321600 16 39321584 1% /tmp/st
> Filesystem Inodes IUsed IFree IUse% Mounted on
> x.x.x:/home 39321600 16 39321584 1% /tmp/st
>
>
>
> test-script:
> #! /bin/sh
>
> df -i .
> cp /bin/ls x1
> df -i .
> cat x1 > /dev/null
> rm x1
> df -i .
>
>
>
>
>
>
> Adam
> --
> Adam [email protected]
> Lackorzynski http://os.inf.tu-dresden.de/~adam/
On Thu Mar 17, 2011 at 13:38:05 -0400, J. Bruce Fields wrote:
> On Thu, Mar 17, 2011 at 02:32:47PM +0100, Adam Lackorzynski wrote:
> > Hello,
> >
> > I'm seeing a problem with quotas in a system where the server running
> > 2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
> > version does not seem to play a role, checked with 2.6.38, 2.6.37 and
> > 2.6.36. The following script and output show the problem:
> >
> > #! /bin/sh
> >
> > quota | grep home
> > du
> > cp /bin/ls x1
> > du
> > cat x1 > /dev/null
> > rm x1
> > du
> > quota | grep home
> >
> > Output:
> >
> > homes:/home/ 8194720 9072000 9174400 403670 500000 550000
> > 0 .
> > 96 .
> > 0 .
> > homes:/home/ 8194816 9072000 9174400 403671 500000 550000
> >
> >
> > As can be seen the 96 kb are still accounted on the quota of the user.
> > Removing the 'cat' command from the script makes the quota be ok again
> > (original value). Also mounting via nfs3 does not exhibit it, same for running
> > the script on the nfs-server directly.
>
> Does "df" show the same problem?
With '/bin/ls' it does not change at all, so I took a bigger binary
which yields to:
homes:/home/ 8203780 9072000 9174400 403688 500000 550000
0 .
Filesystem 1K-blocks Used Available Use% Mounted on
homes:/home 513671168 335251456 178419712 66% /tmp/xx
4592 .
Filesystem 1K-blocks Used Available Use% Mounted on
homes:/home 513671168 335256576 178414592 66% /tmp/xx
0 .
Filesystem 1K-blocks Used Available Use% Mounted on
homes:/home 513671168 335256576 178414592 66% /tmp/xx
homes:/home/ 8208372 9072000 9174400 403689 500000 550000
So yes, it seems to be there as well.
> And does unmounting/remounting on the
> client clear the problem?
No.
> (Or that, in combination with stopping the
> server, unmounting the xfs export, remounting it, and restarting?)
I rebooted once, got a recovery and then the quotas were ok again (and
supposedly the used blocks as well). I assume a unmount/mount would show
the same behaviour but requires a bit of preparation to try out.
> Was there an earlier server version that didn't exhibit this problem?
Had 2.6.37 on the server before and that was fine regarding this.
> > Client mount options are:
> > homes:/home/ /home nfs4 rw,nosuid,nodev,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=1.2.3.3,minorversion=0,local_lock=none,addr=1.2.3.4 0 0
> >
> > Server mount options are:
> > /dev/mapper/vg-homefs /home xfs rw,nosuid,nodev,relatime,attr2,usrquota 0 0
Adam
--
Adam [email protected]
Lackorzynski http://os.inf.tu-dresden.de/~adam/
On Thu Mar 17, 2011 at 19:03:15 -0400, J. Bruce Fields wrote:
> On Thu, Mar 17, 2011 at 11:59:08PM +0100, Adam Lackorzynski wrote:
> >
> > On Thu Mar 17, 2011 at 18:27:32 -0400, J. Bruce Fields wrote:
> > > On Thu, Mar 17, 2011 at 10:33:03PM +0100, Adam Lackorzynski wrote:
> > > >
> > > > On Thu Mar 17, 2011 at 13:38:05 -0400, J. Bruce Fields wrote:
> > > > > On Thu, Mar 17, 2011 at 02:32:47PM +0100, Adam Lackorzynski wrote:
> > > > > > Hello,
> > > > > >
> > > > > > I'm seeing a problem with quotas in a system where the server running
> > > > > > 2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
> > > > > > version does not seem to play a role, checked with 2.6.38, 2.6.37 and
> > > > > > 2.6.36. The following script and output show the problem:
> > > > > >
> > > > > > #! /bin/sh
> > > > > >
> > > > > > quota | grep home
> > > > > > du
> > > > > > cp /bin/ls x1
> > > > > > du
> > > > > > cat x1 > /dev/null
> > > > > > rm x1
> > > > > > du
> > > > > > quota | grep home
> > > > > >
> > > > > > Output:
> > > > > >
> > > > > > homes:/home/ 8194720 9072000 9174400 403670 500000 550000
> > > > > > 0 .
> > > > > > 96 .
> > > > > > 0 .
> > > > > > homes:/home/ 8194816 9072000 9174400 403671 500000 550000
> > > > > >
> > > > > >
> > > > > > As can be seen the 96 kb are still accounted on the quota of the user.
> > > > > > Removing the 'cat' command from the script makes the quota be ok again
> > > > > > (original value). Also mounting via nfs3 does not exhibit it, same for running
> > > > > > the script on the nfs-server directly.
> > > > >
> > > > > Does "df" show the same problem?
> > > >
> > > > With '/bin/ls' it does not change at all, so I took a bigger binary
> > > > which yields to:
> > > >
> > > > homes:/home/ 8203780 9072000 9174400 403688 500000 550000
> > > > 0 .
> > > > Filesystem 1K-blocks Used Available Use% Mounted on
> > > > homes:/home 513671168 335251456 178419712 66% /tmp/xx
> > > > 4592 .
> > > > Filesystem 1K-blocks Used Available Use% Mounted on
> > > > homes:/home 513671168 335256576 178414592 66% /tmp/xx
> > > > 0 .
> > > > Filesystem 1K-blocks Used Available Use% Mounted on
> > > > homes:/home 513671168 335256576 178414592 66% /tmp/xx
> > > > homes:/home/ 8208372 9072000 9174400 403689 500000 550000
> > > >
> > > > So yes, it seems to be there as well.
> > >
> > > It might be easier to see with "df -i" (assuming we're leaking an
> > > inode).
> >
> > Result is as expected, inode goes one up and not down again.
>
> Is this something special about binaries? If you copy something other
> than a binary, do you not see the bug?
No change when using a plain text file instead of a binary.
Adam
--
Adam [email protected]
Lackorzynski http://os.inf.tu-dresden.de/~adam/
On Thu, Mar 17, 2011 at 10:33:03PM +0100, Adam Lackorzynski wrote:
>
> On Thu Mar 17, 2011 at 13:38:05 -0400, J. Bruce Fields wrote:
> > On Thu, Mar 17, 2011 at 02:32:47PM +0100, Adam Lackorzynski wrote:
> > > Hello,
> > >
> > > I'm seeing a problem with quotas in a system where the server running
> > > 2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
> > > version does not seem to play a role, checked with 2.6.38, 2.6.37 and
> > > 2.6.36. The following script and output show the problem:
> > >
> > > #! /bin/sh
> > >
> > > quota | grep home
> > > du
> > > cp /bin/ls x1
> > > du
> > > cat x1 > /dev/null
> > > rm x1
> > > du
> > > quota | grep home
> > >
> > > Output:
> > >
> > > homes:/home/ 8194720 9072000 9174400 403670 500000 550000
> > > 0 .
> > > 96 .
> > > 0 .
> > > homes:/home/ 8194816 9072000 9174400 403671 500000 550000
> > >
> > >
> > > As can be seen the 96 kb are still accounted on the quota of the user.
> > > Removing the 'cat' command from the script makes the quota be ok again
> > > (original value). Also mounting via nfs3 does not exhibit it, same for running
> > > the script on the nfs-server directly.
> >
> > Does "df" show the same problem?
>
> With '/bin/ls' it does not change at all, so I took a bigger binary
> which yields to:
>
> homes:/home/ 8203780 9072000 9174400 403688 500000 550000
> 0 .
> Filesystem 1K-blocks Used Available Use% Mounted on
> homes:/home 513671168 335251456 178419712 66% /tmp/xx
> 4592 .
> Filesystem 1K-blocks Used Available Use% Mounted on
> homes:/home 513671168 335256576 178414592 66% /tmp/xx
> 0 .
> Filesystem 1K-blocks Used Available Use% Mounted on
> homes:/home 513671168 335256576 178414592 66% /tmp/xx
> homes:/home/ 8208372 9072000 9174400 403689 500000 550000
>
> So yes, it seems to be there as well.
It might be easier to see with "df -i" (assuming we're leaking an
inode).
> > And does unmounting/remounting on the
> > client clear the problem?
>
> No.
>
> > (Or that, in combination with stopping the
> > server, unmounting the xfs export, remounting it, and restarting?)
>
> I rebooted once, got a recovery and then the quotas were ok again (and
> supposedly the used blocks as well). I assume a unmount/mount would show
> the same behaviour but requires a bit of preparation to try out.
>
> > Was there an earlier server version that didn't exhibit this problem?
>
> Had 2.6.37 on the server before and that was fine regarding this.
OK, thanks. Sounds like a server bug, but I'm not managing to reproduce
it here yet....
--b.
On Thu, Mar 17, 2011 at 11:59:08PM +0100, Adam Lackorzynski wrote:
>
> On Thu Mar 17, 2011 at 18:27:32 -0400, J. Bruce Fields wrote:
> > On Thu, Mar 17, 2011 at 10:33:03PM +0100, Adam Lackorzynski wrote:
> > >
> > > On Thu Mar 17, 2011 at 13:38:05 -0400, J. Bruce Fields wrote:
> > > > On Thu, Mar 17, 2011 at 02:32:47PM +0100, Adam Lackorzynski wrote:
> > > > > Hello,
> > > > >
> > > > > I'm seeing a problem with quotas in a system where the server running
> > > > > 2.6.38 exports an XFS filesystem via NFS4 to a client. The client kernel
> > > > > version does not seem to play a role, checked with 2.6.38, 2.6.37 and
> > > > > 2.6.36. The following script and output show the problem:
> > > > >
> > > > > #! /bin/sh
> > > > >
> > > > > quota | grep home
> > > > > du
> > > > > cp /bin/ls x1
> > > > > du
> > > > > cat x1 > /dev/null
> > > > > rm x1
> > > > > du
> > > > > quota | grep home
> > > > >
> > > > > Output:
> > > > >
> > > > > homes:/home/ 8194720 9072000 9174400 403670 500000 550000
> > > > > 0 .
> > > > > 96 .
> > > > > 0 .
> > > > > homes:/home/ 8194816 9072000 9174400 403671 500000 550000
> > > > >
> > > > >
> > > > > As can be seen the 96 kb are still accounted on the quota of the user.
> > > > > Removing the 'cat' command from the script makes the quota be ok again
> > > > > (original value). Also mounting via nfs3 does not exhibit it, same for running
> > > > > the script on the nfs-server directly.
> > > >
> > > > Does "df" show the same problem?
> > >
> > > With '/bin/ls' it does not change at all, so I took a bigger binary
> > > which yields to:
> > >
> > > homes:/home/ 8203780 9072000 9174400 403688 500000 550000
> > > 0 .
> > > Filesystem 1K-blocks Used Available Use% Mounted on
> > > homes:/home 513671168 335251456 178419712 66% /tmp/xx
> > > 4592 .
> > > Filesystem 1K-blocks Used Available Use% Mounted on
> > > homes:/home 513671168 335256576 178414592 66% /tmp/xx
> > > 0 .
> > > Filesystem 1K-blocks Used Available Use% Mounted on
> > > homes:/home 513671168 335256576 178414592 66% /tmp/xx
> > > homes:/home/ 8208372 9072000 9174400 403689 500000 550000
> > >
> > > So yes, it seems to be there as well.
> >
> > It might be easier to see with "df -i" (assuming we're leaking an
> > inode).
>
> Result is as expected, inode goes one up and not down again.
Is this something special about binaries? If you copy something other
than a binary, do you not see the bug?
--b.
On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote:
> On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote:
> > I probably mistyped something and thus bisected again:
>
> maybe this is just a symptom. When was the nfs4 code converted
> to just use a single open struct file, and what are the lifetime
> rules for it? It would easily be that a long alive file might
> make XFS keep persistent preallocations longer or similar issues.
Definitely, the commit he's bisect to there seems much more likely to be
a culprit. I'll take a closer look....
> Adam, can you create a loop filesystem with ext3 or something else
> on it and see if the problem is XFS-specific?
Originally it sounded like he was able to reproduce this only on one
specific filesystem so I wondered whether there was something particular
to that filesystem.
--b.
On Thu, Mar 24, 2011 at 08:03:10PM -0400, J. Bruce Fields wrote:
> On Thu, Mar 24, 2011 at 11:28:07PM +0100, Adam Lackorzynski wrote:
> >
> > On Thu Mar 24, 2011 at 13:51:06 -0400, J. Bruce Fields wrote:
> > > On Thu, Mar 24, 2011 at 01:17:05PM -0400, Christoph Hellwig wrote:
> > > > On Wed, Mar 23, 2011 at 11:30:17PM +0100, Adam Lackorzynski wrote:
> > > > > I probably mistyped something and thus bisected again:
> > > >
> > > > maybe this is just a symptom. When was the nfs4 code converted
> > > > to just use a single open struct file, and what are the lifetime
> > > > rules for it? It would easily be that a long alive file might
> > > > make XFS keep persistent preallocations longer or similar issues.
> > >
> > > Definitely, the commit he's bisect to there seems much more likely to be
> > > a culprit. I'll take a closer look....
> > >
> > > > Adam, can you create a loop filesystem with ext3 or something else
> > > > on it and see if the problem is XFS-specific?
> > >
> > > Originally it sounded like he was able to reproduce this only on one
> > > specific filesystem so I wondered whether there was something particular
> > > to that filesystem.
> >
> > I just found out it happens also with a newly created xfs and also with
> > ext3 and ext4. The reason that I did not see that initially is that the
> > script I'm using needs to be on the same fs which wasn't the case when I
> > initially tried it with a new fs. The sequence I'm using is:
>
> Ah-hah, got it. So the leak's probably of a delegation on the file
> containing the script itself. OK, I should be able to fix that, thanks!
This should be fixed in the latest upstream (so, in 39-rc5, when that
comes out) and soon in stable. Let me know if not.
--b.