Bruce,
Please pull this branch from github:
https://github.com/ffilz/pynfs/commits/master
The git log is below.
Thanks
Frank
commit 2ddd13347e2769801e1c72c8e8d32cef1bcb3fe0
Author: Frank S. Filz <[email protected]>
Date: Wed May 22 17:11:02 2013 -0700
Make LOOK10 accept MSG_ACCEPTED: GARBAGE_ARGS as well as NFS4ERR_BADXDR
The Ganesha server does XDR for the whole request before starting to
process COMPOUND. As a result, LOOK10 causes an XDR failure that Ganesha
responds at RPC layer and never gets to NFS layer to return NFS4ERR_BADXDR.
Signed-off-by: Frank S. Filz <[email protected]>
commit 1eda552a5183e71351fc84c53b9561b8a9cab4f1
Author: Frank S. Filz <[email protected]>
Date: Wed May 1 16:14:41 2013 -0700
Make some tests runable by request
Ganesha can pass several tests that were made inoperable.
The original FLAGS: for these were commented out and FLAGS:
is left blank so these tests only run if requested for.
Plus a few tests had duplicate names.
Signed-off-by: Frank S. Filz <[email protected]>
commit a6548ab80a68787dc3fcb5c8531d4d189d77c3a9
Author: Frank S. Filz <[email protected]>
Date: Wed May 1 16:06:56 2013 -0700
Make mode 000 tests expect NFS4_OK when run as root
They will warn if NFS4ERR_ACCESS is returned.
Signed-off-by: Frank S. Filz <[email protected]>
On Tue, Jun 11, 2013 at 10:08:09AM -0700, Frank Filz wrote:
> Please pull this branch from github:
> https://github.com/ffilz/pynfs/commits/master
Thanks, applied (actually from git://github.com/ffilz/pynfs.git master).
> commit a6548ab80a68787dc3fcb5c8531d4d189d77c3a9
> Author: Frank S. Filz <[email protected]>
> Date: Wed May 1 16:06:56 2013 -0700
>
> Make mode 000 tests expect NFS4_OK when run as root
>
> They will warn if NFS4ERR_ACCESS is returned.
... though I'm not sure about this one. root-squashing is completely
normal, I'm not convinced it merits a warning.
--b.
On 06/11/2013 01:06 PM, J. Bruce Fields wrote:
> On Tue, Jun 11, 2013 at 10:08:09AM -0700, Frank Filz wrote:
>> Please pull this branch from github:
>> https://github.com/ffilz/pynfs/commits/master
>
> Thanks, applied (actually from git://github.com/ffilz/pynfs.git master).
>
>> commit a6548ab80a68787dc3fcb5c8531d4d189d77c3a9
>> Author: Frank S. Filz <[email protected]>
>> Date: Wed May 1 16:06:56 2013 -0700
>>
>> Make mode 000 tests expect NFS4_OK when run as root
>>
>> They will warn if NFS4ERR_ACCESS is returned.
>
> ... though I'm not sure about this one. root-squashing is completely
> normal, I'm not convinced it merits a warning.
Oh, didn't think about that, good point. Would you like me to submit a
patch to make it an acceptable return?
Frank
On Tue, Jun 11, 2013 at 02:01:01PM -0700, Frank Filz wrote:
> On 06/11/2013 01:28 PM, J. Bruce Fields wrote:
> >On Tue, Jun 11, 2013 at 01:22:46PM -0700, Frank Filz wrote:
> >>On 06/11/2013 01:06 PM, J. Bruce Fields wrote:
> >>>On Tue, Jun 11, 2013 at 10:08:09AM -0700, Frank Filz wrote:
> >>>>Please pull this branch from github:
> >>>>https://github.com/ffilz/pynfs/commits/master
> >>>
> >>>Thanks, applied (actually from git://github.com/ffilz/pynfs.git master).
> >>>
> >>>>commit a6548ab80a68787dc3fcb5c8531d4d189d77c3a9
> >>>>Author: Frank S. Filz <[email protected]>
> >>>>Date: Wed May 1 16:06:56 2013 -0700
> >>>>
> >>>>Make mode 000 tests expect NFS4_OK when run as root
> >>>>
> >>>>They will warn if NFS4ERR_ACCESS is returned.
> >>>
> >>>... though I'm not sure about this one. root-squashing is completely
> >>>normal, I'm not convinced it merits a warning.
> >>
> >>Oh, didn't think about that, good point. Would you like me to submit
> >>a patch to make it an acceptable return?
> >
> >In the uid=0 case, yes, I think that's best.
>
> If you want to pull again, I just added a new patch to do so.
>
> Tested the mode000 tests with root, squashed and not, and with a
> non-root user. Pass in all cases against Ganesha.
Thanks!--b.
On 06/11/2013 01:28 PM, J. Bruce Fields wrote:
> On Tue, Jun 11, 2013 at 01:22:46PM -0700, Frank Filz wrote:
>> On 06/11/2013 01:06 PM, J. Bruce Fields wrote:
>>> On Tue, Jun 11, 2013 at 10:08:09AM -0700, Frank Filz wrote:
>>>> Please pull this branch from github:
>>>> https://github.com/ffilz/pynfs/commits/master
>>>
>>> Thanks, applied (actually from git://github.com/ffilz/pynfs.git master).
>>>
>>>> commit a6548ab80a68787dc3fcb5c8531d4d189d77c3a9
>>>> Author: Frank S. Filz <[email protected]>
>>>> Date: Wed May 1 16:06:56 2013 -0700
>>>>
>>>> Make mode 000 tests expect NFS4_OK when run as root
>>>>
>>>> They will warn if NFS4ERR_ACCESS is returned.
>>>
>>> ... though I'm not sure about this one. root-squashing is completely
>>> normal, I'm not convinced it merits a warning.
>>
>> Oh, didn't think about that, good point. Would you like me to submit
>> a patch to make it an acceptable return?
>
> In the uid=0 case, yes, I think that's best.
If you want to pull again, I just added a new patch to do so.
Tested the mode000 tests with root, squashed and not, and with a
non-root user. Pass in all cases against Ganesha.
Frank
On Tue, Jun 11, 2013 at 01:22:46PM -0700, Frank Filz wrote:
> On 06/11/2013 01:06 PM, J. Bruce Fields wrote:
> >On Tue, Jun 11, 2013 at 10:08:09AM -0700, Frank Filz wrote:
> >>Please pull this branch from github:
> >>https://github.com/ffilz/pynfs/commits/master
> >
> >Thanks, applied (actually from git://github.com/ffilz/pynfs.git master).
> >
> >>commit a6548ab80a68787dc3fcb5c8531d4d189d77c3a9
> >>Author: Frank S. Filz <[email protected]>
> >>Date: Wed May 1 16:06:56 2013 -0700
> >>
> >>Make mode 000 tests expect NFS4_OK when run as root
> >>
> >>They will warn if NFS4ERR_ACCESS is returned.
> >
> >... though I'm not sure about this one. root-squashing is completely
> >normal, I'm not convinced it merits a warning.
>
> Oh, didn't think about that, good point. Would you like me to submit
> a patch to make it an acceptable return?
In the uid=0 case, yes, I think that's best.
--b.