2019-12-05 10:28:21

by Doug Nazar

Subject: [PATCH] Disable statx if using glibc emulation

On older kernels without statx, glibc with statx support will attempt
to emulate the call. However it doesn't support AT_STATX_DONT_SYNC and
will return EINVAL. This causes all xstat/xlstat calls to fail.

Signed-off-by: Doug Nazar <[email protected]>
---
support/misc/xstat.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/support/misc/xstat.c b/support/misc/xstat.c
index 661e29e4..a438fbcc 100644
--- a/support/misc/xstat.c
+++ b/support/misc/xstat.c
@@ -51,6 +51,9 @@ statx_do_stat(int fd, const char *pathname, struct stat *statbuf, int flags)
statx_copy(statbuf, &stxbuf);
return 0;
}
+ /* glibc emulation doesn't support AT_STATX_DONT_SYNC */
+ if (errno == EINVAL)
+ errno = ENOSYS;
if (errno == ENOSYS)
statx_supported = 0;
} else
--
2.24.0

2019-12-09 15:57:26

by Steve Dickson

Subject: Re: [PATCH] Disable statx if using glibc emulation

On 12/5/19 5:27 AM, Doug Nazar wrote:
> On older kernels without statx, glibc with statx support will attempt
> to emulate the call. However it doesn't support AT_STATX_DONT_SYNC and
> will return EINVAL. This causes all xstat/xlstat calls to fail.
>
> Signed-off-by: Doug Nazar <[email protected]>
Committed... (tag: nfs-utils-2-4-3-rc3)

steved.

> ---
> support/misc/xstat.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/support/misc/xstat.c b/support/misc/xstat.c
> index 661e29e4..a438fbcc 100644
> --- a/support/misc/xstat.c
> +++ b/support/misc/xstat.c
> @@ -51,6 +51,9 @@ statx_do_stat(int fd, const char *pathname, struct stat *statbuf, int flags)
> statx_copy(statbuf, &stxbuf);
> return 0;
> }
> + /* glibc emulation doesn't support AT_STATX_DONT_SYNC */
> + if (errno == EINVAL)
> + errno = ENOSYS;
> if (errno == ENOSYS)
> statx_supported = 0;
> } else
>