2020-09-04 18:20:43

by Steve Dickson

Subject: [PATCH] rpc.idmapd: Do not free config varibles

Commit 93e8f092e added a conf_cleanup() call to clean
up memory after the config file was parsed. It turns
out that memory still needed and it is not very much
so the call is removed.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1873965

Signed-off-by: Steve Dickson <[email protected]>
---
utils/idmapd/idmapd.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
index f3d2314..51c71fb 100644
--- a/utils/idmapd/idmapd.c
+++ b/utils/idmapd/idmapd.c
@@ -306,9 +306,6 @@ main(int argc, char **argv)
serverstart = 0;
}

- /* Config memory is no longer needed */
- conf_cleanup();
-
while ((opt = getopt(argc, argv, GETOPTSTR)) != -1)
switch (opt) {
case 'v':
--
2.26.2

2020-09-08 19:59:23

by Steve Dickson

Subject: Re: [PATCH] rpc.idmapd: Do not free config varibles

On 9/4/20 2:19 PM, Steve Dickson wrote:
> Commit 93e8f092e added a conf_cleanup() call to clean
> up memory after the config file was parsed. It turns
> out that memory still needed and it is not very much
> so the call is removed.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1873965
>
> Signed-off-by: Steve Dickson <[email protected]>
Committed...

steved.
> ---
> utils/idmapd/idmapd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
> index f3d2314..51c71fb 100644
> --- a/utils/idmapd/idmapd.c
> +++ b/utils/idmapd/idmapd.c
> @@ -306,9 +306,6 @@ main(int argc, char **argv)
> serverstart = 0;
> }
>
> - /* Config memory is no longer needed */
> - conf_cleanup();
> -
> while ((opt = getopt(argc, argv, GETOPTSTR)) != -1)
> switch (opt) {
> case 'v':
>