2020-10-11 18:07:35

by Tom Rix

Subject: [PATCH] nfsd: remove unneeded break

From: Tom Rix <[email protected]>

Because every path through nfs4_find_file()'s
switch does an explicit return, the break is not needed.

Signed-off-by: Tom Rix <[email protected]>
---
fs/nfsd/nfs4state.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index c09a2a4281ec..741f64672d96 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
return find_readable_file(s->sc_file);
else
return find_writeable_file(s->sc_file);
- break;
}

return NULL;
--
2.18.1

2020-10-12 14:22:39

by J. Bruce Fields

Subject: Re: [PATCH] nfsd: remove unneeded break

On Sun, Oct 11, 2020 at 08:51:55AM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> Because every path through nfs4_find_file()'s
> switch does an explicit return, the break is not needed.

OK, applying.--b.

>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> fs/nfsd/nfs4state.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index c09a2a4281ec..741f64672d96 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5722,7 +5722,6 @@ nfs4_find_file(struct nfs4_stid *s, int flags)
> return find_readable_file(s->sc_file);
> else
> return find_writeable_file(s->sc_file);
> - break;
> }
>
> return NULL;
> --
> 2.18.1