2021-04-01 09:58:42

by Jiabing Wan

Subject: [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration

struct rpcrdma_req is declared twice. One is declared at 216th line.
The blew one is not needed. Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index fe3be985e239..11e5fbfc642c 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -239,7 +239,6 @@ struct rpcrdma_frwr {
};
};

-struct rpcrdma_req;
struct rpcrdma_mr {
struct list_head mr_list;
struct rpcrdma_req *mr_req;
--
2.25.1

2021-04-01 18:11:36

by Chuck Lever III

Subject: Re: [PATCH] sunrpc: xprtrdma: Remove repeated struct declaration

Hi -

> On Apr 1, 2021, at 5:56 AM, Wan Jiabing <[email protected]> wrote:
>
> struct rpcrdma_req is declared twice. One is declared at 216th line.
> The blew one is not needed. Remove the duplicate.

s/blew/below/

>
> Signed-off-by: Wan Jiabing <[email protected]>

Reviewed-by: Chuck Lever <[email protected]>

Thanks! This one goes to Anna.


> ---
> net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> index fe3be985e239..11e5fbfc642c 100644
> --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> @@ -239,7 +239,6 @@ struct rpcrdma_frwr {
> };
> };
>
> -struct rpcrdma_req;
> struct rpcrdma_mr {
> struct list_head mr_list;
> struct rpcrdma_req *mr_req;
> --
> 2.25.1
>

--
Chuck Lever