2021-10-19 04:15:26

by CGEL

Subject: [PATCH] NFSD:fix boolreturn.cocci warning

From: Changcheng Deng <[email protected]>

./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function
'nfssvc_decode_voidarg' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Changcheng Deng <[email protected]>
---
fs/nfsd/nfssvc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 362e819ff06a..80431921e5d7 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
*/
bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr)
{
- return 1;
+ return true;
}

/**
--
2.25.1

2021-10-19 14:34:10

by Chuck Lever III

Subject: Re: [PATCH] NFSD:fix boolreturn.cocci warning

> On Oct 19, 2021, at 12:14 AM, [email protected] wrote:
>
> From: Changcheng Deng <[email protected]>
>
> ./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function
> 'nfssvc_decode_voidarg' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Changcheng Deng <[email protected]>

LGTM.


> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 362e819ff06a..80431921e5d7 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
> */
> bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr)
> {
> - return 1;
> + return true;
> }
>
> /**
> --
> 2.25.1
>

--
Chuck Lever

2021-10-19 14:37:26

by J. Bruce Fields

Subject: Re: [PATCH] NFSD:fix boolreturn.cocci warning

On Tue, Oct 19, 2021 at 02:33:36PM +0000, Chuck Lever III wrote:
>
>
> > On Oct 19, 2021, at 12:14 AM, [email protected] wrote:
> >
> > From: Changcheng Deng <[email protected]>
> >
> > ./fs/nfsd/nfssvc.c: 1072: 8-9: :WARNING return of 0/1 in function
> > 'nfssvc_decode_voidarg' with return type bool
> >
> > Return statements in functions returning bool should use true/false
> > instead of 1/0.
> >
> > Reported-by: Zeal Robot <[email protected]>
> > Signed-off-by: Changcheng Deng <[email protected]>
>
> LGTM.

OK, applying for 5.16.--b.

>
>
> > ---
> > fs/nfsd/nfssvc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> > index 362e819ff06a..80431921e5d7 100644
> > --- a/fs/nfsd/nfssvc.c
> > +++ b/fs/nfsd/nfssvc.c
> > @@ -1069,7 +1069,7 @@ int nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
> > */
> > bool nfssvc_decode_voidarg(struct svc_rqst *rqstp, struct xdr_stream *xdr)
> > {
> > - return 1;
> > + return true;
> > }
> >
> > /**
> > --
> > 2.25.1
> >
>
> --
> Chuck Lever
>
>