2022-09-06 02:06:58

by Yi Jiangshan

Subject: [PATCH] fs/nfs/pnfs_nfs.c: fix spelling typo and syntax error in comment

From: Jiangshan Yi <[email protected]>

Fix spelling typo and syntax error in comment.

Reported-by: k2ci <[email protected]>
Signed-off-by: Jiangshan Yi <[email protected]>
---
fs/nfs/pnfs_nfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c
index 657c242a18ff..45a5a66a2e3e 100644
--- a/fs/nfs/pnfs_nfs.c
+++ b/fs/nfs/pnfs_nfs.c
@@ -374,12 +374,12 @@ pnfs_bucket_search_commit_reqs(struct pnfs_commit_bucket *buckets,
return NULL;
}

-/* pnfs_generic_search_commit_reqs - Search lists in @cinfo for the head reqest
+/* pnfs_generic_search_commit_reqs - Search lists in @cinfo for the head request
* for @page
* @cinfo - commit info for current inode
* @page - page to search for matching head request
*
- * Returns a the head request if one is found, otherwise returns NULL.
+ * Returns the head request if one is found, otherwise returns NULL.
*/
struct nfs_page *
pnfs_generic_search_commit_reqs(struct nfs_commit_info *cinfo, struct page *page)
--
2.25.1


No virus found
Checked by Hillstone Network AntiVirus

2022-09-06 02:11:48

by Randy Dunlap

Subject: Re: [PATCH] fs/nfs/pnfs_nfs.c: fix spelling typo and syntax error in comment

Hi,

On 9/5/22 18:50, Jiangshan Yi wrote:
> From: Jiangshan Yi <[email protected]>
>
> Fix spelling typo and syntax error in comment.
>
> Reported-by: k2ci <[email protected]>
> Signed-off-by: Jiangshan Yi <[email protected]>
> ---
> fs/nfs/pnfs_nfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c
> index 657c242a18ff..45a5a66a2e3e 100644
> --- a/fs/nfs/pnfs_nfs.c
> +++ b/fs/nfs/pnfs_nfs.c
> @@ -374,12 +374,12 @@ pnfs_bucket_search_commit_reqs(struct pnfs_commit_bucket *buckets,
> return NULL;
> }
>
> -/* pnfs_generic_search_commit_reqs - Search lists in @cinfo for the head reqest
> +/* pnfs_generic_search_commit_reqs - Search lists in @cinfo for the head request
> * for @page
> * @cinfo - commit info for current inode
> * @page - page to search for matching head request
> *

Since you are changing the Returns line anyway, please use the documented
kernel-doc syntax for it:

> - * Returns a the head request if one is found, otherwise returns NULL.
> + * Returns the head request if one is found, otherwise returns NULL.

* Return: the head request if one is found, otherwise %NULL.

> */
> struct nfs_page *
> pnfs_generic_search_commit_reqs(struct nfs_commit_info *cinfo, struct page *page)

Thanks.
--
~Randy