2023-08-09 13:19:05

by Steve Dickson

Subject: [PATCH] Fixed a regression in the junction code

commit cdbef4e9 created a regression in the
in the junction code by adding a O_PATH flag
to the open() in junction_open_path()

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2213669
Signed-off-by: Steve Dickson <[email protected]>
---
support/junction/junction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/junction/junction.c b/support/junction/junction.c
index 0628bb0f..c1ec8ff8 100644
--- a/support/junction/junction.c
+++ b/support/junction/junction.c
@@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
if (pathname == NULL || fd == NULL)
return FEDFS_ERR_INVAL;

- tmp = open(pathname, O_PATH|O_DIRECTORY);
+ tmp = open(pathname, O_DIRECTORY);
if (tmp == -1) {
switch (errno) {
case EPERM:
--
2.41.0

2023-08-10 16:06:18

by Steve Dickson

Subject: Re: [PATCH] Fixed a regression in the junction code

On 8/9/23 9:00 AM, Steve Dickson wrote:
> commit cdbef4e9 created a regression in the
> in the junction code by adding a O_PATH flag
> to the open() in junction_open_path()
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2213669
> Signed-off-by: Steve Dickson <[email protected]>
Committed...

steved.
> ---
> support/junction/junction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/junction/junction.c b/support/junction/junction.c
> index 0628bb0f..c1ec8ff8 100644
> --- a/support/junction/junction.c
> +++ b/support/junction/junction.c
> @@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
> if (pathname == NULL || fd == NULL)
> return FEDFS_ERR_INVAL;
>
> - tmp = open(pathname, O_PATH|O_DIRECTORY);
> + tmp = open(pathname, O_DIRECTORY);
> if (tmp == -1) {
> switch (errno) {
> case EPERM: