2023-07-21 12:46:57

by Petr Vorel

Subject: [PATCH 1/1] nfs_lib.sh: Set NFS 4.2 on TCP as the default

Previously NFS 3 on UDP was the default, which leaded to test being
skipped when tests run without parameters:

TCONF: UDP support disabled on NFS server

This does not have an effect when tests run properly via
runtest/net.nfs, which specify parameters. It just safes typing
-t tcp (and optionally -v 4.2) when one runs single test manually.

Signed-off-by: Petr Vorel <[email protected]>
---
Hi,

I'm pretty sure, we don't want to have UDP as the default (besides
skipped with TCONF it was acked by Jeff [1]). But I wonder if NFS 4.2 is
the best as the default version. Maybe just 4 or 4.1?

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/[email protected]/

testcases/network/nfs/nfs_stress/nfs_lib.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
index abf7ba5a2..dae15a2e1 100644
--- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
+++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
@@ -4,9 +4,9 @@
# Copyright (c) 2015-2018 Oracle and/or its affiliates. All Rights Reserved.
# Copyright (c) International Business Machines Corp., 2001

-VERSION=${VERSION:=3}
+VERSION=${VERSION:=4.2}
NFILES=${NFILES:=1000}
-SOCKET_TYPE="${SOCKET_TYPE:-udp}"
+SOCKET_TYPE="${SOCKET_TYPE:-tcp}"
NFS_TYPE=${NFS_TYPE:=nfs}

nfs_usage()
--
2.40.1

2023-09-29 12:00:34

by Petr Vorel

Subject: Re: [PATCH 1/1] nfs_lib.sh: Set NFS 4.2 on TCP as the default

Hi all,

> Previously NFS 3 on UDP was the default, which leaded to test being
> skipped when tests run without parameters:

> TCONF: UDP support disabled on NFS server

> This does not have an effect when tests run properly via
> runtest/net.nfs, which specify parameters. It just safes typing
> -t tcp (and optionally -v 4.2) when one runs single test manually.

FYI patch merged.

Kind regards,
Petr

> Signed-off-by: Petr Vorel <[email protected]>
> ---
> Hi,

> I'm pretty sure, we don't want to have UDP as the default (besides
> skipped with TCONF it was acked by Jeff [1]). But I wonder if NFS 4.2 is
> the best as the default version. Maybe just 4 or 4.1?

> Kind regards,
> Petr

> [1] https://lore.kernel.org/ltp/[email protected]/

> testcases/network/nfs/nfs_stress/nfs_lib.sh | 4 ++--
...
> -VERSION=${VERSION:=3}
> +VERSION=${VERSION:=4.2}
> NFILES=${NFILES:=1000}
> -SOCKET_TYPE="${SOCKET_TYPE:-udp}"
> +SOCKET_TYPE="${SOCKET_TYPE:-tcp}"