2024-05-15 09:23:24

by Chen Hanxiao

Subject: [PATCH fstests] generic/742: don't run it on NFS

This test requires FIEMAP support.

Signed-off-by: Chen Hanxiao <[email protected]>
---
tests/generic/742 | 1 +
1 file changed, 1 insertion(+)

diff --git a/tests/generic/742 b/tests/generic/742
index 43ebdbc6..aad57f2d 100755
--- a/tests/generic/742
+++ b/tests/generic/742
@@ -30,6 +30,7 @@ _require_test
_require_test_program "fiemap-fault"
_require_test_program "punch-alternating"
_require_xfs_io_command "fpunch"
+_require_xfs_io_command "fiemap"

dst=$TEST_DIR/$seq/fiemap-fault

--
2.43.0

2024-05-16 03:50:15

by Zorro Lang

Subject: Re: [PATCH fstests] generic/742: don't run it on NFS

On Wed, May 15, 2024 at 05:21:33PM +0800, Chen Hanxiao wrote:
> This test requires FIEMAP support.
>
> Signed-off-by: Chen Hanxiao <[email protected]>
> ---
> tests/generic/742 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/742 b/tests/generic/742
> index 43ebdbc6..aad57f2d 100755
> --- a/tests/generic/742
> +++ b/tests/generic/742
> @@ -30,6 +30,7 @@ _require_test
> _require_test_program "fiemap-fault"
> _require_test_program "punch-alternating"
> _require_xfs_io_command "fpunch"
> +_require_xfs_io_command "fiemap"

Make sense to me. But according the change, I'd like to change the subject
from "don't run it on NFS" to "require fiemap support", due to it's not
only for NFS.

Reviewed-by: Zorro Lang <[email protected]>

>
> dst=$TEST_DIR/$seq/fiemap-fault
>
> --
> 2.43.0
>
>