2023-10-25 12:36:44

by Benjamin Coddington

[permalink] [raw]
Subject: Re: [PATCH net v2] net: sunrpc: Fix an off by one in rpc_sockaddr2uaddr()

On 24 Oct 2023, at 17:58, Christophe JAILLET wrote:

> The intent is to check if the strings' are truncated or not. So, >= should
> be used instead of >, because strlcat() and snprintf() return the length of
> the output, excluding the trailing NULL.
>
> Fixes: a02d69261134 ("SUNRPC: Provide functions for managing universal addresses")
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> v2: Fix cut'n'paste typo in subject
> Add net in [PATCH...]
> ---

Reviewed-by: Benjamin Coddington <[email protected]>

Ben