2021-01-22 10:01:56

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq

On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang
<[email protected]> wrote:
>
> We can remove 'q' from blk_execute_rq as well after the previous change
> in blk_execute_rq_nowait.
>
> And more importantly it never really was needed to start with given
> that we can trivial derive it from struct request.
>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Guoqing Jiang <[email protected]>

[...]

> drivers/mmc/core/block.c | 10 +++++-----

[...]

From mmc point of view, please add:

Acked-by: Ulf Hansson <[email protected]>

At the moment I don't think this will conflict with any changes to
mmc, but if that happens let's sort it then...

Kind regards
Uffe


2021-01-25 04:39:54

by Guoqing Jiang

[permalink] [raw]
Subject: Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq



On 1/22/21 10:50, Ulf Hansson wrote:
> On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang
> <[email protected]> wrote:
>>
>> We can remove 'q' from blk_execute_rq as well after the previous change
>> in blk_execute_rq_nowait.
>>
>> And more importantly it never really was needed to start with given
>> that we can trivial derive it from struct request.
>>
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Guoqing Jiang <[email protected]>
>
> [...]
>
>> drivers/mmc/core/block.c | 10 +++++-----
>
> [...]
>
> From mmc point of view, please add:
>
> Acked-by: Ulf Hansson <[email protected]>
>
> At the moment I don't think this will conflict with any changes to
> mmc, but if that happens let's sort it then...
>

Thank you! Will resend and add your acked-by.

Guoqing