2020-08-12 14:13:45

by Alex Dewar

Subject: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c

In nfsd4_encode_listxattrs(), the variable p is assigned to at one point
but this value is never used before p is reassigned. Fix this.

Addresses-Coverity: ("Unused value")
Signed-off-by: Alex Dewar <[email protected]>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 259d5ad0e3f47..1a0341fd80f9a 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -4859,7 +4859,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr,
goto out;
}

- p = xdr_encode_opaque(p, sp, slen);
+ xdr_encode_opaque(p, sp, slen);

xdrleft -= xdrlen;
count++;
--
2.28.0

2020-08-13 19:02:33

by Chuck Lever III

Subject: Re: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c

> On Aug 12, 2020, at 4:36 PM, Frank van der Linden <[email protected]> wrote:
>
> On Wed, Aug 12, 2020 at 03:12:51PM +0100, Alex Dewar wrote:
>>
>> In nfsd4_encode_listxattrs(), the variable p is assigned to at one point
>> but this value is never used before p is reassigned. Fix this.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Alex Dewar <[email protected]>
>> ---
>> fs/nfsd/nfs4xdr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
>> index 259d5ad0e3f47..1a0341fd80f9a 100644
>> --- a/fs/nfsd/nfs4xdr.c
>> +++ b/fs/nfsd/nfs4xdr.c
>> @@ -4859,7 +4859,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr,
>> goto out;
>> }
>>
>> - p = xdr_encode_opaque(p, sp, slen);
>> + xdr_encode_opaque(p, sp, slen);
>>
>> xdrleft -= xdrlen;
>> count++;
>> --
>> 2.28.0
>>
>
> Yep, I guess my linting missed that, thanks for the fix.

Bruce, these two don't appear to be urgent, so I'm deferring them
to you for v5.10.


--
Chuck Lever

2020-08-20 23:38:44

by Alex Dewar

Subject: Re: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c

On Wed, Aug 12, 2020 at 08:36:31PM +0000, Frank van der Linden wrote:
> On Wed, Aug 12, 2020 at 03:12:51PM +0100, Alex Dewar wrote:
> >
> > In nfsd4_encode_listxattrs(), the variable p is assigned to at one point
> > but this value is never used before p is reassigned. Fix this.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Alex Dewar <[email protected]>
> > ---
> > fs/nfsd/nfs4xdr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> > index 259d5ad0e3f47..1a0341fd80f9a 100644
> > --- a/fs/nfsd/nfs4xdr.c
> > +++ b/fs/nfsd/nfs4xdr.c
> > @@ -4859,7 +4859,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr,
> > goto out;
> > }
> >
> > - p = xdr_encode_opaque(p, sp, slen);
> > + xdr_encode_opaque(p, sp, slen);
> >
> > xdrleft -= xdrlen;
> > count++;
> > --
> > 2.28.0
> >
>
> Yep, I guess my linting missed that, thanks for the fix.
>
> - Frank

Ping? The second patch in this series had a mistake in it, but I think
this one's still good to go :-)