2020-12-10 18:29:41

by Steve Dickson

[permalink] [raw]
Subject: [PATCH] exportfs: Ingnore export failures in nfs-server.serivce unit

With some recent commits, exportfs will continue on trying to
export filesystems even when an entry is invalid or does
not exist, but will still have a non-zero exit to report
the error.

This situation should not stop the nfs-server service
from comingup so nfs-server.service file should
ignore these types of failures

Signed-off-by: Steve Dickson <[email protected]>
---
systemd/nfs-server.service | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
index 06c1adb..b432f91 100644
--- a/systemd/nfs-server.service
+++ b/systemd/nfs-server.service
@@ -21,13 +21,13 @@ After=rpc-gssd.service gssproxy.service rpc-svcgssd.service
[Service]
Type=oneshot
RemainAfterExit=yes
-ExecStartPre=/usr/sbin/exportfs -r
+ExecStartPre=-/usr/sbin/exportfs -r
ExecStart=/usr/sbin/rpc.nfsd
ExecStop=/usr/sbin/rpc.nfsd 0
ExecStopPost=/usr/sbin/exportfs -au
ExecStopPost=/usr/sbin/exportfs -f

-ExecReload=/usr/sbin/exportfs -r
+ExecReload=-/usr/sbin/exportfs -r

[Install]
WantedBy=multi-user.target
--
2.28.0


2020-12-11 14:31:31

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] exportfs: Ingnore export failures in nfs-server.serivce unit



On 12/10/20 1:24 PM, Steve Dickson wrote:
> With some recent commits, exportfs will continue on trying to
> export filesystems even when an entry is invalid or does
> not exist, but will still have a non-zero exit to report
> the error.
>
> This situation should not stop the nfs-server service
> from comingup so nfs-server.service file should
> ignore these types of failures
>
> Signed-off-by: Steve Dickson <[email protected]>
Committed. (tag: nfs-utils-2-5-3-rc2)

steved.
> ---
> systemd/nfs-server.service | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index 06c1adb..b432f91 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -21,13 +21,13 @@ After=rpc-gssd.service gssproxy.service rpc-svcgssd.service
> [Service]
> Type=oneshot
> RemainAfterExit=yes
> -ExecStartPre=/usr/sbin/exportfs -r
> +ExecStartPre=-/usr/sbin/exportfs -r
> ExecStart=/usr/sbin/rpc.nfsd
> ExecStop=/usr/sbin/rpc.nfsd 0
> ExecStopPost=/usr/sbin/exportfs -au
> ExecStopPost=/usr/sbin/exportfs -f
>
> -ExecReload=/usr/sbin/exportfs -r
> +ExecReload=-/usr/sbin/exportfs -r
>
> [Install]
> WantedBy=multi-user.target
>