2019-05-08 15:08:50

by Orion Poplawski

[permalink] [raw]
Subject: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files

This fixes:

/usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
please update the unit file accordingly.

Signed-off-by: Orion Poplawski <[email protected]>
---
systemd/nfs-blkmap.service | 2 +-
systemd/rpc-statd.service | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
index 2bbcee6..6aa45ba 100644
--- a/systemd/nfs-blkmap.service
+++ b/systemd/nfs-blkmap.service
@@ -9,7 +9,7 @@ PartOf=nfs-utils.service

[Service]
Type=forking
-PIDFile=/var/run/blkmapd.pid
+PIDFile=/run/blkmapd.pid
ExecStart=/usr/sbin/blkmapd

[Install]
diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
index 3e92cf7..095629f 100644
--- a/systemd/rpc-statd.service
+++ b/systemd/rpc-statd.service
@@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
[Service]
Environment=RPC_STATD_NO_NOTIFY=1
Type=forking
-PIDFile=/var/run/rpc.statd.pid
+PIDFile=/run/rpc.statd.pid
ExecStart=/usr/sbin/rpc.statd
--
1.8.3.1

--
Orion Poplawski
Manager of NWRA Technical Systems 720-772-5637
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane [email protected]
Boulder, CO 80301 https://www.nwra.com/

Attachments:
smime.p7s (3.71 kB)
S/MIME Cryptographic Signature

2019-05-08 15:55:37

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files



On 5/8/19 10:58 AM, Orion Poplawski wrote:
> This fixes:
>
> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
> please update the unit file accordingly.
Shouldn't the apps also be updated? I know there is a symbolic
link... but just for completeness the pid files in both apps
should be updated as well.

steved.
>
> Signed-off-by: Orion Poplawski <[email protected]>
> ---
> systemd/nfs-blkmap.service | 2 +-
> systemd/rpc-statd.service | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
> index 2bbcee6..6aa45ba 100644
> --- a/systemd/nfs-blkmap.service
> +++ b/systemd/nfs-blkmap.service
> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>
> [Service]
> Type=forking
> -PIDFile=/var/run/blkmapd.pid
> +PIDFile=/run/blkmapd.pid
> ExecStart=/usr/sbin/blkmapd
>
> [Install]
> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
> index 3e92cf7..095629f 100644
> --- a/systemd/rpc-statd.service
> +++ b/systemd/rpc-statd.service
> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
> [Service]
> Environment=RPC_STATD_NO_NOTIFY=1
> Type=forking
> -PIDFile=/var/run/rpc.statd.pid
> +PIDFile=/run/rpc.statd.pid
> ExecStart=/usr/sbin/rpc.statd
> --
> 1.8.3.1
>

2019-05-08 16:02:54

by Orion Poplawski

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files

On 5/8/19 9:54 AM, Steve Dickson wrote:
>
>
> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>> This fixes:
>>
>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>> please update the unit file accordingly.
> Shouldn't the apps also be updated? I know there is a symbolic
> link... but just for completeness the pid files in both apps
> should be updated as well.
>
> steved.

I thought about that - but was concerned about legacy systems that still use
/var/run.

>>
>> Signed-off-by: Orion Poplawski <[email protected]>
>> ---
>> systemd/nfs-blkmap.service | 2 +-
>> systemd/rpc-statd.service | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>> index 2bbcee6..6aa45ba 100644
>> --- a/systemd/nfs-blkmap.service
>> +++ b/systemd/nfs-blkmap.service
>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>
>> [Service]
>> Type=forking
>> -PIDFile=/var/run/blkmapd.pid
>> +PIDFile=/run/blkmapd.pid
>> ExecStart=/usr/sbin/blkmapd
>>
>> [Install]
>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>> index 3e92cf7..095629f 100644
>> --- a/systemd/rpc-statd.service
>> +++ b/systemd/rpc-statd.service
>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>> [Service]
>> Environment=RPC_STATD_NO_NOTIFY=1
>> Type=forking
>> -PIDFile=/var/run/rpc.statd.pid
>> +PIDFile=/run/rpc.statd.pid
>> ExecStart=/usr/sbin/rpc.statd
>> --
>> 1.8.3.1
>>


--
Orion Poplawski
Manager of NWRA Technical Systems 720-772-5637
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane [email protected]
Boulder, CO 80301 https://www.nwra.com/

Attachments:
smime.p7s (3.71 kB)
S/MIME Cryptographic Signature

2019-05-09 17:26:25

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files



On 5/8/19 12:02 PM, Orion Poplawski wrote:
> On 5/8/19 9:54 AM, Steve Dickson wrote:
>>
>>
>> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>>> This fixes:
>>>
>>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>>> please update the unit file accordingly.
>> Shouldn't the apps also be updated? I know there is a symbolic
>> link... but just for completeness the pid files in both apps
>> should be updated as well.
>>
>> steved.
>
> I thought about that - but was concerned about legacy systems that still use
> /var/run.
Any idea how long the symlink will be around? But I do see your point.

steved.

>
>>>
>>> Signed-off-by: Orion Poplawski <[email protected]>
>>> ---
>>> systemd/nfs-blkmap.service | 2 +-
>>> systemd/rpc-statd.service | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>>> index 2bbcee6..6aa45ba 100644
>>> --- a/systemd/nfs-blkmap.service
>>> +++ b/systemd/nfs-blkmap.service
>>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>>
>>> [Service]
>>> Type=forking
>>> -PIDFile=/var/run/blkmapd.pid
>>> +PIDFile=/run/blkmapd.pid
>>> ExecStart=/usr/sbin/blkmapd
>>>
>>> [Install]
>>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>>> index 3e92cf7..095629f 100644
>>> --- a/systemd/rpc-statd.service
>>> +++ b/systemd/rpc-statd.service
>>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>>> [Service]
>>> Environment=RPC_STATD_NO_NOTIFY=1
>>> Type=forking
>>> -PIDFile=/var/run/rpc.statd.pid
>>> +PIDFile=/run/rpc.statd.pid
>>> ExecStart=/usr/sbin/rpc.statd
>>> --
>>> 1.8.3.1
>>>
>
>

2019-05-10 15:08:31

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] nfs-utils: Change /var/run -> /run in systemd service files



On 5/9/19 1:25 PM, Steve Dickson wrote:
>
>
> On 5/8/19 12:02 PM, Orion Poplawski wrote:
>> On 5/8/19 9:54 AM, Steve Dickson wrote:
>>>
>>>
>>> On 5/8/19 10:58 AM, Orion Poplawski wrote:
>>>> This fixes:
>>>>
>>>> /usr/lib/systemd/system/nfs-blkmap.service:10: PIDFile= references path below
>>>> legacy directory /var/run/, updating /var/run/blkmapd.pid → /run/blkmapd.pid;
>>>> please update the unit file accordingly.
>>> Shouldn't the apps also be updated? I know there is a symbolic
>>> link... but just for completeness the pid files in both apps
>>> should be updated as well.
>>>
>>> steved.
>>
>> I thought about that - but was concerned about legacy systems that still use
>> /var/run.
> Any idea how long the symlink will be around? But I do see your point.
>
> steved.
>
>>
>>>>
>>>> Signed-off-by: Orion Poplawski <[email protected]>
>>>> ---
>>>> systemd/nfs-blkmap.service | 2 +-
>>>> systemd/rpc-statd.service | 2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
Committed....

steved.

>>>>
>>>> diff --git a/systemd/nfs-blkmap.service b/systemd/nfs-blkmap.service
>>>> index 2bbcee6..6aa45ba 100644
>>>> --- a/systemd/nfs-blkmap.service
>>>> +++ b/systemd/nfs-blkmap.service
>>>> @@ -9,7 +9,7 @@ PartOf=nfs-utils.service
>>>>
>>>> [Service]
>>>> Type=forking
>>>> -PIDFile=/var/run/blkmapd.pid
>>>> +PIDFile=/run/blkmapd.pid
>>>> ExecStart=/usr/sbin/blkmapd
>>>>
>>>> [Install]
>>>> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
>>>> index 3e92cf7..095629f 100644
>>>> --- a/systemd/rpc-statd.service
>>>> +++ b/systemd/rpc-statd.service
>>>> @@ -13,5 +13,5 @@ IgnoreOnIsolate=yes
>>>> [Service]
>>>> Environment=RPC_STATD_NO_NOTIFY=1
>>>> Type=forking
>>>> -PIDFile=/var/run/rpc.statd.pid
>>>> +PIDFile=/run/rpc.statd.pid
>>>> ExecStart=/usr/sbin/rpc.statd
>>>> --
>>>> 1.8.3.1
>>>>
>>
>>