2024-01-29 16:53:36

by Benjamin Coddington

[permalink] [raw]
Subject: Re: [PATCH] sunrpc: fix assignment of to_retries in svc_process_bc

On 29 Jan 2024, at 11:43, Jeff Layton wrote:

> Alex reported seeing this:
>
> [ 18.238266] ------------[ cut here ]------------
> ...

This one got fixed already, just waiting for a maintainer to send it along:

https://lore.kernel.org/linux-nfs/[email protected]/

Ben



2024-01-29 16:56:16

by Chuck Lever III

[permalink] [raw]
Subject: Re: [PATCH] sunrpc: fix assignment of to_retries in svc_process_bc



> On Jan 29, 2024, at 11:52 AM, Benjamin Coddington <[email protected]> wrote:
>
> On 29 Jan 2024, at 11:43, Jeff Layton wrote:
>
>> Alex reported seeing this:
>>
>> [ 18.238266] ------------[ cut here ]------------
>> ...
>
> This one got fixed already, just waiting for a maintainer to send it along:
>
> https://lore.kernel.org/linux-nfs/[email protected]/

Ah. That touches net/sunrpc/svc.c, but it was sent to the client maintainers.

Do you want me to take it through the nfsd tree?


--
Chuck Lever


2024-01-29 16:59:58

by Benjamin Coddington

[permalink] [raw]
Subject: Re: [PATCH] sunrpc: fix assignment of to_retries in svc_process_bc

On 29 Jan 2024, at 11:55, Chuck Lever III wrote:

>> On Jan 29, 2024, at 11:52 AM, Benjamin Coddington <[email protected]> wrote:
>>
>> On 29 Jan 2024, at 11:43, Jeff Layton wrote:
>>
>>> Alex reported seeing this:
>>>
>>> [ 18.238266] ------------[ cut here ]------------
>>> ...
>>
>> This one got fixed already, just waiting for a maintainer to send it along:
>>
>> https://lore.kernel.org/linux-nfs/[email protected]/
>
> Ah. That touches net/sunrpc/svc.c, but it was sent to the client maintainers.
>
> Do you want me to take it through the nfsd tree?

Oh yeah if you like, not sure how you want to sort it between the because
even though its in svc.c, its a client fix; this code is specific for the
client's backchannel.

Note the version on this thread misses the 2nd typo.

Ben


2024-01-29 17:02:51

by Chuck Lever III

[permalink] [raw]
Subject: Re: [PATCH] sunrpc: fix assignment of to_retries in svc_process_bc



> On Jan 29, 2024, at 11:59 AM, Benjamin Coddington <[email protected]> wrote:
>
> On 29 Jan 2024, at 11:55, Chuck Lever III wrote:
>
>>> On Jan 29, 2024, at 11:52 AM, Benjamin Coddington <[email protected]> wrote:
>>>
>>> On 29 Jan 2024, at 11:43, Jeff Layton wrote:
>>>
>>>> Alex reported seeing this:
>>>>
>>>> [ 18.238266] ------------[ cut here ]------------
>>>> ...
>>>
>>> This one got fixed already, just waiting for a maintainer to send it along:
>>>
>>> https://lore.kernel.org/linux-nfs/[email protected]/
>>
>> Ah. That touches net/sunrpc/svc.c, but it was sent to the client maintainers.
>>
>> Do you want me to take it through the nfsd tree?
>
> Oh yeah if you like, not sure how you want to sort it between the because
> even though its in svc.c, its a client fix; this code is specific for the
> client's backchannel.

I'll add to nfsd-fixes.


> Note the version on this thread misses the 2nd typo.

Ack.


--
Chuck Lever