2022-11-04 01:51:52

by Li zeming

Subject: [PATCH] sunrpc: svc: Remove an unused static function svc_ungetu32()

The svc_ungetu32 function is not used, you could remove it.

Signed-off-by: Li zeming <[email protected]>
---
include/linux/sunrpc/svc.h | 7 -------
1 file changed, 7 deletions(-)

diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index daecb009c05b..6990867470ca 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -220,13 +220,6 @@ static inline __be32 svc_getu32(struct kvec *iov)
return val;
}

-static inline void svc_ungetu32(struct kvec *iov)
-{
- __be32 *vp = (__be32 *)iov->iov_base;
- iov->iov_base = (void *)(vp - 1);
- iov->iov_len += sizeof(*vp);
-}
-
static inline void svc_putu32(struct kvec *iov, __be32 val)
{
__be32 *vp = iov->iov_base + iov->iov_len;
--
2.18.2

2022-11-04 13:46:00

by Chuck Lever III

Subject: Re: [PATCH] sunrpc: svc: Remove an unused static function svc_ungetu32()

> On Nov 3, 2022, at 9:43 PM, Li zeming <[email protected]> wrote:
>
> The svc_ungetu32 function is not used, you could remove it.
>
> Signed-off-by: Li zeming <[email protected]>

Applied to nfsd's for-next. Thanks!


> ---
> include/linux/sunrpc/svc.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..6990867470ca 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -220,13 +220,6 @@ static inline __be32 svc_getu32(struct kvec *iov)
> return val;
> }
>
> -static inline void svc_ungetu32(struct kvec *iov)
> -{
> - __be32 *vp = (__be32 *)iov->iov_base;
> - iov->iov_base = (void *)(vp - 1);
> - iov->iov_len += sizeof(*vp);
> -}
> -
> static inline void svc_putu32(struct kvec *iov, __be32 val)
> {
> __be32 *vp = iov->iov_base + iov->iov_len;
> --
> 2.18.2
>

--
Chuck Lever