2023-07-29 12:37:24

by Yue Haibing

Subject: [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()

rpcrdma_bc_post_recv() is never implemented since introduction in
commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").

Signed-off-by: Yue Haibing <[email protected]>
---
net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
index 5e5ff6784ef5..da409450dfc0 100644
--- a/net/sunrpc/xprtrdma/xprt_rdma.h
+++ b/net/sunrpc/xprtrdma/xprt_rdma.h
@@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
-int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
--
2.34.1

2023-08-01 20:25:14

by Anna Schumaker

Subject: Re: [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()

On Sun, Jul 30, 2023 at 12:01 PM Chuck Lever <[email protected]> wrote:
>
> On Sat, Jul 29, 2023 at 08:31:52PM +0800, Yue Haibing wrote:
> > rpcrdma_bc_post_recv() is never implemented since introduction in
> > commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send/receive buffers").
> >
> > Signed-off-by: Yue Haibing <[email protected]>
>
> Reviewed-by: Chuck Lever <[email protected]>
>
> Anna, can you take this one?

Yep! Applying it now so it doesn't get lost!

Anna

>
>
> > ---
> > net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h
> > index 5e5ff6784ef5..da409450dfc0 100644
> > --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> > +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> > @@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
> > int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
> > size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
> > unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
> > -int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
> > void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep *);
> > int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
> > void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
> > --
> > 2.34.1
> >
>
> --
> Chuck Lever