2022-10-26 08:49:55

by Ondrej Valousek

Subject: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h

Hi kernel maintainers,

Please help to submit the following patch into kernel
---
Signed-off-by: Ondrej Valousek <[email protected]>
Short description:

The XATTR_NAME_NFSV4_ACL definition is also useful for userspace (i.e. nfs4_acl_tools/libacl/coreutils) so makes a sense to move the definition to the linux/xattr.h


diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index e2efcd26336c..07c3d8572912 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -7680,8 +7680,6 @@ nfs4_release_lockowner(struct nfs_server *server, struct nfs4_lock_state *lsp)
rpc_call_async(server->client, &msg, 0, &nfs4_release_lockowner_ops, data);
}

-#define XATTR_NAME_NFSV4_ACL "system.nfs4_acl"
-
static int nfs4_xattr_set_nfs4_acl(const struct xattr_handler *handler,
struct user_namespace *mnt_userns,
struct dentry *unused, struct inode *inode,
diff --git a/include/uapi/linux/xattr.h b/include/uapi/linux/xattr.h
index 9463db2dfa9d..77eb8c885861 100644
--- a/include/uapi/linux/xattr.h
+++ b/include/uapi/linux/xattr.h
@@ -81,5 +81,7 @@
#define XATTR_POSIX_ACL_DEFAULT "posix_acl_default"
#define XATTR_NAME_POSIX_ACL_DEFAULT XATTR_SYSTEM_PREFIX XATTR_POSIX_ACL_DEFAULT

+#define XATTR_NFSV4_ACL "nfs4_acl"
+#define XATTR_NAME_NFSV4_ACL XATTR_SYSTEM_PREFIX XATTR_NFSV4_ACL

#endif /* _UAPI_LINUX_XATTR_H */

2022-10-26 13:41:31

by Chuck Lever

Subject: Re: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h

> On Oct 26, 2022, at 4:48 AM, Ondrej Valousek <[email protected]> wrote:
>
> Hi kernel maintainers,
>
> Please help to submit the following patch into kernel
> ---
> Signed-off-by: Ondrej Valousek <[email protected]>
> Short description:
>
> The XATTR_NAME_NFSV4_ACL definition is also useful for userspace (i.e. nfs4_acl_tools/libacl/coreutils) so makes a sense to move the definition to the linux/xattr.h

Hey Ondrej!

Let's start by copying the correct maintainers for these files
so the patch gets proper review:

$ scripts/get_maintainer.pl include/uapi/linux/xattr.h
[email protected] (open list)
$ scripts/get_maintainer.pl fs/nfs/nfs4proc.c
Trond Myklebust <[email protected]> (maintainer:NFS, SUNRPC, AND LOCKD CLIENTS)
Anna Schumaker <[email protected]> (maintainer:NFS, SUNRPC, AND LOCKD CLIENTS)
[email protected] (open list:NFS, SUNRPC, AND LOCKD CLIENTS)
[email protected] (open list)
$

Can you update the To/Cc and repost?


> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index e2efcd26336c..07c3d8572912 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -7680,8 +7680,6 @@ nfs4_release_lockowner(struct nfs_server *server, struct nfs4_lock_state *lsp)
> rpc_call_async(server->client, &msg, 0, &nfs4_release_lockowner_ops, data);
> }
>
> -#define XATTR_NAME_NFSV4_ACL "system.nfs4_acl"
> -
> static int nfs4_xattr_set_nfs4_acl(const struct xattr_handler *handler,
> struct user_namespace *mnt_userns,
> struct dentry *unused, struct inode *inode,
> diff --git a/include/uapi/linux/xattr.h b/include/uapi/linux/xattr.h
> index 9463db2dfa9d..77eb8c885861 100644
> --- a/include/uapi/linux/xattr.h
> +++ b/include/uapi/linux/xattr.h
> @@ -81,5 +81,7 @@
> #define XATTR_POSIX_ACL_DEFAULT "posix_acl_default"
> #define XATTR_NAME_POSIX_ACL_DEFAULT XATTR_SYSTEM_PREFIX XATTR_POSIX_ACL_DEFAULT
>
> +#define XATTR_NFSV4_ACL "nfs4_acl"
> +#define XATTR_NAME_NFSV4_ACL XATTR_SYSTEM_PREFIX XATTR_NFSV4_ACL
>
> #endif /* _UAPI_LINUX_XATTR_H */

--
Chuck Lever