2020-06-28 09:37:57

by Salvatore Bonaccorso

Subject: [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces

Although whitespaces immediately before or after the "=" are ignored,
removing the extra whitespaces in some of the key=value assignments
makes the style more consistent.

At least since systemd v242-rc1[1] this has been clarified that
whitespaces immediately before and after the "=" are allowed.

[1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0

Signed-off-by: Salvatore Bonaccorso <[email protected]>
---
systemd/nfs-server.service | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
index 24118d693965..06c1adb71692 100644
--- a/systemd/nfs-server.service
+++ b/systemd/nfs-server.service
@@ -1,18 +1,18 @@
[Unit]
Description=NFS server and services
DefaultDependencies=no
-Requires= network.target proc-fs-nfsd.mount
-Requires= nfs-mountd.service
+Requires=network.target proc-fs-nfsd.mount
+Requires=nfs-mountd.service
Wants=rpcbind.socket network-online.target
Wants=rpc-statd.service nfs-idmapd.service
Wants=rpc-statd-notify.service
Wants=nfsdcld.service

-After= network-online.target local-fs.target
-After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
-After= nfs-idmapd.service rpc-statd.service
-After= nfsdcld.service
-Before= rpc-statd-notify.service
+After=network-online.target local-fs.target
+After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
+After=nfs-idmapd.service rpc-statd.service
+After=nfsdcld.service
+Before=rpc-statd-notify.service

# GSS services dependencies and ordering
Wants=auth-rpcgss-module.service
--
2.27.0

2020-07-17 13:57:56

by Steve Dickson

Subject: Re: [PATCH] nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces

On 6/28/20 5:24 AM, Salvatore Bonaccorso wrote:
> Although whitespaces immediately before or after the "=" are ignored,
> removing the extra whitespaces in some of the key=value assignments
> makes the style more consistent.
>
> At least since systemd v242-rc1[1] this has been clarified that
> whitespaces immediately before and after the "=" are allowed.
>
> [1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0
>
> Signed-off-by: Salvatore Bonaccorso <[email protected]>
Committed... (tag: nfs-utils-2-5-2-rc2)

steved.
> ---
> systemd/nfs-server.service | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index 24118d693965..06c1adb71692 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -1,18 +1,18 @@
> [Unit]
> Description=NFS server and services
> DefaultDependencies=no
> -Requires= network.target proc-fs-nfsd.mount
> -Requires= nfs-mountd.service
> +Requires=network.target proc-fs-nfsd.mount
> +Requires=nfs-mountd.service
> Wants=rpcbind.socket network-online.target
> Wants=rpc-statd.service nfs-idmapd.service
> Wants=rpc-statd-notify.service
> Wants=nfsdcld.service
>
> -After= network-online.target local-fs.target
> -After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> -After= nfs-idmapd.service rpc-statd.service
> -After= nfsdcld.service
> -Before= rpc-statd-notify.service
> +After=network-online.target local-fs.target
> +After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> +After=nfs-idmapd.service rpc-statd.service
> +After=nfsdcld.service
> +Before=rpc-statd-notify.service
>
> # GSS services dependencies and ordering
> Wants=auth-rpcgss-module.service
>