2022-09-20 00:04:08

by Rosen Penev

Subject: [PATCH] libtirpc: add missing extern

Fixes compilation warning.

Signed-off-by: Rosen Penev <[email protected]>
---
src/svc_auth.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/src/svc_auth.c b/src/svc_auth.c
index ce8bbd8..789d6af 100644
--- a/src/svc_auth.c
+++ b/src/svc_auth.c
@@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;

extern SVCAUTH svc_auth_none;

+#ifdef AUTHDES_SUPPORT
+extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
+#endif
/*
* The call rpc message, msg has been obtained from the wire. The msg contains
* the raw form of credentials and verifiers. authenticate returns AUTH_OK
--
2.37.3

2022-09-20 19:47:21

by Steve Dickson

Subject: Re: [PATCH] libtirpc: add missing extern

On 9/19/22 7:59 PM, Rosen Penev wrote:
> Fixes compilation warning.
What was the warning? Plus AUTH_DES is no longer supported.

steved.
>
> Signed-off-by: Rosen Penev <[email protected]>
> ---
> src/svc_auth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/svc_auth.c b/src/svc_auth.c
> index ce8bbd8..789d6af 100644
> --- a/src/svc_auth.c
> +++ b/src/svc_auth.c
> @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
>
> extern SVCAUTH svc_auth_none;
>
> +#ifdef AUTHDES_SUPPORT
> +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> +#endif
> /*
> * The call rpc message, msg has been obtained from the wire. The msg contains
> * the raw form of credentials and verifiers. authenticate returns AUTH_OK

2022-09-20 20:33:54

by Rosen Penev

Subject: Re: [PATCH] libtirpc: add missing extern

On Tue, Sep 20, 2022 at 12:28 PM Steve Dickson <[email protected]> wrote:
>
>
>
> On 9/19/22 7:59 PM, Rosen Penev wrote:
> > Fixes compilation warning.
> What was the warning? Plus AUTH_DES is no longer supported.
Implicit function declaration as it's not in a header file or anything.

I found the issue from doing a meson conversion for libtirpc:
https://github.com/mesonbuild/wrapdb/pull/644

I have no idea about AUTH_DES or what it's used for.
>
> steved.
> >
> > Signed-off-by: Rosen Penev <[email protected]>
> > ---
> > src/svc_auth.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/src/svc_auth.c b/src/svc_auth.c
> > index ce8bbd8..789d6af 100644
> > --- a/src/svc_auth.c
> > +++ b/src/svc_auth.c
> > @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
> >
> > extern SVCAUTH svc_auth_none;
> >
> > +#ifdef AUTHDES_SUPPORT
> > +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> > +#endif
> > /*
> > * The call rpc message, msg has been obtained from the wire. The msg contains
> > * the raw form of credentials and verifiers. authenticate returns AUTH_OK
>

2022-10-24 21:53:49

by Rosen Penev

Subject: Re: [PATCH] libtirpc: add missing extern

On Tue, Sep 20, 2022 at 1:31 PM Rosen Penev <[email protected]> wrote:
>
> On Tue, Sep 20, 2022 at 12:28 PM Steve Dickson <[email protected]> wrote:
> >
> >
> >
> > On 9/19/22 7:59 PM, Rosen Penev wrote:
> > > Fixes compilation warning.
> > What was the warning? Plus AUTH_DES is no longer supported.
> Implicit function declaration as it's not in a header file or anything.
>
> I found the issue from doing a meson conversion for libtirpc:
> https://github.com/mesonbuild/wrapdb/pull/644
>
> I have no idea about AUTH_DES or what it's used for.
ping.
> >
> > steved.
> > >
> > > Signed-off-by: Rosen Penev <[email protected]>
> > > ---
> > > src/svc_auth.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/src/svc_auth.c b/src/svc_auth.c
> > > index ce8bbd8..789d6af 100644
> > > --- a/src/svc_auth.c
> > > +++ b/src/svc_auth.c
> > > @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
> > >
> > > extern SVCAUTH svc_auth_none;
> > >
> > > +#ifdef AUTHDES_SUPPORT
> > > +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> > > +#endif
> > > /*
> > > * The call rpc message, msg has been obtained from the wire. The msg contains
> > > * the raw form of credentials and verifiers. authenticate returns AUTH_OK
> >

2022-10-25 16:43:29

by Steve Dickson

Subject: Re: [PATCH] libtirpc: add missing extern

On 9/19/22 7:59 PM, Rosen Penev wrote:
> Fixes compilation warning.
>
> Signed-off-by: Rosen Penev <[email protected]>
Committed...

steved.
> ---
> src/svc_auth.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/svc_auth.c b/src/svc_auth.c
> index ce8bbd8..789d6af 100644
> --- a/src/svc_auth.c
> +++ b/src/svc_auth.c
> @@ -66,6 +66,9 @@ static struct authsvc *Auths = NULL;
>
> extern SVCAUTH svc_auth_none;
>
> +#ifdef AUTHDES_SUPPORT
> +extern enum auth_stat _svcauth_des(struct svc_req *rqst, struct rpc_msg *msg);
> +#endif
> /*
> * The call rpc message, msg has been obtained from the wire. The msg contains
> * the raw form of credentials and verifiers. authenticate returns AUTH_OK