On Tue, 8 May 2007, Satyam Sharma wrote:
> > CC init/version.o
> > LD init/built-in.o
> > LD .tmp_vmlinux1
> > net/built-in.o: In function `hidp_add_connection':
> > (.text+0x8bb08): undefined reference to `hid_ff_init'
> > make: *** [.tmp_vmlinux1] Error 1
> You've got CONFIG_BT_HIDP=y there but CONFIG_USB_HID=m. The trivial
> patch below solves it. To test, you can just "make oldconfig" on the
> same .config that broke above and then proceed to make bzImage.
I'd say we need a different fix here. First, the question is whether there
are any force-feedback devices, supported by USBHID force-feedback layer,
which have a bluetooth version?
If there are none of them, we could just drop the FF initialization
completely for now.
On the other hand if there are such devices, just calling hid_ff_init() is
presently not enough anyway, as the force feedback drivers for HID devices
are currently USB-transport specific.
--
Jiri Kosina
Hi Jiri,
> > > Marcel - are you aware of any devices currently supported by USB HID
> > > force-feedback code, which have a bluetooth version, please?
> > I haven't looked at all details for the PS3 controller, but that might
> > be the first one. In theory they can and at some point they will enter
> > the market.
>
> You are right, PS3 controller is going to be shipped in both variants. On
> the other hand it is perfectly possible that we will need special
> force-feedback driver for it anyway.
>
> BTW when talking about this - we already have PS3 quirk present in usb hid
> (extra control URB is required to make it operational), probably something
> similar will be needed for BT version too.
I know, but we do that in user space before we hand over the control to
the kernel. It is simpler, because it is on the control channel and that
part is not nicely integrated into the HID subsystem to be used by the
transport layers right now. At least as far as I can tell.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On Tue, 8 May 2007, Marcel Holtmann wrote:
> > Marcel - are you aware of any devices currently supported by USB HID
> > force-feedback code, which have a bluetooth version, please?
> I haven't looked at all details for the PS3 controller, but that might
> be the first one. In theory they can and at some point they will enter
> the market.
You are right, PS3 controller is going to be shipped in both variants. On
the other hand it is perfectly possible that we will need special
force-feedback driver for it anyway.
BTW when talking about this - we already have PS3 quirk present in usb hid
(extra control URB is required to make it operational), probably something
similar will be needed for BT version too.
> > From: Jiri Kosina <[email protected]>
> > [Bluetooth] HIDP - don't initialize force feedback
> > The current implementation of force feedback for HID devices is
> > USB-transport only and therefore calling hid_ff_init() from hidp code is
> > not going to work (plus it creates unwanted dependency of hidp on usbhid).
> > Remove the hid_ff_init() until either the hid-ff is made
> > transport-independent, or at least support for bluetooth transport is
> > added.
> > Signed-off-by: Jiri Kosina <[email protected]>
> Signed-off-by: Marcel Holtmann <[email protected]>
> Under the condition that you remember to put it back once a generic FF
> exists.
Sure. I will take this through my tree then, thanks.
--
Jiri Kosina
Hi Jiri,
> > Sure, my aim here was to only solve the _build breakage_ by fixing the
> > Kconfig for this module (that used code from another kernel module
> > without listing it in its dependencies). If, as you say, the real
> > solution is that we should actually be taking out the offending call to
> > the other module itself, then please go ahead -- I don't know much about
> > the Bluetooth / HIDP subsytem anyway.
>
> Converting the hid-ff drivers to be also transport-independent is on my
> TODO list, but it didn't happen yet.
>
> Marcel - are you aware of any devices currently supported by USB HID
> force-feedback code, which have a bluetooth version, please?
I haven't looked at all details for the PS3 controller, but that might
be the first one. In theory they can and at some point they will enter
the market.
> I'd propose the patch below, until I make the usbhid force-feedback code
> transport independent. Thanks.
>
>
>
> From: Jiri Kosina <[email protected]>
>
> [Bluetooth] HIDP - don't initialize force feedback
>
> The current implementation of force feedback for HID devices is
> USB-transport only and therefore calling hid_ff_init() from hidp code is
> not going to work (plus it creates unwanted dependency of hidp on usbhid).
> Remove the hid_ff_init() until either the hid-ff is made
> transport-independent, or at least support for bluetooth transport is
> added.
>
> Signed-off-by: Jiri Kosina <[email protected]>
Signed-off-by: Marcel Holtmann <[email protected]>
Under the condition that you remember to put it back once a generic FF
exists.
Regards
Marcel
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bluez-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel
On Tue, 8 May 2007, Satyam Sharma wrote:
> Sure, my aim here was to only solve the _build breakage_ by fixing the
> Kconfig for this module (that used code from another kernel module
> without listing it in its dependencies). If, as you say, the real
> solution is that we should actually be taking out the offending call to
> the other module itself, then please go ahead -- I don't know much about
> the Bluetooth / HIDP subsytem anyway.
Converting the hid-ff drivers to be also transport-independent is on my
TODO list, but it didn't happen yet.
Marcel - are you aware of any devices currently supported by USB HID
force-feedback code, which have a bluetooth version, please?
I'd propose the patch below, until I make the usbhid force-feedback code
transport independent. Thanks.
From: Jiri Kosina <[email protected]>
[Bluetooth] HIDP - don't initialize force feedback
The current implementation of force feedback for HID devices is
USB-transport only and therefore calling hid_ff_init() from hidp code is
not going to work (plus it creates unwanted dependency of hidp on usbhid).
Remove the hid_ff_init() until either the hid-ff is made
transport-independent, or at least support for bluetooth transport is
added.
Signed-off-by: Jiri Kosina <[email protected]>
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index d342e89..3e77e81 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -737,10 +737,8 @@ static inline void hidp_setup_hid(struct
list_for_each_entry(report, &hid->report_enum[HID_FEATURE_REPORT].report_list, list)
hidp_send_report(session, report);
- if (hidinput_connect(hid) == 0) {
+ if (hidinput_connect(hid) == 0)
hid->claimed |= HID_CLAIMED_INPUT;
- hid_ff_init(hid);
- }
}
int hidp_add_connection(struct hidp_connadd_req *req, struct socket *ctrl_sock, struct socket *intr_sock)
Hi Jiri,
On 5/8/07, Jiri Kosina <[email protected]> wrote:
> On Tue, 8 May 2007, Satyam Sharma wrote:
>
> > > CC init/version.o
> > > LD init/built-in.o
> > > LD .tmp_vmlinux1
> > > net/built-in.o: In function `hidp_add_connection':
> > > (.text+0x8bb08): undefined reference to `hid_ff_init'
> > > make: *** [.tmp_vmlinux1] Error 1
> > You've got CONFIG_BT_HIDP=y there but CONFIG_USB_HID=m. The trivial
> > patch below solves it. To test, you can just "make oldconfig" on the
> > same .config that broke above and then proceed to make bzImage.
>
> I'd say we need a different fix here. First, the question is whether there
> are any force-feedback devices, supported by USBHID force-feedback layer,
> which have a bluetooth version?
>
> If there are none of them, we could just drop the FF initialization
> completely for now.
>
> On the other hand if there are such devices, just calling hid_ff_init() is
> presently not enough anyway, as the force feedback drivers for HID devices
> are currently USB-transport specific.
Sure, my aim here was to only solve the _build breakage_ by fixing the
Kconfig for this module (that used code from another kernel module
without listing it in its dependencies). If, as you say, the real
solution is that we should actually be taking out the offending call
to the other module itself, then please go ahead -- I don't know much
about the Bluetooth / HIDP subsytem anyway.
Thanks,
Satyam