2018-01-23 02:08:56

by Wei Yongjun

Subject: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static

Fixes the following sparse warnings:

drivers/char/hw_random/imx-rngc.c:303:1: warning:
symbol 'imx_rngc_pm_ops' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/char/hw_random/imx-rngc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index eca8724..250123b 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
return 0;
}

-SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
+static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);

static const struct of_device_id imx_rngc_dt_ids[] = {
{ .compatible = "fsl,imx25-rngb", .data = NULL, },

2018-01-23 09:09:48

by Martin Kaiser

Subject: Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static

Thus wrote Wei Yongjun ([email protected]):

> Fixes the following sparse warnings:

> drivers/char/hw_random/imx-rngc.c:303:1: warning:
> symbol 'imx_rngc_pm_ops' was not declared. Should it be static?

> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/char/hw_random/imx-rngc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
> index eca8724..250123b 100644
> --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -300,7 +300,7 @@ static int __maybe_unused imx_rngc_resume(struct device *dev)
> return 0;
> }

> -SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);
> +static SIMPLE_DEV_PM_OPS(imx_rngc_pm_ops, imx_rngc_suspend, imx_rngc_resume);

> static const struct of_device_id imx_rngc_dt_ids[] = {
> { .compatible = "fsl,imx25-rngb", .data = NULL, },


You're right. The vast majority of other drivers uses a
static SIMPLE_DEV_PM_OPS(), so should we.

Reviewed-by: Martin Kaiser <[email protected]>

2018-02-15 15:42:21

by Herbert Xu

Subject: Re: [PATCH -next] hwrng: make symbol imx_rngc_pm_ops static

On Tue, Jan 23, 2018 at 02:08:56AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warnings:
>
> drivers/char/hw_random/imx-rngc.c:303:1: warning:
> symbol 'imx_rngc_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt