LinuxLists.cc - [PATCH 0/7] crypto: cleanup debugfs usage

2019-01-22 15:14:29

Subject: [PATCH 0/7] crypto: cleanup debugfs usage

When calling debugfs code, there is no need to ever check the return
value of the call, as no logic should ever change if a call works
properly or not. Fix up a bunch of crypto-specific code to not care
about the results of debugfs.

Greg Kroah-Hartman (7):
crypto: qat: no need to check return value of debugfs_create functions
crypto: ccrree: no need to check return value of debugfs_create
functions
crypto: axis: no need to check return value of debugfs_create
functions
crypto: cavium: zip: no need to check return value of debugfs_create
functions
crypto: cavium: nitrox: no need to check return value of
debugfs_create functions
crypto: ccp: no need to check return value of debugfs_create functions
crypto: caam: no need to check return value of debugfs_create
functions

drivers/crypto/axis/artpec6_crypto.c | 9 ----
drivers/crypto/caam/ctrl.c | 21 +++-----
drivers/crypto/caam/intern.h | 1 -
drivers/crypto/cavium/nitrox/nitrox_debugfs.c | 27 ++--------
drivers/crypto/cavium/nitrox/nitrox_debugfs.h | 5 +-
drivers/crypto/cavium/nitrox/nitrox_main.c | 4 +-
drivers/crypto/cavium/zip/zip_main.c | 52 ++++---------------
drivers/crypto/ccp/ccp-debugfs.c | 36 +++----------
drivers/crypto/ccree/cc_debugfs.c | 22 ++------
drivers/crypto/ccree/cc_debugfs.h | 8 +--
drivers/crypto/ccree/cc_driver.c | 7 +--
drivers/crypto/qat/qat_c3xxx/adf_drv.c | 5 --
drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 5 --
drivers/crypto/qat/qat_c62x/adf_drv.c | 5 --
drivers/crypto/qat/qat_c62xvf/adf_drv.c | 5 --
drivers/crypto/qat/qat_common/adf_cfg.c | 7 ---
drivers/crypto/qat/qat_common/adf_transport.c | 6 ---
.../qat/qat_common/adf_transport_debug.c | 15 ------
drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 5 --
drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 5 --
20 files changed, 38 insertions(+), 212 deletions(-)

--
2.20.1

2019-01-22 15:14:38

by Greg Kroah-Hartman

[permalink] [raw]

Subject: [PATCH 1/7] crypto: qat: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value. The function can work or not, but the code logic should
never do something different based on this.

Cc: Giovanni Cabiddu <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Conor McLoughlin <[email protected]>
Cc: Waiman Long <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/crypto/qat/qat_c3xxx/adf_drv.c | 5 -----
drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 5 -----
drivers/crypto/qat/qat_c62x/adf_drv.c | 5 -----
drivers/crypto/qat/qat_c62xvf/adf_drv.c | 5 -----
drivers/crypto/qat/qat_common/adf_cfg.c | 7 -------
drivers/crypto/qat/qat_common/adf_transport.c | 6 ------
.../crypto/qat/qat_common/adf_transport_debug.c | 15 ---------------
drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 5 -----
drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 5 -----
9 files changed, 58 deletions(-)

diff --git a/drivers/crypto/qat/qat_c3xxx/adf_drv.c b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
index 763c2166ee0e..d937cc7248a5 100644
--- a/drivers/crypto/qat/qat_c3xxx/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxx/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
PCI_FUNC(pdev->devfn));

accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
- if (!accel_dev->debugfs_dir) {
- dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
- ret = -EINVAL;
- goto out_err;
- }

/* Create device configuration table */
ret = adf_cfg_dev_add(accel_dev);
diff --git a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
index 613c7d5644ce..1dc5ac859f7b 100644
--- a/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c3xxxvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
PCI_FUNC(pdev->devfn));

accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
- if (!accel_dev->debugfs_dir) {
- dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
- ret = -EINVAL;
- goto out_err;
- }

/* Create device configuration table */
ret = adf_cfg_dev_add(accel_dev);
diff --git a/drivers/crypto/qat/qat_c62x/adf_drv.c b/drivers/crypto/qat/qat_c62x/adf_drv.c
index 9cb832963357..2bc06c89d2fe 100644
--- a/drivers/crypto/qat/qat_c62x/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62x/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
PCI_FUNC(pdev->devfn));

accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
- if (!accel_dev->debugfs_dir) {
- dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
- ret = -EINVAL;
- goto out_err;
- }

/* Create device configuration table */
ret = adf_cfg_dev_add(accel_dev);
diff --git a/drivers/crypto/qat/qat_c62xvf/adf_drv.c b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
index 278452b8ef81..a68358b31292 100644
--- a/drivers/crypto/qat/qat_c62xvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_c62xvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
PCI_FUNC(pdev->devfn));

accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
- if (!accel_dev->debugfs_dir) {
- dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
- ret = -EINVAL;
- goto out_err;
- }

/* Create device configuration table */
ret = adf_cfg_dev_add(accel_dev);
diff --git a/drivers/crypto/qat/qat_common/adf_cfg.c b/drivers/crypto/qat/qat_common/adf_cfg.c
index d0879790561f..5c7fdb0fc53d 100644
--- a/drivers/crypto/qat/qat_common/adf_cfg.c
+++ b/drivers/crypto/qat/qat_common/adf_cfg.c
@@ -141,13 +141,6 @@ int adf_cfg_dev_add(struct adf_accel_dev *accel_dev)
accel_dev->debugfs_dir,
dev_cfg_data,
&qat_dev_cfg_fops);
- if (!dev_cfg_data->debug) {
- dev_err(&GET_DEV(accel_dev),
- "Failed to create qat cfg debugfs entry.\n");
- kfree(dev_cfg_data);
- accel_dev->cfg = NULL;
- return -EFAULT;
- }
return 0;
}
EXPORT_SYMBOL_GPL(adf_cfg_dev_add);
diff --git a/drivers/crypto/qat/qat_common/adf_transport.c b/drivers/crypto/qat/qat_common/adf_transport.c
index 57d2622728a5..ac658ce46836 100644
--- a/drivers/crypto/qat/qat_common/adf_transport.c
+++ b/drivers/crypto/qat/qat_common/adf_transport.c
@@ -486,12 +486,6 @@ int adf_init_etr_data(struct adf_accel_dev *accel_dev)
/* accel_dev->debugfs_dir should always be non-NULL here */
etr_data->debug = debugfs_create_dir("transport",
accel_dev->debugfs_dir);
- if (!etr_data->debug) {
- dev_err(&GET_DEV(accel_dev),
- "Unable to create transport debugfs entry\n");
- ret = -ENOENT;
- goto err_bank_debug;
- }

for (i = 0; i < num_banks; i++) {
ret = adf_init_bank(accel_dev, &etr_data->banks[i], i,
diff --git a/drivers/crypto/qat/qat_common/adf_transport_debug.c b/drivers/crypto/qat/qat_common/adf_transport_debug.c
index 52340b9bb387..e794e9d97b2c 100644
--- a/drivers/crypto/qat/qat_common/adf_transport_debug.c
+++ b/drivers/crypto/qat/qat_common/adf_transport_debug.c
@@ -163,11 +163,6 @@ int adf_ring_debugfs_add(struct adf_etr_ring_data *ring, const char *name)
ring_debug->debug = debugfs_create_file(entry_name, S_IRUSR,
ring->bank->bank_debug_dir,
ring, &adf_ring_debug_fops);
- if (!ring_debug->debug) {
- pr_err("QAT: Failed to create ring debug entry.\n");
- kfree(ring_debug);
- return -EFAULT;
- }
ring->ring_debug = ring_debug;
return 0;
}
@@ -271,19 +266,9 @@ int adf_bank_debugfs_add(struct adf_etr_bank_data *bank)

snprintf(name, sizeof(name), "bank_%02d", bank->bank_number);
bank->bank_debug_dir = debugfs_create_dir(name, parent);
- if (!bank->bank_debug_dir) {
- pr_err("QAT: Failed to create bank debug dir.\n");
- return -EFAULT;
- }
-
bank->bank_debug_cfg = debugfs_create_file("config", S_IRUSR,
bank->bank_debug_dir, bank,
&adf_bank_debug_fops);
- if (!bank->bank_debug_cfg) {
- pr_err("QAT: Failed to create bank debug entry.\n");
- debugfs_remove(bank->bank_debug_dir);
- return -EFAULT;
- }
return 0;
}

diff --git a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
index 3a9708ef4ce2..b11bf8c0e683 100644
--- a/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xcc/adf_drv.c
@@ -193,11 +193,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
PCI_FUNC(pdev->devfn));

accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
- if (!accel_dev->debugfs_dir) {
- dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
- ret = -EINVAL;
- goto out_err;
- }

/* Create device configuration table */
ret = adf_cfg_dev_add(accel_dev);
diff --git a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
index 3da0f951cb59..1b762eefc6c1 100644
--- a/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
+++ b/drivers/crypto/qat/qat_dh895xccvf/adf_drv.c
@@ -177,11 +177,6 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
PCI_FUNC(pdev->devfn));

accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
- if (!accel_dev->debugfs_dir) {
- dev_err(&pdev->dev, "Could not create debugfs dir %s\n", name);
- ret = -EINVAL;
- goto out_err;
- }

/* Create device configuration table */
ret = adf_cfg_dev_add(accel_dev);
--
2.20.1

2019-01-22 15:14:50

by Greg Kroah-Hartman

[permalink] [raw]

Subject: [PATCH 5/7] crypto: cavium: nitrox: no need to check return value of debugfs_create functions

2019-01-22 15:15:01

by Greg Kroah-Hartman

[permalink] [raw]

Subject: [PATCH 7/7] crypto: caam: no need to check return value of debugfs_create functions

2019-01-22 15:15:05

by Greg Kroah-Hartman

[permalink] [raw]

Subject: [PATCH 6/7] crypto: ccp: no need to check return value of debugfs_create functions

2019-01-22 15:15:09

by Greg Kroah-Hartman

[permalink] [raw]

Subject: [PATCH 4/7] crypto: cavium: zip: no need to check return value of debugfs_create functions

2019-01-22 15:15:13

by Greg Kroah-Hartman

[permalink] [raw]

Subject: [PATCH 3/7] crypto: axis: no need to check return value of debugfs_create functions

2019-01-22 15:15:16

by Greg Kroah-Hartman

[permalink] [raw]

Subject: [PATCH 2/7] crypto: ccrree: no need to check return value of debugfs_create functions

2019-01-22 15:29:17

by Horia Geanta

[permalink] [raw]

Subject: Re: [PATCH 7/7] crypto: caam: no need to check return value of debugfs_create functions

On 1/22/2019 5:14 PM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: "Horia Geant?" <[email protected]>
> Cc: Aymen Sghaier <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Reviewed-by: Horia Geant? <[email protected]>

Thanks,
Horia

2019-01-22 22:07:05

by Gary R Hook

[permalink] [raw]

Subject: Re: [PATCH 6/7] crypto: ccp: no need to check return value of debugfs_create functions

On 1/22/19 9:14 AM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.

Stupid question(s) time.

If we don't care about failures (because the subsystem handles them
without our involvement) why do these functions even have return values?
Why haven't they been changed to void so that they reflect the current
style of intended use?

I realize I'm old fashioned, but if a failure occurs, I've always been
of a mind to kick out and not try to do any further work. But debugfs is
to be treated as an exception to that paradigm? Carry on, ignore errors,
don't worry about it?

That said,

Acked-by: Gary R Hook <[email protected]>

>
> Cc: Tom Lendacky <[email protected]>
> Cc: Gary Hook <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/crypto/ccp/ccp-debugfs.c | 36 +++++++-------------------------
> 1 file changed, 7 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-debugfs.c b/drivers/crypto/ccp/ccp-debugfs.c
> index 1a734bd2070a..4bd26af7098d 100644
> --- a/drivers/crypto/ccp/ccp-debugfs.c
> +++ b/drivers/crypto/ccp/ccp-debugfs.c
> @@ -286,10 +286,7 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
> {
> struct ccp_cmd_queue *cmd_q;
> char name[MAX_NAME_LEN + 1];
> - struct dentry *debugfs_info;
> - struct dentry *debugfs_stats;
> struct dentry *debugfs_q_instance;
> - struct dentry *debugfs_q_stats;
> int i;
>
> if (!debugfs_initialized())
> @@ -299,24 +296,14 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
> if (!ccp_debugfs_dir)
> ccp_debugfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
> mutex_unlock(&ccp_debugfs_lock);
> - if (!ccp_debugfs_dir)
> - return;
>
> ccp->debugfs_instance = debugfs_create_dir(ccp->name, ccp_debugfs_dir);
> - if (!ccp->debugfs_instance)
> - goto err;
>
> - debugfs_info = debugfs_create_file("info", 0400,
> - ccp->debugfs_instance, ccp,
> - &ccp_debugfs_info_ops);
> - if (!debugfs_info)
> - goto err;
> + debugfs_create_file("info", 0400, ccp->debugfs_instance, ccp,
> + &ccp_debugfs_info_ops);
>
> - debugfs_stats = debugfs_create_file("stats", 0600,
> - ccp->debugfs_instance, ccp,
> - &ccp_debugfs_stats_ops);
> - if (!debugfs_stats)
> - goto err;
> + debugfs_create_file("stats", 0600, ccp->debugfs_instance, ccp,
> + &ccp_debugfs_stats_ops);
>
> for (i = 0; i < ccp->cmd_q_count; i++) {
> cmd_q = &ccp->cmd_q[i];
> @@ -325,21 +312,12 @@ void ccp5_debugfs_setup(struct ccp_device *ccp)
>
> debugfs_q_instance =
> debugfs_create_dir(name, ccp->debugfs_instance);
> - if (!debugfs_q_instance)
> - goto err;
> -
> - debugfs_q_stats =
> - debugfs_create_file("stats", 0600,
> - debugfs_q_instance, cmd_q,
> - &ccp_debugfs_queue_ops);
> - if (!debugfs_q_stats)
> - goto err;
> +
> + debugfs_create_file("stats", 0600, debugfs_q_instance, cmd_q,
> + &ccp_debugfs_queue_ops);
> }
>
> return;
> -
> -err:
> - debugfs_remove_recursive(ccp->debugfs_instance);
> }
>
> void ccp5_debugfs_destroy(void)
>

2019-01-23 06:56:00

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH 6/7] crypto: ccp: no need to check return value of debugfs_create functions

On Tue, Jan 22, 2019 at 10:06:54PM +0000, Gary R Hook wrote:
> On 1/22/19 9:14 AM, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
>
> Stupid question(s) time.
>
> If we don't care about failures (because the subsystem handles them
> without our involvement) why do these functions even have return values?
> Why haven't they been changed to void so that they reflect the current
> style of intended use?

Because on "normal" operations, you use the return value for something
(i.e. a parent directory to pass to other functions, or a value so you
can remove the file later).

> I realize I'm old fashioned, but if a failure occurs, I've always been
> of a mind to kick out and not try to do any further work. But debugfs is
> to be treated as an exception to that paradigm? Carry on, ignore errors,
> don't worry about it?

Yes, that is the case here, it goes against what everyone normally
thinks about kernel development :)

thanks,

greg k-h

2019-01-23 07:37:23

by Lars Persson

[permalink] [raw]

Subject: Re: [PATCH 3/7] crypto: axis: no need to check return value of debugfs_create functions

On 1/22/19 4:14 PM, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Jesper Nilsson <[email protected]>
> Cc: Lars Persson <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/crypto/axis/artpec6_crypto.c | 9 ---------
> 1 file changed, 9 deletions(-)

Acked-by: Lars Persson <[email protected]>

Thanks,
Lars

2019-01-23 12:58:38

by Gilad Ben-Yossef

[permalink] [raw]

Subject: Re: [PATCH 2/7] crypto: ccrree: no need to check return value of debugfs_create functions

Hi,

On Tue, Jan 22, 2019 at 5:14 PM Greg Kroah-Hartman
<[email protected]> wrote:
>
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.

I get the part about not failing loading the driver just because some
debugs entry isn't available, but wont it be weird if
debugfs_create_dir() fails but debugfs_create_regset32() succeeds and
we suddenly have weird files in the debugfs root dir?
Not the end of the world of course but maybe it's better to avoid
trying to create the files if the directory is not available?

Thanks,
Gilad

>
> Cc: Yael Chemla <[email protected]>
> Cc: Gilad Ben-Yossef <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/crypto/ccree/cc_debugfs.c | 22 +++-------------------
> drivers/crypto/ccree/cc_debugfs.h | 8 ++------
> drivers/crypto/ccree/cc_driver.c | 7 +------
> 3 files changed, 6 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_debugfs.c b/drivers/crypto/ccree/cc_debugfs.c
> index 5ca184e42483..5fa05a7bcf36 100644
> --- a/drivers/crypto/ccree/cc_debugfs.c
> +++ b/drivers/crypto/ccree/cc_debugfs.c
> @@ -39,11 +39,9 @@ static struct debugfs_reg32 debug_regs[] = {
> CC_DEBUG_REG(AXIM_MON_COMP),
> };
>
> -int __init cc_debugfs_global_init(void)
> +void __init cc_debugfs_global_init(void)
> {
> cc_debugfs_dir = debugfs_create_dir("ccree", NULL);
> -
> - return !cc_debugfs_dir;
> }
>
> void __exit cc_debugfs_global_fini(void)
> @@ -56,7 +54,6 @@ int cc_debugfs_init(struct cc_drvdata *drvdata)
> struct device *dev = drvdata_to_dev(drvdata);
> struct cc_debugfs_ctx *ctx;
> struct debugfs_regset32 *regset;
> - struct dentry *file;
>
> debug_regs[0].offset = drvdata->sig_offset;
> debug_regs[1].offset = drvdata->ver_offset;
> @@ -74,22 +71,9 @@ int cc_debugfs_init(struct cc_drvdata *drvdata)
> regset->base = drvdata->cc_base;
>
> ctx->dir = debugfs_create_dir(drvdata->plat_dev->name, cc_debugfs_dir);
> - if (!ctx->dir)
> - return -ENFILE;
> -
> - file = debugfs_create_regset32("regs", 0400, ctx->dir, regset);
> - if (!file) {
> - debugfs_remove(ctx->dir);
> - return -ENFILE;
> - }
>
> - file = debugfs_create_bool("coherent", 0400, ctx->dir,
> - &drvdata->coherent);
> -
> - if (!file) {
> - debugfs_remove_recursive(ctx->dir);
> - return -ENFILE;
> - }
> + debugfs_create_regset32("regs", 0400, ctx->dir, regset);
> + debugfs_create_bool("coherent", 0400, ctx->dir, &drvdata->coherent);
>
> drvdata->debugfs = ctx;
>
> diff --git a/drivers/crypto/ccree/cc_debugfs.h b/drivers/crypto/ccree/cc_debugfs.h
> index 5b5320eca7d2..01cbd9a95659 100644
> --- a/drivers/crypto/ccree/cc_debugfs.h
> +++ b/drivers/crypto/ccree/cc_debugfs.h
> @@ -5,7 +5,7 @@
> #define __CC_DEBUGFS_H__
>
> #ifdef CONFIG_DEBUG_FS
> -int cc_debugfs_global_init(void);
> +void cc_debugfs_global_init(void);
> void cc_debugfs_global_fini(void);
>
> int cc_debugfs_init(struct cc_drvdata *drvdata);
> @@ -13,11 +13,7 @@ void cc_debugfs_fini(struct cc_drvdata *drvdata);
>
> #else
>
> -static inline int cc_debugfs_global_init(void)
> -{
> - return 0;
> -}
> -
> +static inline void cc_debugfs_global_init(void) {}
> static inline void cc_debugfs_global_fini(void) {}
>
> static inline int cc_debugfs_init(struct cc_drvdata *drvdata)
> diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
> index 8ada308d72ee..662738e53ced 100644
> --- a/drivers/crypto/ccree/cc_driver.c
> +++ b/drivers/crypto/ccree/cc_driver.c
> @@ -538,13 +538,8 @@ static struct platform_driver ccree_driver = {
>
> static int __init ccree_init(void)
> {
> - int ret;
> -
> cc_hash_global_init();
> -
> - ret = cc_debugfs_global_init();
> - if (ret)
> - return ret;
> + cc_debugfs_global_init();
>
> return platform_driver_register(&ccree_driver);
> }
> --
> 2.20.1
>

--
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!

2019-01-23 13:30:32

by Jan Glauber

[permalink] [raw]

Subject: Re: [PATCH 4/7] crypto: cavium: zip: no need to check return value of debugfs_create functions

On Tue, Jan 22, 2019 at 04:14:19PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Robert Richter <[email protected]>
> Cc: Jan Glauber <[email protected]>
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/crypto/cavium/zip/zip_main.c | 52 ++++++----------------------
> 1 file changed, 11 insertions(+), 41 deletions(-)

Reviewed-by: Jan Glauber <[email protected]>

thanks,
Jan

2019-01-23 13:37:38

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH 2/7] crypto: ccrree: no need to check return value of debugfs_create functions

On Wed, Jan 23, 2019 at 02:58:22PM +0200, Gilad Ben-Yossef wrote:
> Hi,
>
> On Tue, Jan 22, 2019 at 5:14 PM Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
>
>
>
> I get the part about not failing loading the driver just because some
> debugs entry isn't available, but wont it be weird if
> debugfs_create_dir() fails but debugfs_create_regset32() succeeds and
> we suddenly have weird files in the debugfs root dir?
> Not the end of the world of course but maybe it's better to avoid
> trying to create the files if the directory is not available?

See this patch to handle that theoretical issue:

https://lore.kernel.org/lkml/[email protected]/T/#me91cc3d16185be13d64f85c8477c543cbda9baf6

thanks,

greg k-h

2019-01-24 07:58:38

by Gilad Ben-Yossef

[permalink] [raw]

Subject: Re: [PATCH 2/7] crypto: ccrree: no need to check return value of debugfs_create functions

On Wed, Jan 23, 2019 at 3:37 PM Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Wed, Jan 23, 2019 at 02:58:22PM +0200, Gilad Ben-Yossef wrote:
> > Hi,
> >
> > On Tue, Jan 22, 2019 at 5:14 PM Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > When calling debugfs functions, there is no need to ever check the
> > > return value. The function can work or not, but the code logic should
> > > never do something different based on this.
> >
> >
> >
> > I get the part about not failing loading the driver just because some
> > debugs entry isn't available, but wont it be weird if
> > debugfs_create_dir() fails but debugfs_create_regset32() succeeds and
> > we suddenly have weird files in the debugfs root dir?
> > Not the end of the world of course but maybe it's better to avoid
> > trying to create the files if the directory is not available?
>
> See this patch to handle that theoretical issue:
>
> https://lore.kernel.org/lkml/[email protected]/T/#me91cc3d16185be13d64f85c8477c543cbda9baf6
>

Ah, sorry. I've missed that.

Acked-By: Gilad Ben-Yossef <[email protected]>

Thanks!
Gilad

--
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!

2019-02-01 06:49:02

by Herbert Xu

[permalink] [raw]

Subject: Re: [PATCH 0/7] crypto: cleanup debugfs usage

On Tue, Jan 22, 2019 at 04:14:15PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs code, there is no need to ever check the return
> value of the call, as no logic should ever change if a call works
> properly or not. Fix up a bunch of crypto-specific code to not care
> about the results of debugfs.
>
> Greg Kroah-Hartman (7):
> crypto: qat: no need to check return value of debugfs_create functions
> crypto: ccrree: no need to check return value of debugfs_create
> functions
> crypto: axis: no need to check return value of debugfs_create
> functions
> crypto: cavium: zip: no need to check return value of debugfs_create
> functions
> crypto: cavium: nitrox: no need to check return value of
> debugfs_create functions
> crypto: ccp: no need to check return value of debugfs_create functions
> crypto: caam: no need to check return value of debugfs_create
> functions
>
> drivers/crypto/axis/artpec6_crypto.c | 9 ----
> drivers/crypto/caam/ctrl.c | 21 +++-----
> drivers/crypto/caam/intern.h | 1 -
> drivers/crypto/cavium/nitrox/nitrox_debugfs.c | 27 ++--------
> drivers/crypto/cavium/nitrox/nitrox_debugfs.h | 5 +-
> drivers/crypto/cavium/nitrox/nitrox_main.c | 4 +-
> drivers/crypto/cavium/zip/zip_main.c | 52 ++++---------------
> drivers/crypto/ccp/ccp-debugfs.c | 36 +++----------
> drivers/crypto/ccree/cc_debugfs.c | 22 ++------
> drivers/crypto/ccree/cc_debugfs.h | 8 +--
> drivers/crypto/ccree/cc_driver.c | 7 +--
> drivers/crypto/qat/qat_c3xxx/adf_drv.c | 5 --
> drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 5 --
> drivers/crypto/qat/qat_c62x/adf_drv.c | 5 --
> drivers/crypto/qat/qat_c62xvf/adf_drv.c | 5 --
> drivers/crypto/qat/qat_common/adf_cfg.c | 7 ---
> drivers/crypto/qat/qat_common/adf_transport.c | 6 ---
> .../qat/qat_common/adf_transport_debug.c | 15 ------
> drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 5 --
> drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 5 --
> 20 files changed, 38 insertions(+), 212 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt