2019-10-27 16:59:05

by Christian Lamparter

Subject: [PATCH] crypto: amcc - restore CRYPTO_AES dependency

This patch restores the CRYPTO_AES dependency. This is
necessary since some of the crypto4xx driver provided
modes need functioning software fallbacks for
AES-CTR/CCM and GCM.

Fixes: da3e7a9715ea ("crypto: amcc - switch to AES library for GCM key derivation")
Cc: Ard Biesheuvel <[email protected]>
Signed-off-by: Christian Lamparter <[email protected]>
---
drivers/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 23d3fd97f678..06c8e3e1c48a 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -332,6 +332,7 @@ config CRYPTO_DEV_PPC4XX
depends on PPC && 4xx
select CRYPTO_HASH
select CRYPTO_AEAD
+ select CRYPTO_AES
select CRYPTO_LIB_AES
select CRYPTO_CCM
select CRYPTO_CTR
--
2.24.0.rc1

2019-10-28 15:58:33

by Ard Biesheuvel

Subject: Re: [PATCH] crypto: amcc - restore CRYPTO_AES dependency

On Sun, 27 Oct 2019 at 16:47, Christian Lamparter <[email protected]> wrote:
>
> This patch restores the CRYPTO_AES dependency. This is
> necessary since some of the crypto4xx driver provided
> modes need functioning software fallbacks for
> AES-CTR/CCM and GCM.
>
> Fixes: da3e7a9715ea ("crypto: amcc - switch to AES library for GCM key derivation")
> Cc: Ard Biesheuvel <[email protected]>
> Signed-off-by: Christian Lamparter <[email protected]>

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 23d3fd97f678..06c8e3e1c48a 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -332,6 +332,7 @@ config CRYPTO_DEV_PPC4XX
> depends on PPC && 4xx
> select CRYPTO_HASH
> select CRYPTO_AEAD
> + select CRYPTO_AES
> select CRYPTO_LIB_AES
> select CRYPTO_CCM
> select CRYPTO_CTR
> --
> 2.24.0.rc1
>

2019-11-01 06:14:26

by Herbert Xu

Subject: Re: [PATCH] crypto: amcc - restore CRYPTO_AES dependency

Christian Lamparter <[email protected]> wrote:
> This patch restores the CRYPTO_AES dependency. This is
> necessary since some of the crypto4xx driver provided
> modes need functioning software fallbacks for
> AES-CTR/CCM and GCM.
>
> Fixes: da3e7a9715ea ("crypto: amcc - switch to AES library for GCM key derivation")
> Cc: Ard Biesheuvel <[email protected]>
> Signed-off-by: Christian Lamparter <[email protected]>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt