2020-03-15 14:52:46

by Corentin Labbe

Subject: BUG: cryptsetup benchmark stuck

hello

On next-20200313, running cryptsetup benchmark is stuck.
I have bisected this problem twice and the result is the same:

git bisect start
# bad: [2e602db729948ce577bf07e2b113f2aa806b62c7] Add linux-next specific files for 20200313
git bisect bad 2e602db729948ce577bf07e2b113f2aa806b62c7
# good: [98d54f81e36ba3bf92172791eba5ca5bd813989b] Linux 5.6-rc4
git bisect good 98d54f81e36ba3bf92172791eba5ca5bd813989b
# good: [f1ffc9616ef098ac180ac8ae3554e9beda4014f8] Merge remote-tracking branch 'bluetooth/master'
git bisect good f1ffc9616ef098ac180ac8ae3554e9beda4014f8
# good: [517488f00386297a3ed8a626c4fd23c1c05fab77] Merge remote-tracking branch 'iommu/next'
git bisect good 517488f00386297a3ed8a626c4fd23c1c05fab77
# bad: [308033e51d5c167ded64799982ab042ee1cdd7e5] Merge remote-tracking branch 'thunderbolt/next'
git bisect bad 308033e51d5c167ded64799982ab042ee1cdd7e5
# bad: [436b37da2c4b71ce22d915355291a2fe9bf71abd] Merge remote-tracking branch 'irqchip/irq/irqchip-next'
git bisect bad 436b37da2c4b71ce22d915355291a2fe9bf71abd
# bad: [b8aaa6b4a71eaa1161ae3a8e67e7c48dbdd131d5] Merge branch 'efi/urgent'
git bisect bad b8aaa6b4a71eaa1161ae3a8e67e7c48dbdd131d5
# good: [c99bbc21e58b91ac670c95a51639cc35f364ce7a] Merge branch 'sched/core'
git bisect good c99bbc21e58b91ac670c95a51639cc35f364ce7a
# bad: [1949ed1e393b5740b295f548ce66e2eeae3e76f7] Merge branch 'locking/urgent'
git bisect bad 1949ed1e393b5740b295f548ce66e2eeae3e76f7
# good: [836196beb377e59e54ec9e04f7402076ef7a8bd8] perf/core: Add per perf_cpu_context min_heap storage
git bisect good 836196beb377e59e54ec9e04f7402076ef7a8bd8
# good: [798048f85093901f475d25b2ac8d9ea1bc6d471a] Merge tag 'perf-urgent-for-mingo-5.6-20200306' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
git bisect good 798048f85093901f475d25b2ac8d9ea1bc6d471a
# good: [edd5d987f561b657c46383b0a778b99d51a76e4b] Merge branch 'ras/core'
git bisect good edd5d987f561b657c46383b0a778b99d51a76e4b
# good: [95ed6c707f26a727a29972b60469630ae10d579c] perf/cgroup: Order events in RB tree by cgroup id
git bisect good 95ed6c707f26a727a29972b60469630ae10d579c
# good: [b00f7244f01b8a9d205944929f58b99732541f44] Merge branch 'perf/core'
git bisect good b00f7244f01b8a9d205944929f58b99732541f44
# bad: [8019ad13ef7f64be44d4f892af9c840179009254] futex: Fix inode life-time issue
git bisect bad 8019ad13ef7f64be44d4f892af9c840179009254
# first bad commit: [8019ad13ef7f64be44d4f892af9c840179009254] futex: Fix inode life-time issue


git bisect start
# good: [2c523b344dfa65a3738e7039832044aa133c75fb] Linux 5.6-rc5
git bisect good 2c523b344dfa65a3738e7039832044aa133c75fb
# bad: [2e602db729948ce577bf07e2b113f2aa806b62c7] Add linux-next specific files for 20200313
git bisect bad 2e602db729948ce577bf07e2b113f2aa806b62c7
# good: [acfda12b3a9b7b8d8cb4ff5f6ff0e48f688e254c] Merge remote-tracking branch 'spi-nor/spi-nor/next'
git bisect good acfda12b3a9b7b8d8cb4ff5f6ff0e48f688e254c
# good: [b38d0a2fd9c0bdd99492655295d0972ea549dca6] Merge remote-tracking branch 'devicetree/for-next'
git bisect good b38d0a2fd9c0bdd99492655295d0972ea549dca6
# bad: [308033e51d5c167ded64799982ab042ee1cdd7e5] Merge remote-tracking branch 'thunderbolt/next'
git bisect bad 308033e51d5c167ded64799982ab042ee1cdd7e5
# bad: [436b37da2c4b71ce22d915355291a2fe9bf71abd] Merge remote-tracking branch 'irqchip/irq/irqchip-next'
git bisect bad 436b37da2c4b71ce22d915355291a2fe9bf71abd
# bad: [b8aaa6b4a71eaa1161ae3a8e67e7c48dbdd131d5] Merge branch 'efi/urgent'
git bisect bad b8aaa6b4a71eaa1161ae3a8e67e7c48dbdd131d5
# good: [c99bbc21e58b91ac670c95a51639cc35f364ce7a] Merge branch 'sched/core'
git bisect good c99bbc21e58b91ac670c95a51639cc35f364ce7a
# bad: [1949ed1e393b5740b295f548ce66e2eeae3e76f7] Merge branch 'locking/urgent'
git bisect bad 1949ed1e393b5740b295f548ce66e2eeae3e76f7
# good: [836196beb377e59e54ec9e04f7402076ef7a8bd8] perf/core: Add per perf_cpu_context min_heap storage
git bisect good 836196beb377e59e54ec9e04f7402076ef7a8bd8
# good: [798048f85093901f475d25b2ac8d9ea1bc6d471a] Merge tag 'perf-urgent-for-mingo-5.6-20200306' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
git bisect good 798048f85093901f475d25b2ac8d9ea1bc6d471a
# good: [edd5d987f561b657c46383b0a778b99d51a76e4b] Merge branch 'ras/core'
git bisect good edd5d987f561b657c46383b0a778b99d51a76e4b
# good: [95ed6c707f26a727a29972b60469630ae10d579c] perf/cgroup: Order events in RB tree by cgroup id
git bisect good 95ed6c707f26a727a29972b60469630ae10d579c
# good: [b00f7244f01b8a9d205944929f58b99732541f44] Merge branch 'perf/core'
git bisect good b00f7244f01b8a9d205944929f58b99732541f44
# bad: [8019ad13ef7f64be44d4f892af9c840179009254] futex: Fix inode life-time issue
git bisect bad 8019ad13ef7f64be44d4f892af9c840179009254
# first bad commit: [8019ad13ef7f64be44d4f892af9c840179009254] futex: Fix inode life-time issue

Since the two bisect lead to the same commit, I think it should be right one even if I dont find anything related to my problem.
But reverting this patch is impossible, so I cannot test to try without it.

Regards

2020-03-16 08:29:21

by Thomas Gleixner

Subject: Re: BUG: cryptsetup benchmark stuck

Corentin,

Corentin Labbe <[email protected]> writes:
> On next-20200313, running cryptsetup benchmark is stuck.
> I have bisected this problem twice and the result is the same:
>
> git bisect bad 8019ad13ef7f64be44d4f892af9c840179009254
> # first bad commit: [8019ad13ef7f64be44d4f892af9c840179009254] futex: Fix inode life-time issue
>
> Since the two bisect lead to the same commit, I think it should be
> right one even if I dont find anything related to my problem.

I'm as puzzled as you.

> But reverting this patch is impossible, so I cannot test to try
> without it.

You need to revert two:

8d67743653dc ("futex: Unbreak futex hashing")
8019ad13ef7f ("futex: Fix inode life-time issue")

Thanks,

tglx

2020-03-16 13:54:11

by Corentin Labbe

Subject: Re: BUG: cryptsetup benchmark stuck

On Mon, Mar 16, 2020 at 09:28:40AM +0100, Thomas Gleixner wrote:
> Corentin,
>
> Corentin Labbe <[email protected]> writes:
> > On next-20200313, running cryptsetup benchmark is stuck.
> > I have bisected this problem twice and the result is the same:
> >
> > git bisect bad 8019ad13ef7f64be44d4f892af9c840179009254
> > # first bad commit: [8019ad13ef7f64be44d4f892af9c840179009254] futex: Fix inode life-time issue
> >
> > Since the two bisect lead to the same commit, I think it should be
> > right one even if I dont find anything related to my problem.
>
> I'm as puzzled as you.
>
> > But reverting this patch is impossible, so I cannot test to try
> > without it.
>
> You need to revert two:
>
> 8d67743653dc ("futex: Unbreak futex hashing")
> 8019ad13ef7f ("futex: Fix inode life-time issue")
>

On next-20200313, there are no "futex: Unbreak futex hashing".
And it seems to fix my issue, I have updated to next-20200316 (which have it) and the issue is not present anymore.

Thanks
Regards