LinuxLists.cc - [PATCH 2/2] crypto: sa2ul: fix compiler warning produced by clang

2020-08-25 13:31:55

Subject: [PATCH 2/2] crypto: sa2ul: fix compiler warning produced by clang

Clang detects a warning for an assignment that doesn't really do
anything. Fix this by removing the offending piece of code.

Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Reported-by: Nathan Chancellor <[email protected]>
Signed-off-by: Tero Kristo <[email protected]>
---
drivers/crypto/sa2ul.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index 5bc099052bd2..ff8bbdb4d235 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -1148,12 +1148,10 @@ static int sa_run(struct sa_req *req)
ret = sg_split(req->dst, mapped_dst_nents, 0, 1,
&split_size, &dst, &dst_nents,
gfp_flags);
- if (ret) {
- dst_nents = dst_nents;
+ if (ret)
dst = req->dst;
- } else {
+ else
rxd->split_dst_sg = dst;
- }
}
}

--
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2020-08-26 05:24:06

by Nathan Chancellor

[permalink] [raw]

Subject: Re: [PATCH 2/2] crypto: sa2ul: fix compiler warning produced by clang

On Tue, Aug 25, 2020 at 04:31:06PM +0300, Tero Kristo wrote:
> Clang detects a warning for an assignment that doesn't really do
> anything. Fix this by removing the offending piece of code.
>
> Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
> Reported-by: Nathan Chancellor <[email protected]>
> Signed-off-by: Tero Kristo <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>
Tested-by: Nathan Chancellor <[email protected]> # build

> ---
> drivers/crypto/sa2ul.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
> index 5bc099052bd2..ff8bbdb4d235 100644
> --- a/drivers/crypto/sa2ul.c
> +++ b/drivers/crypto/sa2ul.c
> @@ -1148,12 +1148,10 @@ static int sa_run(struct sa_req *req)
> ret = sg_split(req->dst, mapped_dst_nents, 0, 1,
> &split_size, &dst, &dst_nents,
> gfp_flags);
> - if (ret) {
> - dst_nents = dst_nents;
> + if (ret)
> dst = req->dst;
> - } else {
> + else
> rxd->split_dst_sg = dst;
> - }
> }
> }
>
> --
> 2.17.1
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2020-09-11 06:56:35

by Herbert Xu

[permalink] [raw]