2020-10-26 14:05:18

by Zhang Qilong

Subject: [PATCH -next] crypto: atmel-sha: discard unnecessary break

The 'break' is unnecessary because of previous
'return', discard it.

Signed-off-by: Zhang Qilong <[email protected]>
---
drivers/crypto/atmel-sha.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 75ccf41a7cb9..0eb6f54e3b66 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
break;
default:
return -EINVAL;
- break;
}

ctx->bufcnt = 0;
--
2.17.1

2020-10-27 00:03:29

by Alexandre Belloni

Subject: Re: [PATCH -next] crypto: atmel-sha: discard unnecessary break

Hi,

On 26/10/2020 21:48:07+0800, Zhang Qilong wrote:
> The 'break' is unnecessary because of previous
> 'return', discard it.
>

This is a duplicate of https://lore.kernel.org/linux-crypto/[email protected]/T/#u

> Signed-off-by: Zhang Qilong <[email protected]>
> ---
> drivers/crypto/atmel-sha.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 75ccf41a7cb9..0eb6f54e3b66 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -459,7 +459,6 @@ static int atmel_sha_init(struct ahash_request *req)
> break;
> default:
> return -EINVAL;
> - break;
> }
>
> ctx->bufcnt = 0;
> --
> 2.17.1
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com