2021-05-24 11:36:25

by Liu Shixin

Subject: [PATCH -next] crypto: algboss - Replaced simple_strtol() with kstrtouint()

The simple_strtol() function is deprecated in some situation since
it does not check for the range overflow. Use kstrtouint() instead.

Signed-off-by: Liu Shixin <[email protected]>
---
crypto/algboss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/algboss.c b/crypto/algboss.c
index 5ebccbd6b74e..64bb8dab9584 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -140,8 +140,8 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
param->attrs[i].nu32.attr.rta_len =
sizeof(param->attrs[i].nu32);
param->attrs[i].nu32.attr.rta_type = CRYPTOA_U32;
- param->attrs[i].nu32.data.num =
- simple_strtol(name, NULL, 0);
+ if (unlikely(kstrtouint(name, 0, &param->attrs[i].nu32.data.num)))
+ goto err_free_param;
}

param->tb[i + 1] = &param->attrs[i].attr;
--
2.18.0.huawei.25

2021-05-24 21:58:25

by Eric Biggers

Subject: Re: [PATCH -next] crypto: algboss - Replaced simple_strtol() with kstrtouint()

On Mon, May 24, 2021 at 08:08:34PM +0800, Liu Shixin wrote:
> The simple_strtol() function is deprecated in some situation since
> it does not check for the range overflow. Use kstrtouint() instead.
>
> Signed-off-by: Liu Shixin <[email protected]>
> ---
> crypto/algboss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/crypto/algboss.c b/crypto/algboss.c
> index 5ebccbd6b74e..64bb8dab9584 100644
> --- a/crypto/algboss.c
> +++ b/crypto/algboss.c
> @@ -140,8 +140,8 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
> param->attrs[i].nu32.attr.rta_len =
> sizeof(param->attrs[i].nu32);
> param->attrs[i].nu32.attr.rta_type = CRYPTOA_U32;
> - param->attrs[i].nu32.data.num =
> - simple_strtol(name, NULL, 0);
> + if (unlikely(kstrtouint(name, 0, &param->attrs[i].nu32.data.num)))
> + goto err_free_param;

It would be better to just remove all the code related to CRYPTOA_U32 and
crypto_attr_u32, as it is never used.

- Eric

2021-06-03 10:54:22

by Liu Shixin

Subject: Re: [PATCH -next] crypto: algboss - Replaced simple_strtol() with kstrtouint()

On 2021/6/3 16:12, Herbert Xu wrote:
> On Mon, May 24, 2021 at 02:57:50PM -0700, Eric Biggers wrote:
>> It would be better to just remove all the code related to CRYPTOA_U32 and
>> crypto_attr_u32, as it is never used.
> I agree, it's been unused for over a decade.
>
> Thanks,

Thank you both for the advice, I will fix it.
Besides, I noticed that type CRYPTOA_UNSPEC has never been used, should I remove it together?

Thanks,

2021-06-03 11:51:27

by Herbert Xu

Subject: Re: [PATCH -next] crypto: algboss - Replaced simple_strtol() with kstrtouint()

On Thu, Jun 03, 2021 at 06:53:00PM +0800, Liu Shixin wrote:
>
> Besides, I noticed that type CRYPTOA_UNSPEC has never been used, should I remove it together?

No please leave it alone.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt