2022-01-11 07:20:07

by Dan Carpenter

Subject: [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()

The mc146818_get_time() function returns zero on success or negative
a error code on failure. It needs to be type int.

Fixes: d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
Signed-off-by: Dan Carpenter <[email protected]>
---
include/linux/mc146818rtc.h | 2 +-
drivers/rtc/rtc-mc146818-lib.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h
index 67fb0a12becc..808bb4cee230 100644
--- a/include/linux/mc146818rtc.h
+++ b/include/linux/mc146818rtc.h
@@ -124,7 +124,7 @@ struct cmos_rtc_board_info {
#endif /* ARCH_RTC_LOCATION */

bool mc146818_does_rtc_work(void);
-unsigned int mc146818_get_time(struct rtc_time *time);
+int mc146818_get_time(struct rtc_time *time);
int mc146818_set_time(struct rtc_time *time);

bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c
index f62e658cbe23..7f689f1bafc5 100644
--- a/drivers/rtc/rtc-mc146818-lib.c
+++ b/drivers/rtc/rtc-mc146818-lib.c
@@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in)
p->ctrl = CMOS_READ(RTC_CONTROL);
}

-unsigned int mc146818_get_time(struct rtc_time *time)
+int mc146818_get_time(struct rtc_time *time)
{
struct mc146818_get_time_callback_param p = {
.time = time
--
2.20.1

2022-01-11 09:53:06

by Mateusz Jończyk

Subject: Re: [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()

W dniu 11.01.2022 o 08:19, Dan Carpenter pisze:
> The mc146818_get_time() function returns zero on success or negative
> a error code on failure. It needs to be type int.
>
> Fixes: d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
> Signed-off-by: Dan Carpenter <[email protected]>

Indeed, thanks for spotting this.

Reviewed-by: Mateusz Jończyk <[email protected]>

> ---
> include/linux/mc146818rtc.h | 2 +-
> drivers/rtc/rtc-mc146818-lib.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/mc146818rtc.h b/include/linux/mc146818rtc.h
> index 67fb0a12becc..808bb4cee230 100644
> --- a/include/linux/mc146818rtc.h
> +++ b/include/linux/mc146818rtc.h
> @@ -124,7 +124,7 @@ struct cmos_rtc_board_info {
> #endif /* ARCH_RTC_LOCATION */
>
> bool mc146818_does_rtc_work(void);
> -unsigned int mc146818_get_time(struct rtc_time *time);
> +int mc146818_get_time(struct rtc_time *time);
> int mc146818_set_time(struct rtc_time *time);
>
> bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
> diff --git a/drivers/rtc/rtc-mc146818-lib.c b/drivers/rtc/rtc-mc146818-lib.c
> index f62e658cbe23..7f689f1bafc5 100644
> --- a/drivers/rtc/rtc-mc146818-lib.c
> +++ b/drivers/rtc/rtc-mc146818-lib.c
> @@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in)
> p->ctrl = CMOS_READ(RTC_CONTROL);
> }
>
> -unsigned int mc146818_get_time(struct rtc_time *time)
> +int mc146818_get_time(struct rtc_time *time)
> {
> struct mc146818_get_time_callback_param p = {
> .time = time

2022-01-17 11:06:53

by Alexandre Belloni

Subject: Re: [PATCH] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()

On Tue, 11 Jan 2022 10:19:22 +0300, Dan Carpenter wrote:
> The mc146818_get_time() function returns zero on success or negative
> a error code on failure. It needs to be type int.
>
>

Applied, thanks!

[1/1] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
commit: 7372971c1be5b7d4fdd8ad237798bdc1d1d54162

Best regards,
--
Alexandre Belloni <[email protected]>