2022-02-19 07:09:24

by Baoquan He

Subject: [PATCH 05/22] sound: n64: Don't use GFP_DMA when calling dma_alloc_coherent()

dma_alloc_coherent() allocates dma buffer with device's addressing
limitation in mind. It's redundent to specify GFP_DMA when calling
dma_alloc_coherent().

[ [email protected]: Update changelog ]

Signed-off-by: Baoquan He <[email protected]>
Acked-by: Hyeonggon Yoo <[email protected]>
---
sound/mips/snd-n64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/mips/snd-n64.c b/sound/mips/snd-n64.c
index 463a6fe589eb..20386a855191 100644
--- a/sound/mips/snd-n64.c
+++ b/sound/mips/snd-n64.c
@@ -305,7 +305,7 @@ static int __init n64audio_probe(struct platform_device *pdev)
priv->card = card;

priv->ring_base = dma_alloc_coherent(card->dev, 32 * 1024, &priv->ring_base_dma,
- GFP_DMA|GFP_KERNEL);
+ GFP_KERNEL);
if (!priv->ring_base) {
err = -ENOMEM;
goto fail_card;
--
2.17.2

2022-02-20 17:26:25

by Christoph Hellwig

Subject: Re: [PATCH 05/22] sound: n64: Don't use GFP_DMA when calling dma_alloc_coherent()

On Sat, Feb 19, 2022 at 08:52:04AM +0800, Baoquan He wrote:
> dma_alloc_coherent() allocates dma buffer with device's addressing
> limitation in mind. It's redundent to specify GFP_DMA when calling
> dma_alloc_coherent().
>
> [ [email protected]: Update changelog ]
>
> Signed-off-by: Baoquan He <[email protected]>
> Acked-by: Hyeonggon Yoo <[email protected]>

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>