2022-08-31 14:06:41

by CGEL

Subject: [PATCH linux-next] crypto: nx: remove redundant variable rc

From: Jinpeng Cui <[email protected]>

Return value directly from set_msg_len() instead of
getting value from redundant variable rc.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Jinpeng Cui <[email protected]>
---
drivers/crypto/nx/nx-aes-ccm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/crypto/nx/nx-aes-ccm.c b/drivers/crypto/nx/nx-aes-ccm.c
index 3793885f928d..c843f4c6f684 100644
--- a/drivers/crypto/nx/nx-aes-ccm.c
+++ b/drivers/crypto/nx/nx-aes-ccm.c
@@ -134,7 +134,6 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
unsigned int cryptlen, u8 *b0)
{
unsigned int l, lp, m = authsize;
- int rc;

memcpy(b0, iv, 16);

@@ -148,9 +147,7 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
if (assoclen)
*b0 |= 64;

- rc = set_msg_len(b0 + 16 - l, cryptlen, l);
-
- return rc;
+ return set_msg_len(b0 + 16 - l, cryptlen, l);
}

static int generate_pat(u8 *iv,
--
2.25.1

2022-08-31 16:30:48

by Breno Leitao

Subject: Re: [PATCH linux-next] crypto: nx: remove redundant variable rc

On Wed, Aug 31, 2022 at 02:02:48PM +0000, [email protected] wrote:
> From: Jinpeng Cui <[email protected]>
>
> Return value directly from set_msg_len() instead of
> getting value from redundant variable rc.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Jinpeng Cui <[email protected]>
Reviewed-by: Breno Leitao <[email protected]>

> ---
> drivers/crypto/nx/nx-aes-ccm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/crypto/nx/nx-aes-ccm.c b/drivers/crypto/nx/nx-aes-ccm.c
> index 3793885f928d..c843f4c6f684 100644
> --- a/drivers/crypto/nx/nx-aes-ccm.c
> +++ b/drivers/crypto/nx/nx-aes-ccm.c
> @@ -134,7 +134,6 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
> unsigned int cryptlen, u8 *b0)
> {
> unsigned int l, lp, m = authsize;
> - int rc;
>
> memcpy(b0, iv, 16);
>
> @@ -148,9 +147,7 @@ static int generate_b0(u8 *iv, unsigned int assoclen, unsigned int authsize,
> if (assoclen)
> *b0 |= 64;
>
> - rc = set_msg_len(b0 + 16 - l, cryptlen, l);
> -
> - return rc;
> + return set_msg_len(b0 + 16 - l, cryptlen, l);
> }
>
> static int generate_pat(u8 *iv,
> --
> 2.25.1
>