2023-05-25 21:06:08

by Uwe Kleine-König

Subject: [PATCH] crypto: Switch i2c drivers back to use .probe()

After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
convert back to (the new) .probe() to be able to eventually drop
.probe_new() from struct i2c_driver.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/crypto/atmel-ecc.c | 2 +-
drivers/crypto/atmel-sha204a.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index aac64b555204..432beabd79e6 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -389,7 +389,7 @@ static struct i2c_driver atmel_ecc_driver = {
.name = "atmel-ecc",
.of_match_table = of_match_ptr(atmel_ecc_dt_ids),
},
- .probe_new = atmel_ecc_probe,
+ .probe = atmel_ecc_probe,
.remove = atmel_ecc_remove,
.id_table = atmel_ecc_id,
};
diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
index 44a185a84760..c77f482d2a97 100644
--- a/drivers/crypto/atmel-sha204a.c
+++ b/drivers/crypto/atmel-sha204a.c
@@ -141,7 +141,7 @@ static const struct i2c_device_id atmel_sha204a_id[] = {
MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id);

static struct i2c_driver atmel_sha204a_driver = {
- .probe_new = atmel_sha204a_probe,
+ .probe = atmel_sha204a_probe,
.remove = atmel_sha204a_remove,
.id_table = atmel_sha204a_id,


base-commit: ac9a78681b921877518763ba0e89202254349d1b
--
2.39.2

2023-05-26 07:51:55

by Tudor Ambarus

Subject: Re: [PATCH] crypto: Switch i2c drivers back to use .probe()

On 5/25/23 22:03, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>
Reviewed-by: Tudor Ambarus <[email protected]>

> ---
> drivers/crypto/atmel-ecc.c | 2 +-
> drivers/crypto/atmel-sha204a.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
> index aac64b555204..432beabd79e6 100644
> --- a/drivers/crypto/atmel-ecc.c
> +++ b/drivers/crypto/atmel-ecc.c
> @@ -389,7 +389,7 @@ static struct i2c_driver atmel_ecc_driver = {
> .name = "atmel-ecc",
> .of_match_table = of_match_ptr(atmel_ecc_dt_ids),
> },
> - .probe_new = atmel_ecc_probe,
> + .probe = atmel_ecc_probe,
> .remove = atmel_ecc_remove,
> .id_table = atmel_ecc_id,
> };
> diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c
> index 44a185a84760..c77f482d2a97 100644
> --- a/drivers/crypto/atmel-sha204a.c
> +++ b/drivers/crypto/atmel-sha204a.c
> @@ -141,7 +141,7 @@ static const struct i2c_device_id atmel_sha204a_id[] = {
> MODULE_DEVICE_TABLE(i2c, atmel_sha204a_id);
>
> static struct i2c_driver atmel_sha204a_driver = {
> - .probe_new = atmel_sha204a_probe,
> + .probe = atmel_sha204a_probe,
> .remove = atmel_sha204a_remove,
> .id_table = atmel_sha204a_id,
>
>
> base-commit: ac9a78681b921877518763ba0e89202254349d1b

2023-06-02 10:34:38

by Herbert Xu

Subject: Re: [PATCH] crypto: Switch i2c drivers back to use .probe()

On Thu, May 25, 2023 at 11:03:47PM +0200, Uwe Kleine-K?nig wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> ---
> drivers/crypto/atmel-ecc.c | 2 +-
> drivers/crypto/atmel-sha204a.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt