2023-07-02 17:43:40

by Martin Kaiser

[permalink] [raw]
Subject: [PATCH 0/2] hwrng: nomadik - two simple cleanups

Use devm_clk_get_enabled to fix a (theoretical) race condition during removal.
Call dev_error_probe to print an error message and exit.

Both changes were compile-tested only, I don't have this hardware.

Martin Kaiser (2):
hwrng: nomadik - keep clock enabled while hwrng is registered
hwrng: nomadik - use dev_err_probe

drivers/char/hw_random/nomadik-rng.c | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)

--
2.30.2



2023-07-14 09:05:42

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 0/2] hwrng: nomadik - two simple cleanups

On Sun, Jul 02, 2023 at 07:35:01PM +0200, Martin Kaiser wrote:
> Use devm_clk_get_enabled to fix a (theoretical) race condition during removal.
> Call dev_error_probe to print an error message and exit.
>
> Both changes were compile-tested only, I don't have this hardware.
>
> Martin Kaiser (2):
> hwrng: nomadik - keep clock enabled while hwrng is registered
> hwrng: nomadik - use dev_err_probe
>
> drivers/char/hw_random/nomadik-rng.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> --
> 2.30.2

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt