On Wed, Dec 20, 2023 at 12:38:57PM +0100, Kshitiz Varshney wrote:
> Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
>
> Issue:-
> Multiple crypto tests like sm3, sm4 xctr and polyval failing.
>
> skcipher: failed to allocate transform for xctr(aes): -2
> alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> alg: self-tests for sm3 using sm3 failed (rc=-2)
> tcrypt: failed to load transform for sm3: -2
> alg: hash: failed to allocate transform for polyval: -2
> alg: self-tests for polyval using polyval failed (rc=-2)
>
> Resolution:-
> Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
> CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
> sm3, sm4, aria, polyval & xctr.
>
> Signed-off-by: Kshitiz Varshney <[email protected]>
The commit log and Signed-off-by lines shouldn't have leading
spaces/indent.
> ---
> arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index 0a90583f9f01..627f57da9d5b 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
> # CONFIG_SLUB_DEBUG is not set
> # CONFIG_SCHED_DEBUG is not set
> # CONFIG_FTRACE is not set
> +CONFIG_CRYPTO_HCTR2=m
> +CONFIG_CRYPTO_SM3_GENERIC=m
> +CONFIG_CRYPTO_SM4_GENERIC=m
> +CONFIG_CRYPTO_ARIA=m
Instead of adding lines at the end of file, please use help from
'make savedefconfig' to get them appear at the correct places.
Shawn
> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: Saturday, February 3, 2024 7:52 PM
> To: Kshitiz Varshney <[email protected]>
> Cc: Herbert Xu <[email protected]>; Shawn Guo
> <[email protected]>; Sascha Hauer <[email protected]>; Fabio
> Estevam <[email protected]>; dl-linux-imx <[email protected]>;
> Pengutronix Kernel Team <[email protected]>; Varun Sethi
> <[email protected]>; Gaurav Jain <[email protected]>; Pankaj Gupta
> <[email protected]>; Sahil Malhotra <[email protected]>;
> Vabhav Sharma <[email protected]>; Meenakshi Aggarwal
> <[email protected]>; Rahul Kumar Yadav
> <[email protected]>; Nikhil Singla <[email protected]>;
> [email protected]; [email protected]
> Subject: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4,
> polyval, xctr cipher test support
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Wed, Dec 20, 2023 at 12:38:57PM +0100, Kshitiz Varshney wrote:
> > Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
> >
> > Issue:-
> > Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> >
> > skcipher: failed to allocate transform for xctr(aes): -2
> > alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> > alg: self-tests for sm3 using sm3 failed (rc=-2)
> > tcrypt: failed to load transform for sm3: -2
> > alg: hash: failed to allocate transform for polyval: -2
> > alg: self-tests for polyval using polyval failed (rc=-2)
> >
> > Resolution:-
> > Enabling CONFIG_CRYPTO_SM3_GENERIC,
> CONFIG_CRYPTO_SM4_GENERIC,
> > CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables
> support of
> > sm3, sm4, aria, polyval & xctr.
> >
> > Signed-off-by: Kshitiz Varshney <[email protected]>
>
> The commit log and Signed-off-by lines shouldn't have leading
> spaces/indent.
Checkpatch has not reported any such issues.
>
> > ---
> > arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> > b/arch/arm/configs/imx_v6_v7_defconfig
> > index 0a90583f9f01..627f57da9d5b 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=y
> > # CONFIG_SLUB_DEBUG is not set
> > # CONFIG_SCHED_DEBUG is not set
> > # CONFIG_FTRACE is not set
> > +CONFIG_CRYPTO_HCTR2=m
> > +CONFIG_CRYPTO_SM3_GENERIC=m
> > +CONFIG_CRYPTO_SM4_GENERIC=m
> > +CONFIG_CRYPTO_ARIA=m
>
> Instead of adding lines at the end of file, please use help from 'make
> savedefconfig' to get them appear at the correct places.
Changes done in v2.
>
> Shawn