2024-02-14 22:57:53

by Eric Biggers

[permalink] [raw]
Subject: Re: [PATCH 06/15] crypto: algif_skcipher - Disallow nonincremental algorithms

On Tue, Dec 05, 2023 at 02:13:26PM +0800, Herbert Xu wrote:
> As algif_skcipher does not support nonincremental algorithms, check
> for them and return ENOSYS

Shouldn't they still be supported if the data is being read/written all at once?

Also, ENOSYS isn't really an appropriate error code. ENOSYS normally means that
the system call isn't supported at all. Maybe use EOPNOTSUPP?

- Eric