2024-01-09 02:20:06

by Minjie Du

Subject: [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init()

This patch removes the debugfs_create_dir() error checking in
iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is developed
in a way that the caller can safely handle the errors that
occur during the creation of DebugFS nodes.

Signed-off-by: Minjie Du <[email protected]>
---
drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
index 2e3b7b73af20..cbf87d0effe3 100644
--- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
+++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
@@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void)
return -ENODEV;

iaa_crypto_debugfs_root = debugfs_create_dir("iaa_crypto", NULL);
- if (!iaa_crypto_debugfs_root)
- return -ENOMEM;

debugfs_create_u64("max_comp_delay_ns", 0644,
iaa_crypto_debugfs_root, &max_comp_delay_ns);
--
2.39.0

2024-01-09 16:25:32

by Tom Zanussi

Subject: Re: [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init()

On Tue, 2024-01-09 at 10:19 +0800, Minjie Du wrote:
> This patch removes the debugfs_create_dir() error checking in
> iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is
> developed
> in a way that the caller can safely handle the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Minjie Du <[email protected]>

Acked-by: Tom Zanussi <[email protected]>

Thanks Minjie,

Tom


> ---
>  drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> index 2e3b7b73af20..cbf87d0effe3 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> @@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void)
>                 return -ENODEV;
>  
>         iaa_crypto_debugfs_root = debugfs_create_dir("iaa_crypto",
> NULL);
> -       if (!iaa_crypto_debugfs_root)
> -               return -ENOMEM;
>  
>         debugfs_create_u64("max_comp_delay_ns", 0644,
>                            iaa_crypto_debugfs_root,
> &max_comp_delay_ns);

2024-01-26 09:55:06

by Herbert Xu

Subject: Re: [PATCH v1] crypto: iaa - Remove unnecessary debugfs_create_dir() error check in iaa_crypto_debugfs_init()

On Tue, Jan 09, 2024 at 10:19:14AM +0800, Minjie Du wrote:
> This patch removes the debugfs_create_dir() error checking in
> iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is developed
> in a way that the caller can safely handle the errors that
> occur during the creation of DebugFS nodes.
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
> 1 file changed, 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt