2023-09-11 21:56:33

by Rob Herring (Arm)

Subject: Re: [PATCH 07/10] dt-bindings: rng: add st,rng-lock-conf

On Fri, Sep 08, 2023 at 06:51:17PM +0200, Gatien Chevallier wrote:
> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR
> and RNG_NSCR will be locked. It is supported starting from the RNG
> version present in the STM32MP13

This should be squashed into the prior binding patch.

>
> Signed-off-by: Gatien Chevallier <[email protected]>
> ---
> .../devicetree/bindings/rng/st,stm32-rng.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
> index 59abdc85a9fb..0055f14a8e3f 100644
> --- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
> +++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
> @@ -37,6 +37,20 @@ required:
> - reg
> - clocks
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - st,stm32mp13-rng
> + then:
> + properties:
> + st,rng-lock-conf:
> + type: boolean
> + description: If set, the RNG configuration in RNG_CR, RNG_HTCR and
> + RNG_NSCR will be locked.

Define the property at the top-level and then restrict its presence in
a if/then schema.

> +
> additionalProperties: false

Did you test this property is allowed? No, because additionalProperties
won't work with properties defined in if/then schemas.

>
> examples:
> --
> 2.25.1
>

2023-09-12 12:05:39

by Gatien CHEVALLIER

Subject: Re: [PATCH 07/10] dt-bindings: rng: add st,rng-lock-conf

Hello Rob,

On 9/11/23 17:09, Rob Herring wrote:
> On Fri, Sep 08, 2023 at 06:51:17PM +0200, Gatien Chevallier wrote:
>> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR
>> and RNG_NSCR will be locked. It is supported starting from the RNG
>> version present in the STM32MP13
>
> This should be squashed into the prior binding patch.
>

Ok, I will squash both for V3.

>>
>> Signed-off-by: Gatien Chevallier <[email protected]>
>> ---
>> .../devicetree/bindings/rng/st,stm32-rng.yaml | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
>> index 59abdc85a9fb..0055f14a8e3f 100644
>> --- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
>> +++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
>> @@ -37,6 +37,20 @@ required:
>> - reg
>> - clocks
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - st,stm32mp13-rng
>> + then:
>> + properties:
>> + st,rng-lock-conf:
>> + type: boolean
>> + description: If set, the RNG configuration in RNG_CR, RNG_HTCR and
>> + RNG_NSCR will be locked.
>
> Define the property at the top-level and then restrict its presence in
> a if/then schema.
>

Ok, will change in V3. Thanks for your input

>> +
>> additionalProperties: false
>
> Did you test this property is allowed? No, because additionalProperties
> won't work with properties defined in if/then schemas.
>
>>
>> examples:
>> --
>> 2.25.1
>>

Best regards,
Gatien