2014-07-13 03:01:50

by Chen Gang

Subject: [PATCH] drivers/crypto/Kconfig: Let 'DEV_QCE' depend on both HAS_DMA and HAS_IOMEM

'DEV_QCE' needs both HAS_DMA and HAS_IOMEM, so let it depend on them.

The related error (with allmodconfig under score):

MODPOST 1365 modules
ERROR: "devm_ioremap_resource" [drivers/crypto/qce/qcrypto.ko] undefined!
ERROR: "dma_map_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
ERROR: "dma_set_mask" [drivers/crypto/qce/qcrypto.ko] undefined!
ERROR: "dma_supported" [drivers/crypto/qce/qcrypto.ko] undefined!
ERROR: "dma_unmap_sg" [drivers/crypto/qce/qcrypto.ko] undefined!

Signed-off-by: Chen Gang <[email protected]>
---
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 5ef9ec9..2fb0fdf 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -422,7 +422,7 @@ source "drivers/crypto/qat/Kconfig"

config CRYPTO_DEV_QCE
tristate "Qualcomm crypto engine accelerator"
- depends on ARCH_QCOM || COMPILE_TEST
+ depends on (ARCH_QCOM || COMPILE_TEST) && HAS_DMA && HAS_IOMEM
select CRYPTO_AES
select CRYPTO_DES
select CRYPTO_ECB
--
1.7.11.7

2014-07-14 12:12:35

by Chen Gang

Subject: Re: [PATCH] drivers/crypto/Kconfig: Let 'DEV_QCE' depend on both HAS_DMA and HAS_IOMEM

Hello all:

This patch is obsoleted according to the other discussion thread about
IOMEM and COMPILE_TEST.

I shall fix it, and maybe not need touch drivers/crypto again, so maybe
not need send patch v2 for it.

Thanks.

On 07/13/2014 11:01 AM, Chen Gang wrote:
> 'DEV_QCE' needs both HAS_DMA and HAS_IOMEM, so let it depend on them.
>
> The related error (with allmodconfig under score):
>
> MODPOST 1365 modules
> ERROR: "devm_ioremap_resource" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_map_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_set_mask" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_supported" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> drivers/crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 5ef9ec9..2fb0fdf 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -422,7 +422,7 @@ source "drivers/crypto/qat/Kconfig"
>
> config CRYPTO_DEV_QCE
> tristate "Qualcomm crypto engine accelerator"
> - depends on ARCH_QCOM || COMPILE_TEST
> + depends on (ARCH_QCOM || COMPILE_TEST) && HAS_DMA && HAS_IOMEM
> select CRYPTO_AES
> select CRYPTO_DES
> select CRYPTO_ECB
>

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2014-07-23 11:43:10

by Chen Gang

Subject: Re: [PATCH] drivers/crypto/Kconfig: Let 'DEV_QCE' depend on both HAS_DMA and HAS_IOMEM

Oh, sorry, this patch can still be alive, after a long discussion, we
need keep current status no touch -- still let individual modules to
depends on HAS_IOMEM and/or HAS_DMA, if they need them.

So please help check the patch, when you have time.

Thanks.

On 07/14/2014 08:12 PM, Chen Gang wrote:
> Hello all:
>
> This patch is obsoleted according to the other discussion thread about
> IOMEM and COMPILE_TEST.
>
> I shall fix it, and maybe not need touch drivers/crypto again, so maybe
> not need send patch v2 for it.
>
> Thanks.
>
> On 07/13/2014 11:01 AM, Chen Gang wrote:
>> 'DEV_QCE' needs both HAS_DMA and HAS_IOMEM, so let it depend on them.
>>
>> The related error (with allmodconfig under score):
>>
>> MODPOST 1365 modules
>> ERROR: "devm_ioremap_resource" [drivers/crypto/qce/qcrypto.ko] undefined!
>> ERROR: "dma_map_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
>> ERROR: "dma_set_mask" [drivers/crypto/qce/qcrypto.ko] undefined!
>> ERROR: "dma_supported" [drivers/crypto/qce/qcrypto.ko] undefined!
>> ERROR: "dma_unmap_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
>>
>> Signed-off-by: Chen Gang <[email protected]>
>> ---
>> drivers/crypto/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
>> index 5ef9ec9..2fb0fdf 100644
>> --- a/drivers/crypto/Kconfig
>> +++ b/drivers/crypto/Kconfig
>> @@ -422,7 +422,7 @@ source "drivers/crypto/qat/Kconfig"
>>
>> config CRYPTO_DEV_QCE
>> tristate "Qualcomm crypto engine accelerator"
>> - depends on ARCH_QCOM || COMPILE_TEST
>> + depends on (ARCH_QCOM || COMPILE_TEST) && HAS_DMA && HAS_IOMEM
>> select CRYPTO_AES
>> select CRYPTO_DES
>> select CRYPTO_ECB
>>
>

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2014-07-23 13:36:18

by Herbert Xu

Subject: Re: [PATCH] drivers/crypto/Kconfig: Let 'DEV_QCE' depend on both HAS_DMA and HAS_IOMEM

On Sun, Jul 13, 2014 at 11:01:38AM +0800, Chen Gang wrote:
> 'DEV_QCE' needs both HAS_DMA and HAS_IOMEM, so let it depend on them.
>
> The related error (with allmodconfig under score):
>
> MODPOST 1365 modules
> ERROR: "devm_ioremap_resource" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_map_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_set_mask" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_supported" [drivers/crypto/qce/qcrypto.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/crypto/qce/qcrypto.ko] undefined!
>
> Signed-off-by: Chen Gang <[email protected]>

Patch applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt