2023-11-01 13:26:31

by Michael S. Tsirkin

[permalink] [raw]
Subject: Re: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context

On Sun, Sep 24, 2023 at 07:39:41PM +0200, Halil Pasic wrote:
> On Sun, 24 Sep 2023 11:56:25 +0000
> "Gonglei (Arei)" <[email protected]> wrote:
>
> > Hi Halil,
> >
> > Commit 4058cf08945 introduced a check for detecting crypto completion function
> > called with enable BH, and indeed the virtio-crypto driver didn't disable BH, which needs
> > a patch to fix it.
> >
> > P.S.: https://lore.kernel.org/lkml/[email protected]/T/
> >
> > Regards,
> > -Gonglei
>
> Thanks Gonglei!
>
> Thanks! I would be glad to test that fix on s390x. Are you about to send
> one?
>
> Regards,
> Halil


Gonglei did you intend to send a fix?


2023-11-02 13:05:05

by Gonglei (Arei)

[permalink] [raw]
Subject: RE: virtcrypto_dataq_callback calls crypto_finalize_request() from irq context



> -----Original Message-----
> From: Michael S. Tsirkin [mailto:[email protected]]
> Sent: Wednesday, November 1, 2023 9:26 PM
> To: Halil Pasic <[email protected]>
> Cc: Gonglei (Arei) <[email protected]>; Herbert Xu
> <[email protected]>; Jason Wang <[email protected]>;
> [email protected]; [email protected];
> [email protected]; Marc Hartmayer <[email protected]>
> Subject: Re: virtcrypto_dataq_callback calls crypto_finalize_request() from irq
> context
>
> On Sun, Sep 24, 2023 at 07:39:41PM +0200, Halil Pasic wrote:
> > On Sun, 24 Sep 2023 11:56:25 +0000
> > "Gonglei (Arei)" <[email protected]> wrote:
> >
> > > Hi Halil,
> > >
> > > Commit 4058cf08945 introduced a check for detecting crypto
> > > completion function called with enable BH, and indeed the
> > > virtio-crypto driver didn't disable BH, which needs a patch to fix it.
> > >
> > > P.S.:
> > > https://lore.kernel.org/lkml/20220221120833.2618733-5-clabbe@baylibr
> > > e.com/T/
> > >
> > > Regards,
> > > -Gonglei
> >
> > Thanks Gonglei!
> >
> > Thanks! I would be glad to test that fix on s390x. Are you about to
> > send one?
> >
> > Regards,
> > Halil
>
>
> Gonglei did you intend to send a fix?

Actually I sent a patch a month ago, pls see another thread.


Regards,
-Gonglei