2023-08-04 08:48:56

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 1/7] crypto: hisilicon/qm - obtain the mailbox configuration at one time

On Sat, Jul 29, 2023 at 08:52:33PM +0800, Weili Qian wrote:
> The mailbox configuration(128 bits) needs to be obtained from the
> hardware at one time. If the mailbox configuration is obtained for
> multiple times, the read value may be incorrect. Use the instruction
> to read mailbox data instead of readl().
>
> Signed-off-by: Weili Qian <[email protected]>

Your patch description makes no sense to me. Please explain more
clearly why you're replacing generic IO primitives with hand-rolled
assembly.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


2023-08-07 02:39:13

by Weili Qian

[permalink] [raw]
Subject: Re: [PATCH 1/7] crypto: hisilicon/qm - obtain the mailbox configuration at one time



On 2023/8/4 16:26, Herbert Xu wrote:
> Your patch description makes no sense to me. Please explain more
> clearly why you're replacing generic IO primitives with hand-rolled
> assembly.

Sorry,I will re-describe the problem that this patch fixes.

Thanks,
Weili