2024-01-24 13:12:57

by Stefan Hajnoczi

[permalink] [raw]
Subject: Re: [PATCH] virtio_crypto: remove duplicate check if queue is broken

On Wed, 24 Jan 2024 at 07:27, Li RongQing <[email protected]> wrote:
>
> virtqueue_enable_cb() will call virtqueue_poll() which will check if
> queue is broken at beginning, so remove the virtqueue_is_broken() call
>
> Signed-off-by: Li RongQing <[email protected]>
> ---
> drivers/crypto/virtio/virtio_crypto_core.c | 2 --
> 1 file changed, 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <[email protected]>

>
> diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c
> index 43a0838..3607b6f 100644
> --- a/drivers/crypto/virtio/virtio_crypto_core.c
> +++ b/drivers/crypto/virtio/virtio_crypto_core.c
> @@ -42,8 +42,6 @@ static void virtcrypto_ctrlq_callback(struct virtqueue *vq)
> virtio_crypto_ctrlq_callback(vc_ctrl_req);
> spin_lock_irqsave(&vcrypto->ctrl_lock, flags);
> }
> - if (unlikely(virtqueue_is_broken(vq)))
> - break;
> } while (!virtqueue_enable_cb(vq));
> spin_unlock_irqrestore(&vcrypto->ctrl_lock, flags);
> }
> --
> 2.9.4
>
>