2019-12-07 04:20:49

by Eric Biggers

Subject: [PATCH] crypto: doc - remove references to ARC4

From: Eric Biggers <[email protected]>

arc4 is no longer considered secure, so it shouldn't be used, even as
just an example. Mention serpent and chacha20 instead.

Signed-off-by: Eric Biggers <[email protected]>
---
Documentation/crypto/devel-algos.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/crypto/devel-algos.rst b/Documentation/crypto/devel-algos.rst
index f9d288015acc..fb6b7979a1de 100644
--- a/Documentation/crypto/devel-algos.rst
+++ b/Documentation/crypto/devel-algos.rst
@@ -57,7 +57,7 @@ follows:
Single-Block Symmetric Ciphers [CIPHER]
---------------------------------------

-Example of transformations: aes, arc4, ...
+Example of transformations: aes, serpent, ...

This section describes the simplest of all transformation
implementations, that being the CIPHER type used for symmetric ciphers.
@@ -108,7 +108,7 @@ is also valid:
Multi-Block Ciphers
-------------------

-Example of transformations: cbc(aes), ecb(arc4), ...
+Example of transformations: cbc(aes), chacha20, ...

This section describes the multi-block cipher transformation
implementations. The multi-block ciphers are used for transformations
--
2.24.0

2019-12-07 10:16:28

by Ard Biesheuvel

Subject: Re: [PATCH] crypto: doc - remove references to ARC4

On Sat, 7 Dec 2019 at 04:20, Eric Biggers <[email protected]> wrote:
>
> From: Eric Biggers <[email protected]>
>
> arc4 is no longer considered secure, so it shouldn't be used, even as
> just an example. Mention serpent and chacha20 instead.
>
> Signed-off-by: Eric Biggers <[email protected]>

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> Documentation/crypto/devel-algos.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/crypto/devel-algos.rst b/Documentation/crypto/devel-algos.rst
> index f9d288015acc..fb6b7979a1de 100644
> --- a/Documentation/crypto/devel-algos.rst
> +++ b/Documentation/crypto/devel-algos.rst
> @@ -57,7 +57,7 @@ follows:
> Single-Block Symmetric Ciphers [CIPHER]
> ---------------------------------------
>
> -Example of transformations: aes, arc4, ...
> +Example of transformations: aes, serpent, ...
>
> This section describes the simplest of all transformation
> implementations, that being the CIPHER type used for symmetric ciphers.
> @@ -108,7 +108,7 @@ is also valid:
> Multi-Block Ciphers
> -------------------
>
> -Example of transformations: cbc(aes), ecb(arc4), ...
> +Example of transformations: cbc(aes), chacha20, ...
>
> This section describes the multi-block cipher transformation
> implementations. The multi-block ciphers are used for transformations
> --
> 2.24.0
>

2019-12-11 09:46:23

by Herbert Xu

Subject: Re: [PATCH] crypto: doc - remove references to ARC4

Eric Biggers <[email protected]> wrote:
> From: Eric Biggers <[email protected]>
>
> arc4 is no longer considered secure, so it shouldn't be used, even as
> just an example. Mention serpent and chacha20 instead.
>
> Signed-off-by: Eric Biggers <[email protected]>
> ---
> Documentation/crypto/devel-algos.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt