2023-05-20 17:42:28

by Eric Biggers

Subject: [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS

From: Eric Biggers <[email protected]>

Make the help text for CRYPTO_STATS explicitly mention that it reduces
the performance of the crypto API.

Signed-off-by: Eric Biggers <[email protected]>
---
crypto/Kconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 42751d63cd4d9..fdf3742f1106b 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1393,6 +1393,9 @@ config CRYPTO_STATS
help
Enable the gathering of crypto stats.

+ Enabling this option reduces the performance of the crypto API. It
+ should only be enabled when there is actually a use case for it.
+
This collects data sizes, numbers of requests, and numbers
of errors processed by:
- AEAD ciphers (encrypt, decrypt)

base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c
--
2.40.1

2023-05-20 17:43:15

by Ard Biesheuvel

Subject: Re: [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS

On Sat, 20 May 2023 at 19:31, Eric Biggers <[email protected]> wrote:
>
> From: Eric Biggers <[email protected]>
>
> Make the help text for CRYPTO_STATS explicitly mention that it reduces
> the performance of the crypto API.
>
> Signed-off-by: Eric Biggers <[email protected]>

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> crypto/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 42751d63cd4d9..fdf3742f1106b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1393,6 +1393,9 @@ config CRYPTO_STATS
> help
> Enable the gathering of crypto stats.
>
> + Enabling this option reduces the performance of the crypto API. It
> + should only be enabled when there is actually a use case for it.
> +
> This collects data sizes, numbers of requests, and numbers
> of errors processed by:
> - AEAD ciphers (encrypt, decrypt)
>
> base-commit: f573db7aa528f11820dcc811bc7791b231d22b1c
> --
> 2.40.1
>

2023-05-24 10:48:01

by Herbert Xu

Subject: Re: [PATCH] crypto/Kconfig: warn about performance overhead of CRYPTO_STATS

Eric Biggers <[email protected]> wrote:
> From: Eric Biggers <[email protected]>
>
> Make the help text for CRYPTO_STATS explicitly mention that it reduces
> the performance of the crypto API.
>
> Signed-off-by: Eric Biggers <[email protected]>
> ---
> crypto/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt