2024-05-02 15:10:47

by Akhil R

[permalink] [raw]
Subject: RE: [PATCH v7 0/5] Add Tegra Security Engine driver

> On Wed, May 01, 2024 at 04:52:05AM +0000, Akhil R wrote:
> >
> > I had a question based on some of our customer feedback with this driver.
> > While running tcrypt mode=10 with Tegra SE driver, it shows errors for lrw(aes),
> > rfc3686(ctr(aes)) etc. which it does not support.
>
> Algorithms that are not supported by your driver should automatically
> be routed to software implementations. What errors are you getting?
I get the below error. But this is because we don't have CONFIG_LRW
enabled in our defconfig.

[ 1240.771301] alg: skcipher: failed to allocate transform for lrw(aes): -2
[ 1240.778308] alg: self-tests for lrw(aes) using lrw(aes) failed (rc=-2)

So, I suppose enabling the defconfig is the right and only fix here?

Thanks and Regards,
Akhil


2024-05-03 09:17:08

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH v7 0/5] Add Tegra Security Engine driver


On 02/05/2024 15:56, Akhil R wrote:
>> On Wed, May 01, 2024 at 04:52:05AM +0000, Akhil R wrote:
>>>
>>> I had a question based on some of our customer feedback with this driver.
>>> While running tcrypt mode=10 with Tegra SE driver, it shows errors for lrw(aes),
>>> rfc3686(ctr(aes)) etc. which it does not support.
>>
>> Algorithms that are not supported by your driver should automatically
>> be routed to software implementations. What errors are you getting?
> I get the below error. But this is because we don't have CONFIG_LRW
> enabled in our defconfig.
>
> [ 1240.771301] alg: skcipher: failed to allocate transform for lrw(aes): -2
> [ 1240.778308] alg: self-tests for lrw(aes) using lrw(aes) failed (rc=-2)
>
> So, I suppose enabling the defconfig is the right and only fix here?

Should we be selecting for option for Tegra so there is a clear dependency?

Jon

--
nvpublic